Re: svn commit: r212439 - head/sys/fs/nfs

2010-09-12 Thread Kostik Belousov
On Sat, Sep 11, 2010 at 08:41:22PM -0400, Rick Macklem wrote: > > Then, fid_reserved is no more reserved ? Should we rename it ? > > > > Comment for fid_reserved about longword alignment is wrong. > > Well, it's actually more broken than that. > fid_len - Most file systems set it to the size of t

Re: svn commit: r212439 - head/sys/fs/nfs

2010-09-11 Thread mdf
On Sun, Sep 12, 2010 at 12:41 AM, Rick Macklem wrote: >> Then, fid_reserved is no more reserved ? Should we rename it ? >> >> Comment for fid_reserved about longword alignment is wrong. > > Well, it's actually more broken than that. > fid_len - Most file systems set it to the size of their variant

Re: svn commit: r212439 - head/sys/fs/nfs

2010-09-11 Thread Rick Macklem
> Then, fid_reserved is no more reserved ? Should we rename it ? > > Comment for fid_reserved about longword alignment is wrong. Well, it's actually more broken than that. fid_len - Most file systems set it to the size of their variant of the entire structure, including the Xfid_len fie

Re: svn commit: r212439 - head/sys/fs/nfs

2010-09-10 Thread Kostik Belousov
On Fri, Sep 10, 2010 at 11:18:45PM +, Rick Macklem wrote: > Author: rmacklem > Date: Fri Sep 10 23:18:45 2010 > New Revision: 212439 > URL: http://svn.freebsd.org/changeset/base/212439 > > Log: > Fix the NFSVNO_CMPFH() macro in the experimental NFS server so > that it works correctly for Z

svn commit: r212439 - head/sys/fs/nfs

2010-09-10 Thread Rick Macklem
Author: rmacklem Date: Fri Sep 10 23:18:45 2010 New Revision: 212439 URL: http://svn.freebsd.org/changeset/base/212439 Log: Fix the NFSVNO_CMPFH() macro in the experimental NFS server so that it works correctly for ZFS file handles. It is possible to have two ZFS file handles that differ onl