Re: svn commit: r206843 - head/sbin/ipfw

2010-04-20 Thread Robert Noland
Julian Elischer wrote: On 4/19/10 9:01 AM, Robert Noland wrote: Luigi Rizzo wrote: [...] Index: sbin/ipfw/ipfw2.c === --- sbin/ipfw/ipfw2.c (revision 206844) +++ sbin/ipfw/ipfw2.c (working copy) @@ -326,7 +326,7 @@ #ifdef T

Re: svn commit: r206843 - head/sbin/ipfw

2010-04-20 Thread Bruce Evans
On Tue, 20 Apr 2010, Luigi Rizzo wrote: On Mon, Apr 19, 2010 at 03:44:25PM -0700, Julian Elischer wrote: On 4/19/10 9:01 AM, Robert Noland wrote: Luigi Rizzo wrote: [...] Index: sbin/ipfw/ipfw2.c === --- sbin/ipfw/ipfw2.c (

Re: svn commit: r206843 - head/sbin/ipfw

2010-04-19 Thread Luigi Rizzo
On Mon, Apr 19, 2010 at 03:44:25PM -0700, Julian Elischer wrote: > On 4/19/10 9:01 AM, Robert Noland wrote: > > > > > >Luigi Rizzo wrote: > > > [...] > > >Index: sbin/ipfw/ipfw2.c > >=== > >--- sbin/ipfw/ipfw2.c (revision 206844) >

Re: svn commit: r206843 - head/sbin/ipfw

2010-04-19 Thread Joerg Sonnenberger
On Mon, Apr 19, 2010 at 03:44:25PM -0700, Julian Elischer wrote: > >Index: sbin/ipfw/ipfw2.c > >=== > >--- sbin/ipfw/ipfw2.c (revision 206844) > >+++ sbin/ipfw/ipfw2.c (working copy) > >@@ -326,7 +326,7 @@ > >#ifdef TCC > >#define U64_

Re: svn commit: r206843 - head/sbin/ipfw

2010-04-19 Thread Julian Elischer
On 4/19/10 9:01 AM, Robert Noland wrote: Luigi Rizzo wrote: [...] Index: sbin/ipfw/ipfw2.c === --- sbin/ipfw/ipfw2.c (revision 206844) +++ sbin/ipfw/ipfw2.c (working copy) @@ -326,7 +326,7 @@ #ifdef TCC #define U64_FMT "I64" #

Re: svn commit: r206843 - head/sbin/ipfw

2010-04-19 Thread Luigi Rizzo
On Mon, Apr 19, 2010 at 11:01:40AM -0500, Robert Noland wrote: ... > >+#ifdef TCC > >+#define U64_FMT "I64" > >+#else > >+#define U64_FMT "llu" > > This is broken on amd64. It either needs casting or the following patch... thanks, i prefer passing through an unsigned long long as in the previous

Re: svn commit: r206843 - head/sbin/ipfw

2010-04-19 Thread Robert Noland
Luigi Rizzo wrote: Author: luigi Date: Mon Apr 19 15:11:45 2010 New Revision: 206843 URL: http://svn.freebsd.org/changeset/base/206843 Log: Slightly different handling of printf/snprintf for unaligned uint64_t, which should improve readability, and also to ease the port to platforms that

svn commit: r206843 - head/sbin/ipfw

2010-04-19 Thread Luigi Rizzo
Author: luigi Date: Mon Apr 19 15:11:45 2010 New Revision: 206843 URL: http://svn.freebsd.org/changeset/base/206843 Log: Slightly different handling of printf/snprintf for unaligned uint64_t, which should improve readability, and also to ease the port to platforms that do not support %llu