Re: svn commit: r200743 - in head/usr.sbin: . service

2010-02-23 Thread Cyrille Lefevre
Doug Barton a écrit : I agree to making the change you suggested, but I would like to quibble over the format. Isn't the attached patch equivalent, and simpler? What is the value of setting HOME and PATH in the environment if we're just going to use 'env -i HOME PATH' anyway? how about to repl

Re: svn commit: r200743 - in head/usr.sbin: . service

2010-02-23 Thread Cyrille Lefevre
Cyrille Lefevre a écrit : Doug Barton a écrit : I agree to making the change you suggested, but I would like to quibble over the format. Isn't the attached patch equivalent, and simpler? What is the value of setting HOME and PATH in the environment if we're just going to use 'env -i HOME PATH'

Re: svn commit: r200743 - in head/usr.sbin: . service

2010-01-08 Thread David Schultz
On Mon, Dec 21, 2009, M. Warner Losh wrote: > In message: <20091220183519.gb64...@lor.one-eyed-alien.net> > Brooks Davis writes: > : This is where the value of service(8) would lie for me. The ability > : to not have things work by accident due to my environment and then break > : at

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-27 Thread Doug Barton
Ed Schouten wrote: > Doug, > > Even though I think having a help-feature is nice, just expecting users > to open up the proper manual page seems to be our tradition. Because of > that, I think we should change the usage-output to conform a bit more > with other applications. Sorry, I don't agree.

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-27 Thread Ed Schouten
* Ed Schouten wrote: > while getopts 'ehlrv' COMMAND_LINE_ARGUMENT ; do ^ Should be removed here as well, of course. -- Ed Schouten WWW: http://80386.nl/ pgpQlwdgVUV9q.pgp Description: PGP signature

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-27 Thread Ed Schouten
Doug, Even though I think having a help-feature is nice, just expecting users to open up the proper manual page seems to be our tradition. Because of that, I think we should change the usage-output to conform a bit more with other applications. We should also display "-l | -r" instead of "-l|r".

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-21 Thread M. Warner Losh
In message: <20091220183519.gb64...@lor.one-eyed-alien.net> Brooks Davis writes: : On Sun, Dec 20, 2009 at 06:31:56PM +0900, Hajimu UMEMOTO wrote: : > Hi, : > : > > On Sat, 19 Dec 2009 23:30:41 -0800 : > > Doug Barton said: : > : > > About the value this change, I think it s

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-21 Thread Doug Barton
Hajimu UMEMOTO wrote: >> On Sun, 20 Dec 2009 12:10:55 -0800 >> Doug Barton said: > > dougb> I agree to making the change you suggested, but I would like to > dougb> quibble over the format. Isn't the attached patch equivalent, and > dougb> simpler? What is the value of setting HOME and PA

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-21 Thread Hajimu UMEMOTO
Hi, > On Sun, 20 Dec 2009 12:10:55 -0800 > Doug Barton said: dougb> I agree to making the change you suggested, but I would like to dougb> quibble over the format. Isn't the attached patch equivalent, and dougb> simpler? What is the value of setting HOME and PATH in the environment dougb

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-20 Thread Doug Barton
Robert Watson wrote: > With Apple's launchd, service descriptions can include user credentials > that will be set before the service is started. Being able to do that > here as well would be great, especially in a future where part of our > supplemental user credential will be additional system pr

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-20 Thread Doug Barton
Hajimu UMEMOTO wrote: > Yup, I often do restart the services installed from ports, too. > I meant that I don't want that the values of user environment are > inherited to the services which is started from the user environment. And I meant that I see the ability to start services AND inherit the u

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-20 Thread Doug Barton
Jilles Tjoelker wrote: >> +exec env -i HOME=$HOME PATH=$PATH $dir/$script $* >> fi >> done > > The $* should be changed to "$@" here, to avoid inappropriate IFS > splitting. (Even though rc.subr is broken in this way as well.) In concept I agree with you, however I want to remai

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-20 Thread Robert Watson
On Sun, 20 Dec 2009, Brooks Davis wrote: About the value this change, I think it should be same as the values at boot time. I cannot imagine that someone want to restart the system daemons under the user environment. dougb> I can actually, especially for ports. Yup, I often do restart the s

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-20 Thread Brooks Davis
On Sun, Dec 20, 2009 at 06:31:56PM +0900, Hajimu UMEMOTO wrote: > Hi, > > > On Sat, 19 Dec 2009 23:30:41 -0800 > > Doug Barton said: > > > About the value this change, I think it should be same as the values > > at boot time. I cannot imagine that someone want to restart the > > system

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-20 Thread Jilles Tjoelker
On Sat, Dec 19, 2009 at 11:30:41PM -0800, Doug Barton wrote: > Index: usr.sbin/service/service.sh > diff -u usr.sbin/service/service.sh.orig usr.sbin/service/service.sh > --- usr.sbin/service/service.sh.orig 2009-12-20 13:14:14.0 +0900 > +++ usr.sbin/service/service.sh 2009-12-20 13:

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-20 Thread Kostik Belousov
On Sun, Dec 20, 2009 at 06:31:56PM +0900, Hajimu UMEMOTO wrote: > Hi, > > > On Sat, 19 Dec 2009 23:30:41 -0800 > > Doug Barton said: > > > About the value this change, I think it should be same as the values > > at boot time. I cannot imagine that someone want to restart the > > system

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-20 Thread Norikatsu Shigemura
On Sun, 20 Dec 2009 18:31:56 +0900 Hajimu UMEMOTO wrote: > > About the value this change, I think it should be same as the values > > at boot time. I cannot imagine that someone want to restart the > > system daemons under the user environment. > dougb> I can actually, especially for ports. > Yu

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-20 Thread Hajimu UMEMOTO
Hi, > On Sat, 19 Dec 2009 23:30:41 -0800 > Doug Barton said: > About the value this change, I think it should be same as the values > at boot time. I cannot imagine that someone want to restart the > system daemons under the user environment. dougb> I can actually, especially for port

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-20 Thread Ruslan Mahmatkhanov
Good day! 20.12.2009 04:34, Doug Barton пишет: Author: dougb Date: Sun Dec 20 01:34:12 2009 New Revision: 200743 URL: http://svn.freebsd.org/changeset/base/200743 Log: The service command is an easy interface to the rc.d system. Its primary purpose is to start and stop services provided b

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-19 Thread Doug Barton
I've reattached your original patch and included the freebsd-rc list. Hajimu UMEMOTO wrote: > Hi, > >> On Sat, 19 Dec 2009 21:51:13 -0800 >> Doug Barton said: > > dougb> Other than the removal of "exit $?" I'm not necessarily opposed to > dougb> that idea, but I'm wondering what value t

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-19 Thread Hajimu UMEMOTO
Hi, > On Sat, 19 Dec 2009 21:51:13 -0800 > Doug Barton said: dougb> Other than the removal of "exit $?" I'm not necessarily opposed to dougb> that idea, but I'm wondering what value this change would have in the dougb> "system is already up and running" case (when it will be executed) vs

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-19 Thread Doug Barton
Hajimu UMEMOTO wrote: > I believe this addition is useful. Thanks. :) > I'm using similar script locally. > However, we should consider the environment variables and the current > directory, IMO. Could you include the attached patch? Other than the removal of "exit $?" I'm not necessarily oppos

Re: svn commit: r200743 - in head/usr.sbin: . service

2009-12-19 Thread Hajimu UMEMOTO
Hi, > On Sun, 20 Dec 2009 01:34:12 + (UTC) > Doug Barton said: dougb> Author: dougb dougb> Date: Sun Dec 20 01:34:12 2009 dougb> New Revision: 200743 dougb> URL: http://svn.freebsd.org/changeset/base/200743 dougb> Log: dougb> The service command is an easy interface to the rc.d sy

svn commit: r200743 - in head/usr.sbin: . service

2009-12-19 Thread Doug Barton
Author: dougb Date: Sun Dec 20 01:34:12 2009 New Revision: 200743 URL: http://svn.freebsd.org/changeset/base/200743 Log: The service command is an easy interface to the rc.d system. Its primary purpose is to start and stop services provided by the rc.d scripts, however it can also be used to