Re: svn commit: r192094 - head/sys/kern

2009-05-15 Thread Florian Smeets
On 15.05.09 12:38, Kostik Belousov wrote: On Fri, May 15, 2009 at 12:48:52PM +0300, Kostik Belousov wrote: On Fri, May 15, 2009 at 10:06:13AM +0200, Peter Holm wrote: On Fri, May 15, 2009 at 09:02:39AM +0200, Ed Schouten wrote: Hi Kostik, * Konstantin Belousov wrote: Log: Do not advance

Re: svn commit: r192094 - head/sys/kern

2009-05-15 Thread Kostik Belousov
On Fri, May 15, 2009 at 12:48:52PM +0300, Kostik Belousov wrote: > On Fri, May 15, 2009 at 10:06:13AM +0200, Peter Holm wrote: > > On Fri, May 15, 2009 at 09:02:39AM +0200, Ed Schouten wrote: > > > Hi Kostik, > > > > > > * Konstantin Belousov wrote: > > > > Log: > > > > Do not advance req->oldi

Re: svn commit: r192094 - head/sys/kern

2009-05-15 Thread Peter Holm
On Fri, May 15, 2009 at 12:48:52PM +0300, Kostik Belousov wrote: > On Fri, May 15, 2009 at 10:06:13AM +0200, Peter Holm wrote: > > On Fri, May 15, 2009 at 09:02:39AM +0200, Ed Schouten wrote: > > > Hi Kostik, > > > > > > * Konstantin Belousov wrote: > > > > Log: > > > > Do not advance req->oldi

Re: svn commit: r192094 - head/sys/kern

2009-05-15 Thread Kostik Belousov
On Fri, May 15, 2009 at 10:06:13AM +0200, Peter Holm wrote: > On Fri, May 15, 2009 at 09:02:39AM +0200, Ed Schouten wrote: > > Hi Kostik, > > > > * Konstantin Belousov wrote: > > > Log: > > > Do not advance req->oldidx when sysctl_old_user returning an > > > error due to copyout failure or sh

Re: svn commit: r192094 - head/sys/kern

2009-05-15 Thread Peter Holm
On Fri, May 15, 2009 at 09:02:39AM +0200, Ed Schouten wrote: > Hi Kostik, > > * Konstantin Belousov wrote: > > Log: > > Do not advance req->oldidx when sysctl_old_user returning an > > error due to copyout failure or short buffer. > > > > The later breaks the usermode iterators of the sy

Re: svn commit: r192094 - head/sys/kern

2009-05-15 Thread Florian Smeets
On 15.05.09 09:02, Ed Schouten wrote: Hi Kostik, * Konstantin Belousov wrote: Log: Do not advance req->oldidx when sysctl_old_user returning an error due to copyout failure or short buffer. The later breaks the usermode iterators of the sysctl results that pack arbitrary number of

Re: svn commit: r192094 - head/sys/kern

2009-05-15 Thread Ed Schouten
Hi Kostik, * Konstantin Belousov wrote: > Log: > Do not advance req->oldidx when sysctl_old_user returning an > error due to copyout failure or short buffer. > > The later breaks the usermode iterators of the sysctl results that pack > arbitrary number of variable-sized structures. Ite

svn commit: r192094 - head/sys/kern

2009-05-14 Thread Konstantin Belousov
Author: kib Date: Thu May 14 10:54:57 2009 New Revision: 192094 URL: http://svn.freebsd.org/changeset/base/192094 Log: Do not advance req->oldidx when sysctl_old_user returning an error due to copyout failure or short buffer. The later breaks the usermode iterators of the sysctl results t