Re: svn commit: r191060 - in head/sys/dev: twa twe

2009-04-23 Thread Ed Schouten
* Alexey Dokuchaev wrote: > But it looks like style bug which is supposed to get fixed, not > duplicated. I am wrong? Well, at least I didn't make it less consistent by using a different amount of tabs. It's not like I introduced any style(9) bugs, mainly because the code doesn't comply with sty

Re: svn commit: r191060 - in head/sys/dev: twa twe

2009-04-22 Thread Alexey Dokuchaev
On Thu, Apr 23, 2009 at 01:02:10AM +0200, Ed Schouten wrote: > * Stanislav Sedov wrote: > > Any reason to have two tabs here? > > Yes. I think the ioctl() function in the same file also used this line, > so I just literally copy/pasted it into open()/close(). But it looks like style bug which is

Re: svn commit: r191060 - in head/sys/dev: twa twe

2009-04-22 Thread Ed Schouten
* Stanislav Sedov wrote: > Any reason to have two tabs here? Yes. I think the ioctl() function in the same file also used this line, so I just literally copy/pasted it into open()/close(). -- Ed Schouten WWW: http://80386.nl/ pgpxTr4MiFdRC.pgp Description: PGP signature

Re: svn commit: r191060 - in head/sys/dev: twa twe

2009-04-22 Thread Stanislav Sedov
On Tue, 14 Apr 2009 14:02:43 + (UTC) Ed Schouten mentioned: > Author: ed > Date: Tue Apr 14 14:02:43 2009 > New Revision: 191060 > URL: http://svn.freebsd.org/changeset/base/191060 > > Log: > Use si_drv1 instead of dev2unit() in twe(4) and twa(4) > > Reviewed by:scottl > > Mo

svn commit: r191060 - in head/sys/dev: twa twe

2009-04-14 Thread Ed Schouten
Author: ed Date: Tue Apr 14 14:02:43 2009 New Revision: 191060 URL: http://svn.freebsd.org/changeset/base/191060 Log: Use si_drv1 instead of dev2unit() in twe(4) and twa(4) Reviewed by: scottl Modified: head/sys/dev/twa/tw_osl_freebsd.c head/sys/dev/twe/twe_freebsd.c Modified: head/s