Re: svn commit: r189619 - head/sys/dev/cardbus

2009-03-12 Thread John Baldwin
On Thursday 12 March 2009 3:03:28 am M. Warner Losh wrote: > In message: <200903100904.38679@freebsd.org> > John Baldwin writes: > : It might be best to do this before releasing the resources rather than > : afterwards. > > It certainly does no harm to move them, and I will do so

Re: svn commit: r189619 - head/sys/dev/cardbus

2009-03-12 Thread M. Warner Losh
In message: <200903100904.38679@freebsd.org> John Baldwin writes: : It might be best to do this before releasing the resources rather than : afterwards. It certainly does no harm to move them, and I will do so. However, what problems do you see with doing it in the current order

Re: svn commit: r189619 - head/sys/dev/cardbus

2009-03-10 Thread John Baldwin
On Tuesday 10 March 2009 8:10:50 am Warner Losh wrote: > Author: imp > Date: Tue Mar 10 12:10:50 2009 > New Revision: 189619 > URL: http://svn.freebsd.org/changeset/base/189619 > > Log: > When freeing all the resources of the card, it is better to turn off > the PORTEN and MEMEN bits in the co

svn commit: r189619 - head/sys/dev/cardbus

2009-03-10 Thread Warner Losh
Author: imp Date: Tue Mar 10 12:10:50 2009 New Revision: 189619 URL: http://svn.freebsd.org/changeset/base/189619 Log: When freeing all the resources of the card, it is better to turn off the PORTEN and MEMEN bits in the command register than to zero the bars. Use pci_write_ivar directl