Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-15 Thread John Baldwin
On 3/15/19 2:36 PM, Chuck Tuffli wrote: > I was contacted by a bhyve user who mentioned that Windows didn't seem > to like bhyve's NVMe emulation. This change doesn't fix that, but this > is one of a handful of changes inspired by qemu. While trying to > reverse engineer why Windows is grumpy, I've

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-15 Thread Chuck Tuffli
Apologies all the way around. I was ignorant about the maintainer for this code and goofed. See inline for other comments. On Fri, Mar 15, 2019 at 9:28 AM John Baldwin wrote: > > On 3/14/19 10:24 PM, Conrad Meyer wrote: > > On Thu, Mar 14, 2019 at 8:06 PM Andrew Thompson wrote: > >> > >> On Fri,

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-15 Thread Warner Losh
On Fri, Mar 15, 2019 at 11:27 AM Rodney W. Grimes wrote: > > On Fri, Mar 15, 2019 at 9:56 AM Rodney W. Grimes < > free...@gndrsh.dnsmgr.net> > > wrote: > > > > > > On Thu, Mar 14, 2019 at 8:32 PM Rodney W. Grimes < > > > free...@gndrsh.dnsmgr.net> > > > > wrote: > > > > > > > > > > Author: chuck

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-15 Thread Marcelo Araujo
Em sáb, 16 de mar de 2019 às 01:27, Rodney W. Grimes < free...@gndrsh.dnsmgr.net> escreveu: > > On Fri, Mar 15, 2019 at 9:56 AM Rodney W. Grimes < > free...@gndrsh.dnsmgr.net> > > wrote: > > > > > > On Thu, Mar 14, 2019 at 8:32 PM Rodney W. Grimes < > > > free...@gndrsh.dnsmgr.net> > > > > wrote:

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-15 Thread Rodney W. Grimes
> On Fri, Mar 15, 2019 at 9:56 AM Rodney W. Grimes > wrote: > > > > On Thu, Mar 14, 2019 at 8:32 PM Rodney W. Grimes < > > free...@gndrsh.dnsmgr.net> > > > wrote: > > > > > > > > Author: chuck > > > > > Date: Fri Mar 15 02:11:28 2019 > > > > > New Revision: 345171 > > > > > URL: https://svnweb.fr

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-15 Thread Warner Losh
On Fri, Mar 15, 2019 at 9:56 AM Rodney W. Grimes wrote: > > On Thu, Mar 14, 2019 at 8:32 PM Rodney W. Grimes < > free...@gndrsh.dnsmgr.net> > > wrote: > > > > > > Author: chuck > > > > Date: Fri Mar 15 02:11:28 2019 > > > > New Revision: 345171 > > > > URL: https://svnweb.freebsd.org/changeset/ba

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-15 Thread Rodney W. Grimes
> Em s?b, 16 de mar de 2019 ?s 00:03, Rodney W. Grimes < > free...@gndrsh.dnsmgr.net> escreveu: > > > > Em sex, 15 de mar de 2019 ?s 22:12, Ian Lepore > > escreveu: > > > > > > > On Thu, 2019-03-14 at 19:31 -0700, Rodney W. Grimes wrote: > > > > > > Author: chuck > > > > > > Date: Fri Mar 15 02:1

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-15 Thread John Baldwin
On 3/15/19 9:27 AM, John Baldwin wrote: > On 3/14/19 10:24 PM, Conrad Meyer wrote: >> On Thu, Mar 14, 2019 at 8:06 PM Andrew Thompson wrote: >>> >>> On Fri, 15 Mar 2019 at 15:11, Chuck Tuffli wrote: bzero(&pciecap, sizeof(pciecap)); >> ... + pciecap.dev_capabilitie

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-15 Thread John Baldwin
On 3/14/19 10:24 PM, Conrad Meyer wrote: > On Thu, Mar 14, 2019 at 8:06 PM Andrew Thompson wrote: >> >> On Fri, 15 Mar 2019 at 15:11, Chuck Tuffli wrote: >>> bzero(&pciecap, sizeof(pciecap)); > ... >>> + pciecap.dev_capabilities = PCIEM_CAP_ROLE_ERR_RPT; >> >> If the message

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-15 Thread Marcelo Araujo
Em sáb, 16 de mar de 2019 às 00:03, Rodney W. Grimes < free...@gndrsh.dnsmgr.net> escreveu: > > Em sex, 15 de mar de 2019 ?s 22:12, Ian Lepore > escreveu: > > > > > On Thu, 2019-03-14 at 19:31 -0700, Rodney W. Grimes wrote: > > > > > Author: chuck > > > > > Date: Fri Mar 15 02:11:28 2019 > > > >

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-15 Thread Pedro Giffuni
On 15/03/2019 11:03, Rodney W. Grimes wrote: Em sex, 15 de mar de 2019 ?s 22:12, Ian Lepore escreveu: On Thu, 2019-03-14 at 19:31 -0700, Rodney W. Grimes wrote: Author: chuck Date: Fri Mar 15 02:11:28 2019 New Revision: 345171 URL: https://svnweb.freebsd.org/changeset/base/345171 Log: Fi

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-15 Thread Rodney W. Grimes
> Em sex, 15 de mar de 2019 ?s 22:12, Ian Lepore escreveu: > > > On Thu, 2019-03-14 at 19:31 -0700, Rodney W. Grimes wrote: > > > > Author: chuck > > > > Date: Fri Mar 15 02:11:28 2019 > > > > New Revision: 345171 > > > > URL: https://svnweb.freebsd.org/changeset/base/345171 > > > > > > > > Log:

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-15 Thread Rodney W. Grimes
> On Thu, Mar 14, 2019 at 8:32 PM Rodney W. Grimes > wrote: > > > > Author: chuck > > > Date: Fri Mar 15 02:11:28 2019 > > > New Revision: 345171 > > > URL: https://svnweb.freebsd.org/changeset/base/345171 > > > > > > Log: > > > Fix bhyve PCIe capability emulation > > > > > > PCIe devices sta

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-15 Thread Warner Losh
On Thu, Mar 14, 2019 at 8:32 PM Rodney W. Grimes wrote: > > Author: chuck > > Date: Fri Mar 15 02:11:28 2019 > > New Revision: 345171 > > URL: https://svnweb.freebsd.org/changeset/base/345171 > > > > Log: > > Fix bhyve PCIe capability emulation > > > > PCIe devices starting with version 1.1 m

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-15 Thread Marcelo Araujo
Em sex, 15 de mar de 2019 às 22:12, Ian Lepore escreveu: > On Thu, 2019-03-14 at 19:31 -0700, Rodney W. Grimes wrote: > > > Author: chuck > > > Date: Fri Mar 15 02:11:28 2019 > > > New Revision: 345171 > > > URL: https://svnweb.freebsd.org/changeset/base/345171 > > > > > > Log: > > > Fix bhyve

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-15 Thread Ian Lepore
On Thu, 2019-03-14 at 19:31 -0700, Rodney W. Grimes wrote: > > Author: chuck > > Date: Fri Mar 15 02:11:28 2019 > > New Revision: 345171 > > URL: https://svnweb.freebsd.org/changeset/base/345171 > > > > Log: > > Fix bhyve PCIe capability emulation > > > > PCIe devices starting with version

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-14 Thread Conrad Meyer
On Thu, Mar 14, 2019 at 8:06 PM Andrew Thompson wrote: > > On Fri, 15 Mar 2019 at 15:11, Chuck Tuffli wrote: >> bzero(&pciecap, sizeof(pciecap)); ... >> + pciecap.dev_capabilities = PCIEM_CAP_ROLE_ERR_RPT; > > If the message you say 'set the bit' but you are overwriting the

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-14 Thread Andrew Thompson
On Fri, 15 Mar 2019 at 15:11, Chuck Tuffli wrote: > Author: chuck > Date: Fri Mar 15 02:11:28 2019 > New Revision: 345171 > URL: https://svnweb.freebsd.org/changeset/base/345171 > > Log: > Fix bhyve PCIe capability emulation > > PCIe devices starting with version 1.1 must set the Role-Based E

Re: svn commit: r345171 - head/usr.sbin/bhyve

2019-03-14 Thread Rodney W. Grimes
> Author: chuck > Date: Fri Mar 15 02:11:28 2019 > New Revision: 345171 > URL: https://svnweb.freebsd.org/changeset/base/345171 > > Log: > Fix bhyve PCIe capability emulation > > PCIe devices starting with version 1.1 must set the Role-Based Error > Reporting bit. > > And while we're