Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-18 Thread Cy Schubert
On January 18, 2019 7:11:05 AM PST, Eugene Grosbein wrote: >On 18.01.2019 19:54, Cy Schubert wrote: > >> In message <81bb343b-ad8a-371d-d94f-f72c8dbce...@grosbein.net>, >Eugene >> Grosbein >> writes: >>> 18.01.2019 5:25, Maxim Sobolev wrote: >>> Using usr.sbin/trim as an example. >>> >>> W

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-18 Thread Warner Losh
On Fri, Jan 18, 2019 at 2:06 AM Eugene Grosbein wrote: > 18.01.2019 7:39, Warner Losh wrote: > > > You hijacked that review. Don't you dare use it as evidence of consent > to the sh*t you just pulled. > > > > Back it out, do a proper review. This one was not proper, nor was it > complete. Don't g

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-18 Thread Eugene Grosbein
On 18.01.2019 19:54, Cy Schubert wrote: > In message <81bb343b-ad8a-371d-d94f-f72c8dbce...@grosbein.net>, Eugene > Grosbein > writes: >> 18.01.2019 5:25, Maxim Sobolev wrote: >> >>> Using usr.sbin/trim as an example. >> >> We still lack a command usable at installation stage (escape to shell) t

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-18 Thread Rodney W. Grimes
> In message <81bb343b-ad8a-371d-d94f-f72c8dbce...@grosbein.net>, Eugene > Grosbein > writes: > > 18.01.2019 5:25, Maxim Sobolev wrote: > > > > > Using usr.sbin/trim as an example. > > > > We still lack a command usable at installation stage (escape to shell) to > > tri > > m a device or partit

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-18 Thread Cy Schubert
In message <81bb343b-ad8a-371d-d94f-f72c8dbce...@grosbein.net>, Eugene Grosbein writes: > 18.01.2019 5:25, Maxim Sobolev wrote: > > > Using usr.sbin/trim as an example. > > We still lack a command usable at installation stage (escape to shell) to tri > m a device or partition > dedicated to ZFS

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-18 Thread Eugene Grosbein
18.01.2019 5:25, Maxim Sobolev wrote: > Using usr.sbin/trim as an example. We still lack a command usable at installation stage (escape to shell) to trim a device or partition dedicated to ZFS Cache/ZFS Intention Log/zvol any other use when ports/packages are not yet available. __

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-18 Thread Eugene Grosbein
18.01.2019 7:39, Warner Losh wrote: > You hijacked that review. Don't you dare use it as evidence of consent to the > sh*t you just pulled. > > Back it out, do a proper review. This one was not proper, nor was it > complete. Don't go using my name to support a program I've come to think is a >

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-18 Thread Eugene Grosbein
18.01.2019 7:54, Warner Losh wrote: > On Thu, Jan 17, 2019 at 5:48 PM Rodney W. Grimes > mailto:free...@pdx.rh.cn85.dnsmgr.net>> > wrote: > > I'm sorry, but I fire back when people abuse me. Sorry, I did not mean to. And I still do not understand how do I abuse you now.

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-18 Thread Eugene Grosbein
18.01.2019 4:45, Conrad Meyer wrote: >>> Please back it out; stop attributing code review to "hackers@," which >>> can not (it's a list, not individuals) and did not review this >>> changeset; and put it on phabricator for actual review. >> >> There is already https://reviews.freebsd.org/D18380 by

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Cy Schubert
In message , Maxim Sobolev writes: > > What I think we really need is some way to easily porti-ze useful stuff > that would otherwise go into /usr/[s]bin, so adding things would be just as > easy as hooking up SUBDIR into usr.[s]bin/Makefile. Yes, I know, this is > topic almost as old as the FreeB

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Cy Schubert
In message , Enji Cooper writes : > > > --Apple-Mail=_6CB1620B-6707-4F06-B7FF-9F1ECBA36F56 > Content-Transfer-Encoding: quoted-printable > Content-Type: text/plain; > charset=utf-8 > > > > On Jan 17, 2019, at 2:25 PM, Maxim Sobolev = > wrote: > >=20 > > What I think we really need is some

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Cy Schubert
In message <201901180008.x0i08thg052...@pdx.rh.cn85.dnsmgr.net>, "Rodney W. Gri mes" writes: > > What I think we really need is some way to easily porti-ze useful stuff > > that would otherwise go into /usr/[s]bin, so adding things would be just as > > easy as hooking up SUBDIR into usr.[s]bin/Mak

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Warner Losh
On Thu, Jan 17, 2019 at 5:48 PM Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > On Thu, Jan 17, 2019 at 3:43 PM Conrad Meyer wrote: > > > > > On Thu, Jan 17, 2019 at 1:16 PM Eugene Grosbein > wrote: > > > > > > > > 18.01.2019 3:23, Conrad Meyer ?: > > > > > > > > > Please back

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Rodney W. Grimes
> On Thu, Jan 17, 2019 at 3:43 PM Conrad Meyer wrote: > > > On Thu, Jan 17, 2019 at 1:16 PM Eugene Grosbein wrote: > > > > > > 18.01.2019 3:23, Conrad Meyer ?: > > > > > > > Please back it out; stop attributing code review to "hackers@," which > > > > can not (it's a list, not individuals) a

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Warner Losh
On Thu, Jan 17, 2019 at 3:43 PM Conrad Meyer wrote: > On Thu, Jan 17, 2019 at 1:16 PM Eugene Grosbein wrote: > > > > 18.01.2019 3:23, Conrad Meyer пишет: > > > > > Please back it out; stop attributing code review to "hackers@," which > > > can not (it's a list, not individuals) and did not revie

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Warner Losh
On Thu, Jan 17, 2019 at 2:16 PM Eugene Grosbein wrote: > 18.01.2019 3:23, Conrad Meyer пишет: > > > Please back it out; stop attributing code review to "hackers@," which > > can not (it's a list, not individuals) and did not review this > > changeset; and put it on phabricator for actual review.

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Rodney W. Grimes
> What I think we really need is some way to easily porti-ze useful stuff > that would otherwise go into /usr/[s]bin, so adding things would be just as > easy as hooking up SUBDIR into usr.[s]bin/Makefile. Yes, I know, this is > topic almost as old as the FreeBSD Project itself, but perhaps we just

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Conrad Meyer
On Thu, Jan 17, 2019 at 1:16 PM Eugene Grosbein wrote: > > 18.01.2019 3:23, Conrad Meyer пишет: > > > Please back it out; stop attributing code review to "hackers@," which > > can not (it's a list, not individuals) and did not review this > > changeset; and put it on phabricator for actual review.

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Enji Cooper
> On Jan 17, 2019, at 2:25 PM, Maxim Sobolev wrote: > > What I think we really need is some way to easily porti-ze useful stuff that > would otherwise go into /usr/[s]bin, so adding things would be just as easy > as hooking up SUBDIR into usr.[s]bin/Makefile. Yes, I know, this is topic > almo

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Maxim Sobolev
What I think we really need is some way to easily porti-ze useful stuff that would otherwise go into /usr/[s]bin, so adding things would be just as easy as hooking up SUBDIR into usr.[s]bin/Makefile. Yes, I know, this is topic almost as old as the FreeBSD Project itself, but perhaps we just did not

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Conrad Meyer
On Thu, Jan 17, 2019 at 12:22 PM Cy Schubert wrote: > This is wrong. IIRC there was discussion that this should be in dd(1). > Why not submit a revision to add the functionality to dd? Well, it's wrong, but not because we need another weird dd mode. dd is hard enough to use already.

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Eugene Grosbein
18.01.2019 3:23, Conrad Meyer пишет: > Please back it out; stop attributing code review to "hackers@," which > can not (it's a list, not individuals) and did not review this > changeset; and put it on phabricator for actual review. There is already https://reviews.freebsd.org/D18380 by imp and th

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Eugene Grosbein
18.01.2019 3:22, Cy Schubert wrote: > This is wrong. IIRC there was discussion that this should be in dd(1). > Why not submit a revision to add the functionality to dd? There is already https://reviews.freebsd.org/D18382 that had no code updates over 6 weeks and latest revision needs a fix as i

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Cy Schubert
In message , Conrad Meyer writes: > On Thu, Jan 17, 2019 at 12:22 PM Cy Schubert wrot > e: > > This is wrong. IIRC there was discussion that this should be in dd(1). > > Why not submit a revision to add the functionality to dd? > > Well, it's wrong, but not because we need another weird dd mode.

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Conrad Meyer
Please back it out; stop attributing code review to "hackers@," which can not (it's a list, not individuals) and did not review this changeset; and put it on phabricator for actual review. I think summary backout is warranted on the basis of your handling of this last time around and lack of attem

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Cy Schubert
In message <201901171808.x0hi80jc068...@repo.freebsd.org>, Eugene Grosbein writ es: > Author: eugen > Date: Thu Jan 17 18:07:59 2019 > New Revision: 343118 > URL: https://svnweb.freebsd.org/changeset/base/343118 > > Log: > Re-add new small tool trim(8) to delete contents for blocks > on device