Re: svn commit: r330352 - in head/sys/compat/linuxkpi/common: include/linux src

2018-03-03 Thread Bruce Evans
On Sat, 3 Mar 2018, Ian Lepore wrote: On Sat, 2018-03-03 at 22:49 +0200, Konstantin Belousov wrote: ,,, BTW mstosbt() and other functions have weird bracing in the formula. I think that the formula as calculated by the C operator precedence is fine, i.e. multiplication is done before right shif

Re: svn commit: r330352 - in head/sys/compat/linuxkpi/common: include/linux src

2018-03-03 Thread Ian Lepore
On Sat, 2018-03-03 at 22:49 +0200, Konstantin Belousov wrote: > On Sat, Mar 03, 2018 at 12:14:42PM -0700, Ian Lepore wrote: > > > > To really avoid roundoff errors, use mstosbt(ms) instead of SBT_1MS*ms. > > > > The rounding errors when multiplying or dividing by SBT_1MS is not > > severe like it

Re: svn commit: r330352 - in head/sys/compat/linuxkpi/common: include/linux src

2018-03-03 Thread Ian Lepore
On Sat, 2018-03-03 at 22:49 +0200, Konstantin Belousov wrote: > On Sat, Mar 03, 2018 at 12:14:42PM -0700, Ian Lepore wrote: > > > > To really avoid roundoff errors, use mstosbt(ms) instead of SBT_1MS*ms. > > > > The rounding errors when multiplying or dividing by SBT_1MS is not > > severe like it

Re: svn commit: r330352 - in head/sys/compat/linuxkpi/common: include/linux src

2018-03-03 Thread Konstantin Belousov
On Sat, Mar 03, 2018 at 12:14:42PM -0700, Ian Lepore wrote: > To really avoid roundoff errors, use mstosbt(ms) instead of SBT_1MS*ms. > > The rounding errors when multiplying or dividing by SBT_1MS is not > severe like it is with SBT_1NS, but the inline functions still do the > arithmetic more cor

Re: svn commit: r330352 - in head/sys/compat/linuxkpi/common: include/linux src

2018-03-03 Thread Hans Petter Selasky
On 03/03/18 20:14, Ian Lepore wrote: On Sat, 2018-03-03 at 18:54 +, Hans Petter Selasky wrote: Author: hselasky Date: Sat Mar  3 18:54:16 2018 New Revision: 330352 URL: https://svnweb.freebsd.org/changeset/base/330352 Log:   Implement msleep_interruptible() in the LinuxKPI. While at it use

Re: svn commit: r330352 - in head/sys/compat/linuxkpi/common: include/linux src

2018-03-03 Thread Ian Lepore
On Sat, 2018-03-03 at 18:54 +, Hans Petter Selasky wrote: > Author: hselasky > Date: Sat Mar  3 18:54:16 2018 > New Revision: 330352 > URL: https://svnweb.freebsd.org/changeset/base/330352 > > Log: >   Implement msleep_interruptible() in the LinuxKPI. While at it use > pause_sbt() >   instead