Re: svn commit: r328313 - head/sys/netpfil/pf

2018-01-25 Thread Gleb Smirnoff
On Thu, Jan 25, 2018 at 02:46:14PM +1100, Kristof Provost wrote: K> On 25 Jan 2018, at 12:08, Kristof Provost wrote: K> > On 25 Jan 2018, at 11:34, Ian Lepore wrote: K> >> On Wed, 2018-01-24 at 16:13 -0800, Gleb Smirnoff wrote: K> >>> (r328313) K> >>> K> @@ -1613,6 +1613,7 @@ int K> >>> K>  pf_unli

Re: svn commit: r328313 - head/sys/netpfil/pf

2018-01-24 Thread Kristof Provost
On 25 Jan 2018, at 12:08, Kristof Provost wrote: On 25 Jan 2018, at 11:34, Ian Lepore wrote: On Wed, 2018-01-24 at 16:13 -0800, Gleb Smirnoff wrote: (r328313) K> @@ -1613,6 +1613,7 @@ int K>  pf_unlink_state(struct pf_state *s, u_int flags) K>  { K>   struct pf_idhash *ih = &V_pf_idhash[PF_IDHA

Re: svn commit: r328313 - head/sys/netpfil/pf

2018-01-24 Thread Warner Losh
On Jan 24, 2018 6:08 PM, "Kristof Provost" wrote: On 25 Jan 2018, at 11:34, Ian Lepore wrote: > On Wed, 2018-01-24 at 16:13 -0800, Gleb Smirnoff wrote: > >> (r328313) >> K> @@ -1613,6 +1613,7 @@ int >> K> pf_unlink_state(struct pf_state *s, u_int flags) >> K> { >> K> struct pf_idhash *ih

Re: svn commit: r328313 - head/sys/netpfil/pf

2018-01-24 Thread Kristof Provost
On 25 Jan 2018, at 11:34, Ian Lepore wrote: On Wed, 2018-01-24 at 16:13 -0800, Gleb Smirnoff wrote: (r328313) K> @@ -1613,6 +1613,7 @@ int K>  pf_unlink_state(struct pf_state *s, u_int flags) K>  { K>   struct pf_idhash *ih = &V_pf_idhash[PF_IDHASH(s)]; K> + int last; K>   K>   if ((flags & PF_E

Re: svn commit: r328313 - head/sys/netpfil/pf

2018-01-24 Thread Ian Lepore
On Wed, 2018-01-24 at 16:13 -0800, Gleb Smirnoff wrote: >   Hi Kristof, > > On Wed, Jan 24, 2018 at 04:29:17AM +, Kristof Provost wrote: > K> Author: kp > K> Date: Wed Jan 24 04:29:16 2018 > K> New Revision: 328313 > K> URL: https://svnweb.freebsd.org/changeset/base/328313 > K>  > K> Log: > K>

Re: svn commit: r328313 - head/sys/netpfil/pf

2018-01-24 Thread Gleb Smirnoff
On Thu, Jan 25, 2018 at 11:16:23AM +1100, Kristof Provost wrote: K> On 25 Jan 2018, at 11:13, Gleb Smirnoff wrote: K> > On Wed, Jan 24, 2018 at 04:29:17AM +, Kristof Provost wrote: K> > K> Author: kp K> > K> Date: Wed Jan 24 04:29:16 2018 K> > K> New Revision: 328313 K> > K> URL: https://svnweb

Re: svn commit: r328313 - head/sys/netpfil/pf

2018-01-24 Thread Kristof Provost
On 25 Jan 2018, at 11:13, Gleb Smirnoff wrote: On Wed, Jan 24, 2018 at 04:29:17AM +, Kristof Provost wrote: K> Author: kp K> Date: Wed Jan 24 04:29:16 2018 K> New Revision: 328313 K> URL: https://svnweb.freebsd.org/changeset/base/328313 K> K> Log: K> pf: States have at least two references

Re: svn commit: r328313 - head/sys/netpfil/pf

2018-01-24 Thread Gleb Smirnoff
Hi Kristof, On Wed, Jan 24, 2018 at 04:29:17AM +, Kristof Provost wrote: K> Author: kp K> Date: Wed Jan 24 04:29:16 2018 K> New Revision: 328313 K> URL: https://svnweb.freebsd.org/changeset/base/328313 K> K> Log: K> pf: States have at least two references K> K> pf_unlink_state() rele