Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-10 Thread Mark Johnston
On Sat, Mar 10, 2018 at 05:01:40PM -0500, David Bright wrote: > With regard to the fsck_ffs behavior being a regression because formerly the > FS would be mounted successfully: > > That was not my experience. What I observed was that the “fsck -y” would give > the “please re-run” message, exit w

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-10 Thread David Bright
With regard to: fsck_y_flags="-T ffs:-R -T ufs:-R" # Additional flags for fsck -y I don’t know how, but I completely missed the -T option for fsck when I was investigating this issue. That would be very useful, although I wanted my solution to be applicable to file systems other than ffs/u

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-10 Thread Cy Schubert
In message <201803101751.w2ahphph070...@pdx.rh.cn85.dnsmgr.net>, "Rodney W. Gri mes" writes: > > On Sat, Mar 10, 2018 at 10:26 AM, Ian Lepore wrote: > > > > > On Sat, 2018-03-10 at 09:02 -0800, Rodney W. Grimes wrote: > > > > > > > > > > On Sat, 2018-03-10 at 08:44 -0800, Rodney W. Grimes wrote:

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-10 Thread Cy Schubert
In message <1520702802.84937.126.ca...@freebsd.org>, Ian Lepore writes: > On Sat, 2018-03-10 at 09:02 -0800, Rodney W. Grimes wrote: > > > > > > On Sat, 2018-03-10 at 08:44 -0800, Rodney W. Grimes wrote: > > > > > [...] > > > > > add "-T ffs:-R" to the initial fsck invocation in rc.d/fsck. > > >

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-10 Thread Rodney W. Grimes
> On Sat, Mar 10, 2018 at 10:26 AM, Ian Lepore wrote: > > > On Sat, 2018-03-10 at 09:02 -0800, Rodney W. Grimes wrote: > > > > > > > > On Sat, 2018-03-10 at 08:44 -0800, Rodney W. Grimes wrote: > > > > > > > [...] > > > > > > add "-T ffs:-R" to the initial fsck invocation in rc.d/fsck. > > > > >

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-10 Thread Warner Losh
On Sat, Mar 10, 2018 at 10:26 AM, Ian Lepore wrote: > On Sat, 2018-03-10 at 09:02 -0800, Rodney W. Grimes wrote: > > > > > > On Sat, 2018-03-10 at 08:44 -0800, Rodney W. Grimes wrote: > > > > > [...] > > > > > add "-T ffs:-R" to the initial fsck invocation in rc.d/fsck. > > > > Please do not do t

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-10 Thread Ian Lepore
On Sat, 2018-03-10 at 09:02 -0800, Rodney W. Grimes wrote: > > > > On Sat, 2018-03-10 at 08:44 -0800, Rodney W. Grimes wrote: > > > [...] > > > > add "-T ffs:-R" to the initial fsck invocation in rc.d/fsck. > > > Please do not do that, if fsck -p fails YOU may optionally > > > wish to continue, o

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-10 Thread Rodney W. Grimes
> On Sat, 2018-03-10 at 08:44 -0800, Rodney W. Grimes wrote: > > [ Charset UTF-8 unsupported, converting... ] > > > > > > On Fri, Mar 09, 2018 at 09:36:25PM -0500, David Bright wrote: > > > > > > > > On Mar 9, 2018, at 17:31, Ian Lepore wrote: > > > > > > > > > > > > > > > On Fri, 2018-03-09 a

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-10 Thread Ian Lepore
On Sat, 2018-03-10 at 08:44 -0800, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] > > > > On Fri, Mar 09, 2018 at 09:36:25PM -0500, David Bright wrote: > > > > > > On Mar 9, 2018, at 17:31, Ian Lepore wrote: > > > > > > > > > > > > On Fri, 2018-03-09 at 17:09 -0500, Mar

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-10 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > On Fri, Mar 09, 2018 at 09:36:25PM -0500, David Bright wrote: > > On Mar 9, 2018, at 17:31, Ian Lepore wrote: > > > > > > On Fri, 2018-03-09 at 17:09 -0500, Mark Johnston wrote: > > >> > > >> etc/rc.d/fsck doesn't know how to interpret the new exit

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-10 Thread Mark Johnston
On Fri, Mar 09, 2018 at 09:36:25PM -0500, David Bright wrote: > On Mar 9, 2018, at 17:31, Ian Lepore wrote: > > > > On Fri, 2018-03-09 at 17:09 -0500, Mark Johnston wrote: > >> > >> etc/rc.d/fsck doesn't know how to interpret the new exit code and now > >> just drops to a single-user shell when

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-10 Thread Ian Lepore
On Fri, 2018-03-09 at 21:36 -0500, David Bright wrote: > On Mar 9, 2018, at 17:31, Ian Lepore wrote: > > > > > > On Fri, 2018-03-09 at 17:09 -0500, Mark Johnston wrote: > > > > > > > > > etc/rc.d/fsck doesn't know how to interpret the new exit code and > > > now > > > just drops to a single-us

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-10 Thread Edward Tomasz Napierała
On 0309T2136, David Bright wrote: > On Mar 9, 2018, at 17:31, Ian Lepore wrote: > > > > On Fri, 2018-03-09 at 17:09 -0500, Mark Johnston wrote: > >> > >> etc/rc.d/fsck doesn't know how to interpret the new exit code and now > >> just drops to a single-user shell when it is encountered. […] > >>

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-09 Thread Eitan Adler
On 9 March 2018 at 18:36, David Bright wrote: > On Mar 9, 2018, at 17:31, Ian Lepore wrote: >> >> On Fri, 2018-03-09 at 17:09 -0500, Mark Johnston wrote: >>> >>> etc/rc.d/fsck doesn't know how to interpret the new exit code and now >>> just drops to a single-user shell when it is encountered. […]

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-09 Thread Ian Lepore
On Fri, 2018-03-09 at 17:09 -0500, Mark Johnston wrote: > On Mon, Jan 15, 2018 at 07:25:11PM +, David Bright wrote: > > > > Author: dab > > Date: Mon Jan 15 19:25:11 2018 > > New Revision: 328013 > > URL: https://svnweb.freebsd.org/changeset/base/328013 > > > > Log: > >   Exit fsck_ffs with n

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-09 Thread Mark Johnston
On Mon, Jan 15, 2018 at 07:25:11PM +, David Bright wrote: > Author: dab > Date: Mon Jan 15 19:25:11 2018 > New Revision: 328013 > URL: https://svnweb.freebsd.org/changeset/base/328013 > > Log: > Exit fsck_ffs with non-zero status when file system is not repaired. > > When the fsck_ffs p