On Mon, Jan 08, 2018 at 04:13:42PM +0100, Ed Schouten wrote:
> Hi Andrew,
>
> 2018-01-08 8:37 GMT+01:00 Andrew Turner :
> > Won???t this lead to a NULL pointer dereference on overflow? mallocarray
> > can return NULL even with M_WAITOK.
>
> Yes, it will, but an overflow shouldn't happen in the f
On Mon, Jan 8, 2018 at 9:29 AM, Mark Johnston wrote:
> On Mon, Jan 08, 2018 at 09:18:28AM -0700, Ian Lepore wrote:
> > On Mon, 2018-01-08 at 09:13 -0700, Warner Losh wrote:
> > > On Jan 8, 2018 8:37 AM, "Pedro Giffuni" wrote:
> > > On 01/08/18 10:13, Ed Schouten wrote:
> > >
> > > >
> > > > Hi A
On Mon, Jan 08, 2018 at 09:18:28AM -0700, Ian Lepore wrote:
> On Mon, 2018-01-08 at 09:13 -0700, Warner Losh wrote:
> > On Jan 8, 2018 8:37 AM, "Pedro Giffuni" wrote:
> > On 01/08/18 10:13, Ed Schouten wrote:
> >
> > >
> > > Hi Andrew,
> > >
> > > 2018-01-08 8:37 GMT+01:00 Andrew Turner :
> > >
On Mon, 2018-01-08 at 09:13 -0700, Warner Losh wrote:
> On Jan 8, 2018 8:37 AM, "Pedro Giffuni" wrote:
>
>
> On 01/08/18 10:13, Ed Schouten wrote:
>
> >
> > Hi Andrew,
> >
> > 2018-01-08 8:37 GMT+01:00 Andrew Turner :
> >
> > >
> > > Won’t this lead to a NULL pointer dereference on overflow
On Jan 8, 2018 8:37 AM, "Pedro Giffuni" wrote:
On 01/08/18 10:13, Ed Schouten wrote:
> Hi Andrew,
>
> 2018-01-08 8:37 GMT+01:00 Andrew Turner :
>
>> Won’t this lead to a NULL pointer dereference on overflow? mallocarray
>> can return NULL even with M_WAITOK.
>>
> Yes, it will, but an overflow s
On 01/08/18 10:13, Ed Schouten wrote:
Hi Andrew,
2018-01-08 8:37 GMT+01:00 Andrew Turner :
Won’t this lead to a NULL pointer dereference on overflow? mallocarray can
return NULL even with M_WAITOK.
Yes, it will, but an overflow shouldn't happen in the first place.
ri_data_len is compared wit
Hi;
On 08/01/2018 02:37, Andrew Turner wrote:
On 7 Jan 2018, at 22:38, Ed Schouten wrote:
Author: ed
Date: Sun Jan 7 22:38:45 2018
New Revision: 327684
URL: https://svnweb.freebsd.org/changeset/base/327684
Log:
Use mallocarray(9) in CloudABI kernel code where possible.
Submitted by: pfg
Hi Andrew,
2018-01-08 8:37 GMT+01:00 Andrew Turner :
> Won’t this lead to a NULL pointer dereference on overflow? mallocarray can
> return NULL even with M_WAITOK.
Yes, it will, but an overflow shouldn't happen in the first place.
ri_data_len is compared with UIO_MAXIOV a few lines above. Even i
> On 7 Jan 2018, at 22:38, Ed Schouten wrote:
>
> Author: ed
> Date: Sun Jan 7 22:38:45 2018
> New Revision: 327684
> URL: https://svnweb.freebsd.org/changeset/base/327684
>
> Log:
> Use mallocarray(9) in CloudABI kernel code where possible.
>
> Submitted by:pfg@
>
> Modified:
> h