Re: svn commit: r327495 - head/usr.sbin/rpcbind

2018-02-04 Thread Konstantin Belousov
On Mon, Feb 05, 2018 at 07:53:03AM +1100, Bruce Evans wrote: > On Sun, 4 Feb 2018, Konstantin Belousov wrote: > > > On Sun, Feb 04, 2018 at 04:15:16PM +1100, Bruce Evans wrote: > >> sig_atomic_t is no better than plain int. This behaviour now makes > >> complete > >> sense. It is just like the

Re: svn commit: r327495 - head/usr.sbin/rpcbind

2018-02-04 Thread Bruce Evans
On Sun, 4 Feb 2018, Konstantin Belousov wrote: On Sun, Feb 04, 2018 at 04:15:16PM +1100, Bruce Evans wrote: sig_atomic_t is no better than plain int. This behaviour now makes complete sense. It is just like the undefined behaviour with the ctype functions, except since we own terminate_wfd we

Re: svn commit: r327495 - head/usr.sbin/rpcbind

2018-02-04 Thread Bruce Evans
On Sat, 3 Feb 2018, Conrad Meyer wrote: On Sat, Feb 3, 2018 at 6:46 AM, Bruce Evans wrote: On Tue, 2 Jan 2018, Conrad Meyer wrote: ... Today I learned from the POSIX list that the pselect() function is designed to avoid this bug. It takes a signal mask arg (like msleep() in the kernel). I

Re: svn commit: r327495 - head/usr.sbin/rpcbind

2018-02-04 Thread Konstantin Belousov
On Sun, Feb 04, 2018 at 04:15:16PM +1100, Bruce Evans wrote: > sig_atomic_t is no better than plain int. This behaviour now makes complete > sense. It is just like the undefined behaviour with the ctype functions, > except since we own terminate_wfd we can guarantee that it doesn't change > while

Re: svn commit: r327495 - head/usr.sbin/rpcbind

2018-02-03 Thread Conrad Meyer
On Sat, Feb 3, 2018 at 6:46 AM, Bruce Evans wrote: > On Tue, 2 Jan 2018, Conrad Meyer wrote: >> ... > Today I learned from the POSIX list that the pselect() function is designed > to avoid this bug. It takes a signal mask arg (like msleep() in the > kernel). > > I haven't noticed any function rel

Re: svn commit: r327495 - head/usr.sbin/rpcbind

2018-02-03 Thread Bruce Evans
On Tue, 2 Jan 2018, Conrad Meyer wrote: Log: rpcbind: Fix race in signal termination I have yet to see any application that was correctly converted from using unsafe signal handlers to safe signal handlers that just set a flag. That is without even noticing this race problem before. If a

Re: svn commit: r327495 - head/usr.sbin/rpcbind

2018-01-02 Thread Conrad Meyer
On Tue, Jan 2, 2018 at 9:25 AM, Conrad Meyer wrote: > Author: cem > Date: Tue Jan 2 17:25:13 2018 > New Revision: 327495 > URL: https://svnweb.freebsd.org/changeset/base/327495 > > Log: > rpcbind: Fix race in signal termination > > If a signal was delivered while the main thread was not in po