Re: svn commit: r312975 - head/sys/i386/include

2017-02-02 Thread Bruce Evans
On Thu, 2 Feb 2017, Konstantin Belousov wrote: On Fri, Feb 03, 2017 at 05:14:15AM +1100, Bruce Evans wrote: You won't want to ifdef this for SMP, so the i386 implementation has further bugs like I expected (fcmpset is not implemented in the CPU_DISABLE_CMPXCHG case). I think it is time to re

Re: svn commit: r312975 - head/sys/i386/include

2017-02-02 Thread Konstantin Belousov
On Fri, Feb 03, 2017 at 05:14:15AM +1100, Bruce Evans wrote: > You won't want to ifdef this for SMP, so the i386 implementation has > further bugs like I expected (fcmpset is not implemented in the > CPU_DISABLE_CMPXCHG case). I think it is time to remove the option. It certainly outlived it use

Re: svn commit: r312975 - head/sys/i386/include

2017-02-02 Thread Bruce Evans
On Thu, 2 Feb 2017, Mateusz Guzik wrote: On Wed, Feb 01, 2017 at 10:12:57PM +1100, Bruce Evans wrote: On Mon, 30 Jan 2017, Bruce Evans wrote: On Mon, 30 Jan 2017, Mateusz Guzik wrote: Log: i386: add atomic_fcmpset Tested by: pho This is has some bugs and style bugs. This is still

Re: svn commit: r312975 - head/sys/i386/include

2017-02-01 Thread Mateusz Guzik
On Wed, Feb 01, 2017 at 10:12:57PM +1100, Bruce Evans wrote: > On Mon, 30 Jan 2017, Bruce Evans wrote: > > >On Mon, 30 Jan 2017, Mateusz Guzik wrote: > > > >>Log: > >> i386: add atomic_fcmpset > >> > >> Tested by: pho > > > >This is has some bugs and style bugs. > > This is still broken. The inv

Re: svn commit: r312975 - head/sys/i386/include

2017-02-01 Thread Bruce Evans
On Mon, 30 Jan 2017, Bruce Evans wrote: On Mon, 30 Jan 2017, Mateusz Guzik wrote: Log: i386: add atomic_fcmpset Tested by: pho This is has some bugs and style bugs. This is still broken. The invalid asm breaks building at least atomic.o with gcc-4.2.1. Tested fix: X Index: i386/i

Re: svn commit: r312975 - head/sys/i386/include

2017-01-29 Thread Bruce Evans
On Mon, 30 Jan 2017, Mateusz Guzik wrote: Log: i386: add atomic_fcmpset Tested by: pho This is has some bugs and style bugs. Modified: head/sys/i386/include/atomic.h Modified: head/sys/i386/include/atomic.h