On 24 November 2016 at 14:39, Dag-Erling Smørgrav wrote:
>
> Precisely. If memory serves, I wrote that comment after receiving a
> patch from someone who made the same mistake that I had already made and
> reverted *twice*. It's the logical, sane thing to do: replace a BSD
> primitive with the e
> On Nov 24, 2016, at 11:06 AM, John Baldwin wrote:
>
> On Thursday, November 24, 2016 02:50:21 PM Dag-Erling Smørgrav wrote:
>> Author: des
>> Date: Thu Nov 24 14:50:21 2016
>> New Revision: 309109
>> URL: https://svnweb.freebsd.org/changeset/base/309109
>>
>> Log:
>> Add a warning against mo
This kind of language isn't really appropriate. Please revert the
commit immediately.
When you've had time to think of an appropriate way to word comments
to the same effect, please commit that separately.
Thanks,
Conrad
On Thu, Nov 24, 2016 at 6:50 AM, Dag-Erling Smørgrav wrote:
> Author: des
I'm happy to have a comment noting the extreme subtleties in play and
calling you out as the domain expert to contact. However, I don't think
that the "UNDER PAIN OF DEATH" is appropriate, even jocularly; there are
other ways to express the needed sentiment that do not cause one to think
about the
John Baldwin writes:
> Of course, there's only one person who has touched flopen [...]
> Perhaps you were just warning yourself? :)
Precisely. If memory serves, I wrote that comment after receiving a
patch from someone who made the same mistake that I had already made and
reverted *twice*. It's
On Thursday, November 24, 2016 05:27:17 PM Dag-Erling Smørgrav wrote:
> Marcelo Araujo writes:
> > We have code review, we have some many ways for communication, even
> > revert a commit if needed.
>
> No. This is the kind of mistake where the code will seem to work just
> fine and end up in a r
On Thursday, November 24, 2016 02:50:21 PM Dag-Erling Smørgrav wrote:
> Author: des
> Date: Thu Nov 24 14:50:21 2016
> New Revision: 309109
> URL: https://svnweb.freebsd.org/changeset/base/309109
>
> Log:
> Add a warning against modifying this code without understanding it, and
> an example of
On Nov 25, 2016 12:27 AM, "Dag-Erling Smørgrav" wrote:
>
> Marcelo Araujo writes:
> > We have code review, we have some many ways for communication, even
> > revert a commit if needed.
>
> No. This is the kind of mistake where the code will seem to work just
> fine and end up in a release before
Marcelo Araujo writes:
> We have code review, we have some many ways for communication, even
> revert a commit if needed.
No. This is the kind of mistake where the code will seem to work just
fine and end up in a release before a user suddenly discovers that they
have two instances of the same d
On Thu, Nov 24, 2016 at 03:39:35PM +, Alexey Dokuchaev wrote:
> It is good for the community and for FreeBSD.
Only if we wish to forever remain a closed, cliquish, group of developers.
mcl
___
svn-src-all@freebsd.org mailing list
https://lists.freeb
I thought the src/MAINTAINERS mechanism was designed for exactly this.
mcl
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
On Thu, Nov 24, 2016 at 11:27:52PM +0800, Marcelo Araujo wrote:
> We have code review, we have some many ways for communication, even revert
> a commit if needed.
Or we can ask people to think twice, so we won't have to revert bogus
commits.
> Please revert it, it is bad for the community and for
On 11/24/16 15:56, Kubilay Kocak wrote:
On 25/11/2016 1:50 AM, Dag-Erling Smørgrav wrote:
+/* + * Reliably open and lock a file. + * + * DO NOT, UNDER PAIN OF
DEATH, modify this code without first reading the + * revision
history and discussing your changes with . + * Don't
be fooled by the code
On Nov 24, 2016 10:50 PM, "Dag-Erling Smørgrav" wrote:
>
> Author: des
> Date: Thu Nov 24 14:50:21 2016
> New Revision: 309109
> URL: https://svnweb.freebsd.org/changeset/base/309109
>
> Log:
> Add a warning against modifying this code without understanding it, and
> an example of how not to m
On Fri, Nov 25, 2016 at 01:56:36AM +1100, Kubilay Kocak wrote:
> On 25/11/2016 1:50 AM, Dag-Erling Sm??rgrav wrote:
> > +/* + * Reliably open and lock a file. + * + * DO NOT, UNDER PAIN OF
> > DEATH, modify this code without first reading the + * revision
> > history and discussing your changes wit
On 25/11/2016 1:50 AM, Dag-Erling Smørgrav wrote:
> +/* + * Reliably open and lock a file. + * + * DO NOT, UNDER PAIN OF
> DEATH, modify this code without first reading the + * revision
> history and discussing your changes with . + * Don't
> be fooled by the code's apparent simplicity; there would
16 matches
Mail list logo
