Re: svn commit: r304011 - head/libexec/rtld-elf

2016-08-16 Thread Bryan Drewery
On 8/16/16 4:32 PM, Ravi Pokala wrote: > -Original Message- > From: on behalf of Bryan Drewery > > Organization: FreeBSD > Date: 2016-08-16, Tuesday at 03:30 > To: Ngie Cooper , Konstantin Belousov > > Cc: , , > > Subject: Re: svn commit: r304011 - he

Re: svn commit: r304011 - head/libexec/rtld-elf

2016-08-16 Thread Ravi Pokala
-Original Message- From: on behalf of Bryan Drewery Organization: FreeBSD Date: 2016-08-16, Tuesday at 03:30 To: Ngie Cooper , Konstantin Belousov Cc: , , Subject: Re: svn commit: r304011 - head/libexec/rtld-elf >On 8/12/16 7:34 PM, Ngie Cooper wrote: >> >>

Re: svn commit: r304011 - head/libexec/rtld-elf

2016-08-16 Thread Bryan Drewery
On 8/12/16 7:34 PM, Ngie Cooper wrote: > >> On Aug 12, 2016, at 11:29, Konstantin Belousov wrote: >> >> Author: kib >> Date: Fri Aug 12 18:29:11 2016 >> New Revision: 304011 >> URL: https://svnweb.freebsd.org/changeset/base/304011 >> >> Log: >> Remove all remaining uses of TAILQ_FOREACH_FROM() f

Re: svn commit: r304011 - head/libexec/rtld-elf

2016-08-12 Thread Ngie Cooper
On Fri, Aug 12, 2016 at 11:36 AM, Konstantin Belousov wrote: ... > Because the API is unusable. It causes full queue iteration when the object > is NULL, i.e. at the end of the queue, instead of doing nothing. It would have been nice if this had been documented in the commit message instea

Re: svn commit: r304011 - head/libexec/rtld-elf

2016-08-12 Thread Ed Schouten
Hi Kostik, 2016-08-12 21:35 GMT+02:00 Konstantin Belousov : > What is improper about the tail-queue for global object list ? > Typical operations with it involve all objects in the list. The only > special ops I am aware are lookups by name or by dev_t/inode, but having > the parallel (two) maps

Re: svn commit: r304011 - head/libexec/rtld-elf

2016-08-12 Thread Konstantin Belousov
On Fri, Aug 12, 2016 at 09:32:37PM +0200, Ed Schouten wrote: > 2016-08-12 20:36 GMT+02:00 Konstantin Belousov : > > Because the API is unusable. It causes full queue iteration when the object > > is NULL, i.e. at the end of the queue, instead of doing nothing. > > Ah, thanks for working on this t

Re: svn commit: r304011 - head/libexec/rtld-elf

2016-08-12 Thread Ed Schouten
2016-08-12 20:36 GMT+02:00 Konstantin Belousov : > Because the API is unusable. It causes full queue iteration when the object > is NULL, i.e. at the end of the queue, instead of doing nothing. Ah, thanks for working on this then. I personally think that all of those macros in that run in linear

Re: svn commit: r304011 - head/libexec/rtld-elf

2016-08-12 Thread Konstantin Belousov
On Fri, Aug 12, 2016 at 11:34:42AM -0700, Ngie Cooper wrote: > > > On Aug 12, 2016, at 11:29, Konstantin Belousov wrote: > > > > Author: kib > > Date: Fri Aug 12 18:29:11 2016 > > New Revision: 304011 > > URL: https://svnweb.freebsd.org/changeset/base/304011 > > > > Log: > > Remove all remaini

Re: svn commit: r304011 - head/libexec/rtld-elf

2016-08-12 Thread Ngie Cooper
> On Aug 12, 2016, at 11:29, Konstantin Belousov wrote: > > Author: kib > Date: Fri Aug 12 18:29:11 2016 > New Revision: 304011 > URL: https://svnweb.freebsd.org/changeset/base/304011 > > Log: > Remove all remaining uses of TAILQ_FOREACH_FROM() from rtld-elf. Why? > Sponsored by:The Fre