Re: svn commit: r286700 - in head: sbin/ifconfig sys/net

2017-01-22 Thread Lakshmi Narasimhan Sundararajan
reebsd.org> > > Date: 2017-01-18, Wednesday at 14:38 > > To: Alan Somers , , > , > > Cc: "src-committ...@freebsd.org" , " > svn-src-all@freebsd.org" , " > svn-src-h...@freebsd.org" > > Subject: Re: svn commit: r286700 - in head: sbi

Re: svn commit: r286700 - in head: sbin/ifconfig sys/net

2017-01-20 Thread Ravi Pokala
-Original Message- > From: on behalf of Hiren Panchasara > > Date: 2017-01-18, Wednesday at 14:38 > To: Alan Somers , , > , > Cc: "src-committ...@freebsd.org" , > "svn-src-all@freebsd.org" , > "svn-src-h...@freebsd.org" >

Re: svn commit: r286700 - in head: sbin/ifconfig sys/net

2017-01-18 Thread Hiren Panchasara
Adding the submitter and other reviewers for their comments. On 01/18/17 at 03:03P, Alan Somers wrote: > Is the change to lacp_port_create correct? The comment indicates that > fast is configurable, but it's actually constant. Later on, there's > some dead code that depends on the value of fast

Re: svn commit: r286700 - in head: sbin/ifconfig sys/net

2017-01-18 Thread Alan Somers
Is the change to lacp_port_create correct? The comment indicates that fast is configurable, but it's actually constant. Later on, there's some dead code that depends on the value of fast (it was dead before this commit, too). CID: 1305734 CID: 1305692 -Alan On Wed, Aug 12, 2015 at 2:21 PM, Hir