Re: svn commit: r279236 - head/sys/netinet

2015-02-24 Thread Joerg Sonnenberger
On Tue, Feb 24, 2015 at 12:57:04PM +, Zbigniew Bodek wrote: > In fact, the assumption that 'struct ip' is always 4-byte aligned > is definitely false, as we have no impact on data alignment of packet > stream received. Pretty much all drivers do guarantee this by setting up buffers accor

Re: svn commit: r279236 - head/sys/netinet

2015-02-24 Thread Adrian Chadd
Hi, Erm, did you test this stuff on MIPS too? We should be smarter about accessing fields in the IP header, rather than trying to play alignment games like this. -adrian On 24 February 2015 at 04:57, Zbigniew Bodek wrote: > Author: zbb > Date: Tue Feb 24 12:57:03 2015 > New Revision: 279236

Re: svn commit: r279236 - head/sys/netinet

2015-02-24 Thread Joerg Sonnenberger
On Tue, Feb 24, 2015 at 11:59:02AM -0700, Ian Lepore wrote: > ETHER_ALIGN is wonderful... if you're on a platform that can DMA to an > arbitrary boundary. Isn't it generally more a case of "if the device's DMA engine isn't extremely bad designed"? There is a strong correlation between devices not

Re: svn commit: r279236 - head/sys/netinet

2015-02-24 Thread John-Mark Gurney
Ian Lepore wrote this message on Tue, Feb 24, 2015 at 11:59 -0700: > On Tue, 2015-02-24 at 09:34 -0800, John-Mark Gurney wrote: > > Zbigniew Bodek wrote this message on Tue, Feb 24, 2015 at 12:57 +: > > > Author: zbb > > > Date: Tue Feb 24 12:57:03 2015 > > > New Revision: 279236 > > > URL: htt

Re: svn commit: r279236 - head/sys/netinet

2015-02-24 Thread Ian Lepore
On Tue, 2015-02-24 at 09:34 -0800, John-Mark Gurney wrote: > Zbigniew Bodek wrote this message on Tue, Feb 24, 2015 at 12:57 +: > > Author: zbb > > Date: Tue Feb 24 12:57:03 2015 > > New Revision: 279236 > > URL: https://svnweb.freebsd.org/changeset/base/279236 > > > > Log: > > Change struct

Re: svn commit: r279236 - head/sys/netinet

2015-02-24 Thread John-Mark Gurney
Zbigniew Bodek wrote this message on Tue, Feb 24, 2015 at 12:57 +: > Author: zbb > Date: Tue Feb 24 12:57:03 2015 > New Revision: 279236 > URL: https://svnweb.freebsd.org/changeset/base/279236 > > Log: > Change struct attribute to avoid aligned operations mismatch > > Previous __alignme