On Wed, 20 Jun 2012, Xin Li wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 06/20/12 14:23, Colin Percival wrote:
On 06/20/12 14:15, Warner Losh wrote:
On Jun 20, 2012, at 10:36 AM, Colin Percival wrote:
On 06/20/12 09:27, Bruce Evans wrote:
On Wed, 20 Jun 2012, Eitan Adler wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 06/20/12 14:23, Colin Percival wrote:
> On 06/20/12 14:15, Warner Losh wrote:
>> On Jun 20, 2012, at 10:36 AM, Colin Percival wrote:
>>> On 06/20/12 09:27, Bruce Evans wrote:
On Wed, 20 Jun 2012, Eitan Adler wrote:
> Log: Don't close an u
On 06/20/12 14:15, Warner Losh wrote:
> On Jun 20, 2012, at 10:36 AM, Colin Percival wrote:
>> On 06/20/12 09:27, Bruce Evans wrote:
>>> On Wed, 20 Jun 2012, Eitan Adler wrote:
Log:
Don't close an uninitialized descriptor. [1]
Add a sanity check for the validity of the passed fd.
>>>
On Jun 20, 2012, at 10:36 AM, Colin Percival wrote:
> On 06/20/12 09:27, Bruce Evans wrote:
>> On Wed, 20 Jun 2012, Eitan Adler wrote:
>>> Log:
>>> Don't close an uninitialized descriptor. [1]
>>> Add a sanity check for the validity of the passed fd.
>>
>> Library functions shouldn't use assert(
On 06/20/12 09:27, Bruce Evans wrote:
> On Wed, 20 Jun 2012, Eitan Adler wrote:
>> Log:
>> Don't close an uninitialized descriptor. [1]
>> Add a sanity check for the validity of the passed fd.
>
> Library functions shouldn't use assert() or abort().
Why not?
> The fd is not passed, but is a st
On Wed, 20 Jun 2012, Eitan Adler wrote:
Log:
Don't close an uninitialized descriptor. [1]
Add a sanity check for the validity of the passed fd.
Library functions shouldn't use assert() or abort().
The fd is not passed, but is a static variable under syslog()'s control.
In libc, only the fo
