Re: svn commit: r232721 - head/sys/x86/include

2012-03-21 Thread Bruce Evans
On Wed, 21 Mar 2012, Tijl Coosemans wrote: On Tuesday 20 March 2012 19:56:14 John Baldwin wrote: On Tuesday, March 20, 2012 10:19:07 am Tijl Coosemans wrote: ... No, on i386 bswap64 with a variable argument currently expands to two bswap instructions. With your change it would be many shifts

Re: svn commit: r232721 - head/sys/x86/include

2012-03-21 Thread Tijl Coosemans
On Tuesday 20 March 2012 19:56:14 John Baldwin wrote: > On Tuesday, March 20, 2012 10:19:07 am Tijl Coosemans wrote: >> On Tuesday 20 March 2012 13:34:10 John Baldwin wrote: >>> BTW, I think I found an old "bug" in this file. The _gen() variants >>> should only use the _gen() variants of smaller t

Re: svn commit: r232721 - head/sys/x86/include

2012-03-20 Thread John Baldwin
On Tuesday, March 20, 2012 10:19:07 am Tijl Coosemans wrote: > On Tuesday 20 March 2012 13:34:10 John Baldwin wrote: > > On Friday, March 09, 2012 6:48:56 am Tijl Coosemans wrote: > >> Author: tijl > >> Date: Fri Mar 9 11:48:56 2012 > >> New Revision: 232721 > >> URL: http://svn.freebsd.org/change

Re: svn commit: r232721 - head/sys/x86/include

2012-03-20 Thread Tijl Coosemans
On Tuesday 20 March 2012 13:34:10 John Baldwin wrote: > On Friday, March 09, 2012 6:48:56 am Tijl Coosemans wrote: >> Author: tijl >> Date: Fri Mar 9 11:48:56 2012 >> New Revision: 232721 >> URL: http://svn.freebsd.org/changeset/base/232721 >> >> Log: >> Clean up x86 endian.h: >> - Remove ext

Re: svn commit: r232721 - head/sys/x86/include

2012-03-20 Thread John Baldwin
On Friday, March 09, 2012 6:48:56 am Tijl Coosemans wrote: > Author: tijl > Date: Fri Mar 9 11:48:56 2012 > New Revision: 232721 > URL: http://svn.freebsd.org/changeset/base/232721 > > Log: > Clean up x86 endian.h: > - Remove extern "C". There are no functions with external linkage here. [1]

Re: svn commit: r232721 - head/sys/x86/include

2012-03-09 Thread Tijl Coosemans
On Friday 09 March 2012 16:47:07 Ed Schouten wrote: > * Tijl Coosemans , 20120309 12:48: >> Clean up x86 endian.h: > > Wouldn't it be possible to simply place these macros in > and only let define the assembly versions for the > non-constant cases? Several things could be moved to sys, not ju

Re: svn commit: r232721 - head/sys/x86/include

2012-03-09 Thread Ed Schouten
Tijl, * Tijl Coosemans , 20120309 12:48: > Clean up x86 endian.h: Wouldn't it be possible to simply place these macros in and only let define the assembly versions for the non-constant cases? Thanks, -- Ed Schouten WWW: http://80386.nl/ pgpiKtoQM1sU6.pgp Description: PGP signature

Re: svn commit: r232721 - head/sys/x86/include

2012-03-09 Thread Dimitry Andric
On 2012-03-09 12:48, Tijl Coosemans wrote: > Author: tijl > Date: Fri Mar 9 11:48:56 2012 > New Revision: 232721 > URL: http://svn.freebsd.org/changeset/base/232721 > > Log: > Clean up x86 endian.h: > - Remove extern "C". There are no functions with external linkage here. [1] > - Rename bsw