Re: svn commit: r228514 - head/sys/net80211

2011-12-15 Thread Adrian Chadd
On 15 December 2011 02:15, Bernhard Schmidt wrote: >> So in short: if you're happy removing it, remove it. :) > > I agree on passing the frame as an argument to iac_check() and obtain > the mac from there, that definitely is required for more advanced > ACLs. Passing both tough, is imho not requi

Re: svn commit: r228514 - head/sys/net80211

2011-12-15 Thread Bernhard Schmidt
On Thu, Dec 15, 2011 at 10:35, Adrian Chadd wrote: > On 15 December 2011 00:02, Bernhard Schmidt wrote: > >> Why didn't you remove the mac argument? It is assign from wh->i_addr2 >> anyways, seems rather too redundant to me. > > Because the semantics for that right now are "check that MAC", so it

Re: svn commit: r228514 - head/sys/net80211

2011-12-15 Thread Adrian Chadd
On 15 December 2011 00:02, Bernhard Schmidt wrote: > Why didn't you remove the mac argument? It is assign from wh->i_addr2 > anyways, seems rather too redundant to me. Because the semantics for that right now are "check that MAC", so it's the callers responsibility to determine which MAC in the

Re: svn commit: r228514 - head/sys/net80211

2011-12-15 Thread Bernhard Schmidt
On Thu, Dec 15, 2011 at 01:52, Adrian Chadd wrote: > Author: adrian > Date: Thu Dec 15 00:52:30 2011 > New Revision: 228514 > URL: http://svn.freebsd.org/changeset/base/228514 > > Log: >  Modify the ACL code slightly to support a few nifty things: > >  * Call it before sending probe responses, so