Re: svn commit: r227873 - head/usr.bin/procstat

2011-11-26 Thread Bruce Evans
On Sat, 26 Nov 2011, Pawel Jakub Dawidek wrote: On Wed, Nov 23, 2011 at 11:10:47AM -0800, m...@freebsd.org wrote: I don't know if there's a style preference for 0x%lx versus %#lx, though, or a preference for a different type for the print (uintmax_t, for example). There is probably a preferenc

Re: svn commit: r227873 - head/usr.bin/procstat

2011-11-26 Thread Pawel Jakub Dawidek
On Wed, Nov 23, 2011 at 11:10:47AM -0800, m...@freebsd.org wrote: > I don't know if there's a style preference for 0x%lx versus %#lx, > though, or a preference for a different type for the print (uintmax_t, > for example). There is probably a preference for using u_long rather > than unsigned long

Re: svn commit: r227873 - head/usr.bin/procstat

2011-11-26 Thread Kostik Belousov
On Sat, Nov 26, 2011 at 06:13:14PM +, Robert N. M. Watson wrote: > > On 26 Nov 2011, at 17:48, Kostik Belousov wrote: > > >> in138:~% procstat -x 2008 > >> PID COMM AUXV VALUE > >> 2008 nginxAT_PHDR 0x400040 > >> 2008 nginxA

Re: svn commit: r227873 - head/usr.bin/procstat

2011-11-26 Thread Robert N. M. Watson
On 26 Nov 2011, at 17:48, Kostik Belousov wrote: >> in138:~% procstat -x 2008 >> PID COMM AUXV VALUE >> 2008 nginxAT_PHDR 0x400040 >> 2008 nginxAT_PHENT 56 >> 2008 nginxAT_PHNUM 8 >> 2008 nginx

Re: svn commit: r227873 - head/usr.bin/procstat

2011-11-26 Thread Kostik Belousov
On Sat, Nov 26, 2011 at 06:43:01PM +0200, Mikolaj Golub wrote: > > On Thu, 24 Nov 2011 09:12:35 +0200 Mikolaj Golub wrote: > > MG> On Wed, 23 Nov 2011 11:10:47 -0800 m...@freebsd.org wrote: > > >>>                        printf(" AT_IGNORE=0x%lu", > >>> -                           (unsigned l

Re: svn commit: r227873 - head/usr.bin/procstat

2011-11-26 Thread Mikolaj Golub
On Thu, 24 Nov 2011 09:12:35 +0200 Mikolaj Golub wrote: MG> On Wed, 23 Nov 2011 11:10:47 -0800 m...@freebsd.org wrote: >>>                        printf(" AT_IGNORE=0x%lu", >>> -                           (unsigned long)aux->a_un.a_val); >>> +                           (unsigned long)auxv[i]

Re: svn commit: r227873 - head/usr.bin/procstat

2011-11-23 Thread Mikolaj Golub
On Wed, 23 Nov 2011 11:10:47 -0800 m...@freebsd.org wrote: >>                        printf(" AT_IGNORE=0x%lu", >> -                           (unsigned long)aux->a_un.a_val); >> +                           (unsigned long)auxv[i].a_un.a_val); m> I didn't see this before, but this gives very

Re: svn commit: r227873 - head/usr.bin/procstat

2011-11-23 Thread mdf
On Tue, Nov 22, 2011 at 11:34 PM, Mikolaj Golub wrote: > Author: trociny > Date: Wed Nov 23 07:34:09 2011 > New Revision: 227873 > URL: http://svn.freebsd.org/changeset/base/227873 > > Log: >  Fix build, hopefully. > >  Reviewed by:  kib > > Modified: >  head/usr.bin/procstat/procstat_auxv.c > > M