Re: svn commit: r224721 - head/sys/sys

2011-08-15 Thread Alexander Best
On Mon Aug 15 11, Alexander Best wrote: > On Mon Aug 15 11, Bruce Evans wrote: > > On Wed, 10 Aug 2011, Alexander Best wrote: > > > > >On Wed Aug 10 11, Bruce Evans wrote: > > >>On Wed, 10 Aug 2011, Alexander Best wrote: > > >>>any reason {TIMEVAL,TIMESPEC}_TO_{TIMESPEC,TIMEVAL}()s code is being >

Re: svn commit: r224721 - head/sys/sys

2011-08-15 Thread Alexander Best
On Mon Aug 15 11, Bruce Evans wrote: > On Wed, 10 Aug 2011, Alexander Best wrote: > > >On Wed Aug 10 11, Bruce Evans wrote: > >>On Wed, 10 Aug 2011, Alexander Best wrote: > >>>any reason {TIMEVAL,TIMESPEC}_TO_{TIMESPEC,TIMEVAL}()s code is being > >>>executed > >>>in a > >>> > >>>do { ... } while (

Re: svn commit: r224721 - head/sys/sys

2011-08-14 Thread Bruce Evans
On Wed, 10 Aug 2011, Alexander Best wrote: On Wed Aug 10 11, Bruce Evans wrote: On Wed, 10 Aug 2011, Alexander Best wrote: any reason {TIMEVAL,TIMESPEC}_TO_{TIMESPEC,TIMEVAL}()s code is being executed in a do { ... } while (0) conditional loop? Just the usual syntactical trick for making l

Re: svn commit: r224721 - head/sys/sys

2011-08-10 Thread Alexander Best
On Wed Aug 10 11, Bruce Evans wrote: > On Wed, 10 Aug 2011, Alexander Best wrote: > > >On Tue Aug 9 11, Bruce Evans wrote: > >>... > >>What is wrong with the existing APIs TIMEVAL_TO_TIMESPEC() and > >>TIMESPEC_TO_TIMEVAL(), which are used for these conversions by almost > >>everything now? Well

Re: svn commit: r224721 - head/sys/sys

2011-08-10 Thread Bruce Evans
On Wed, 10 Aug 2011, Alexander Best wrote: On Tue Aug 9 11, Bruce Evans wrote: ... What is wrong with the existing APIs TIMEVAL_TO_TIMESPEC() and TIMESPEC_TO_TIMEVAL(), which are used for these conversions by almost everything now? Well, quite a bit is wrong with them, starting with ... any

Re: svn commit: r224721 - head/sys/sys

2011-08-10 Thread Dimitry Andric
On 2011-08-10 12:38, Alexander Best wrote: ... any reason {TIMEVAL,TIMESPEC}_TO_{TIMESPEC,TIMEVAL}()s code is being executed in a do { ... } while (0) conditional loop? both macros are also defined in crypto/openssh/defines.h and don't seem to need that extra one-time-loop. It's a very common

Re: svn commit: r224721 - head/sys/sys

2011-08-10 Thread Alexander Best
On Tue Aug 9 11, Bruce Evans wrote: > On Mon, 8 Aug 2011, Jonathan Anderson wrote: > > >Log: > > Create timeval2timespec() and timespec2timeval(). > > > > These functions will be used by process descriptors to convert process > > creation time into process descriptor [acm]time. > > These were in

Re: svn commit: r224721 - head/sys/sys

2011-08-08 Thread Bruce Evans
On Mon, 8 Aug 2011, Jonathan Anderson wrote: Log: Create timeval2timespec() and timespec2timeval(). These functions will be used by process descriptors to convert process creation time into process descriptor [acm]time. These were intentionally left out. What is wrong with the existing AP