Re: svn commit: r197608 - head/sys/geom/part

2009-10-01 Thread Marcel Moolenaar
On Oct 1, 2009, at 5:06 AM, Dmitry Marakasov wrote: * Marcel Moolenaar (xcl...@mac.com) wrote: Seconded. I've seen a report of geom_part_ebr unable to detect partitions which were actually there. Will inquiry the reporter if this change solved the problem. Seems like it hasn't. Here's the f

Re: svn commit: r197608 - head/sys/geom/part

2009-10-01 Thread Dmitry Marakasov
* Marcel Moolenaar (xcl...@mac.com) wrote: > >> Seconded. I've seen a report of geom_part_ebr unable to detect > >> partitions which were actually there. Will inquiry the reporter if > >> this change solved the problem. > > > > Seems like it hasn't. Here's the first sector from that partition: >

Re: svn commit: r197608 - head/sys/geom/part

2009-09-30 Thread Marcel Moolenaar
On Sep 29, 2009, at 4:51 PM, Dmitry Marakasov wrote: * Dmitry Marakasov (amd...@amdmi3.ru) wrote: Seconded. I've seen a report of geom_part_ebr unable to detect partitions which were actually there. Will inquiry the reporter if this change solved the problem. Seems like it hasn't. Here's th

Re: svn commit: r197608 - head/sys/geom/part

2009-09-29 Thread Dmitry Marakasov
* Dmitry Marakasov (amd...@amdmi3.ru) wrote: > Seconded. I've seen a report of geom_part_ebr unable to detect > partitions which were actually there. Will inquiry the reporter if > this change solved the problem. Seems like it hasn't. Here's the first sector from that partition: 000 48eb 009

Re: svn commit: r197608 - head/sys/geom/part

2009-09-29 Thread M. Warner Losh
In message: Marcel Moolenaar writes: : : On Sep 29, 2009, at 10:00 AM, Robert Watson wrote: : : > : > On Tue, 29 Sep 2009, Marcel Moolenaar wrote: : > : >>> Why do you check for zeros at all? AFAIK, the only real check is : >>> for AA55 at the end of the sector (and having an MBR

Re: svn commit: r197608 - head/sys/geom/part

2009-09-29 Thread M. Warner Losh
In message: Robert Watson writes: : : On Tue, 29 Sep 2009, Marcel Moolenaar wrote: : : >> Why do you check for zeros at all? AFAIK, the only real check is for AA55 : >> at the end of the sector (and having an MBR or other Extended MBR partition : >> entry point at the sector in

Re: svn commit: r197608 - head/sys/geom/part

2009-09-29 Thread John Baldwin
On Tuesday 29 September 2009 12:18:11 pm Marcel Moolenaar wrote: > > On Sep 29, 2009, at 4:49 AM, John Baldwin wrote: > > > On Monday 28 September 2009 7:52:47 pm Marcel Moolenaar wrote: > >> Author: marcel > >> Date: Mon Sep 28 23:52:47 2009 > >> New Revision: 197608 > >> URL: http://svn.freebsd

Re: svn commit: r197608 - head/sys/geom/part

2009-09-29 Thread Matthew Jacob
Marcel Moolenaar wrote: We really need to get to a point where we treat partition types seriously and use it to help avoid false positives. Reducing or eliminating false positives is critical if we ever want to go towards DWIM or auto-mounting. With the partition type taken into consideration

Re: svn commit: r197608 - head/sys/geom/part

2009-09-29 Thread Marcel Moolenaar
On Sep 29, 2009, at 10:00 AM, Robert Watson wrote: On Tue, 29 Sep 2009, Marcel Moolenaar wrote: Why do you check for zeros at all? AFAIK, the only real check is for AA55 at the end of the sector (and having an MBR or other Extended MBR partition entry point at the sector in question).

Re: svn commit: r197608 - head/sys/geom/part

2009-09-29 Thread Robert Watson
On Tue, 29 Sep 2009, Marcel Moolenaar wrote: Why do you check for zeros at all? AFAIK, the only real check is for AA55 at the end of the sector (and having an MBR or other Extended MBR partition entry point at the sector in question). The '96' thing seems rather arbitrary in the code, and I

Re: svn commit: r197608 - head/sys/geom/part

2009-09-29 Thread Marcel Moolenaar
On Sep 29, 2009, at 4:49 AM, John Baldwin wrote: On Monday 28 September 2009 7:52:47 pm Marcel Moolenaar wrote: Author: marcel Date: Mon Sep 28 23:52:47 2009 New Revision: 197608 URL: http://svn.freebsd.org/changeset/base/197608 Log: The first 96 bytes may not be zeroes. It can contain trivi

Re: svn commit: r197608 - head/sys/geom/part

2009-09-29 Thread Dmitry Marakasov
* John Baldwin (j...@freebsd.org) wrote: > Why do you check for zeros at all? AFAIK, the only real check is for AA55 at > the end of the sector (and having an MBR or other Extended MBR partition > entry point at the sector in question). The '96' thing seems rather > arbitrary in the code, and

Re: svn commit: r197608 - head/sys/geom/part

2009-09-29 Thread John Baldwin
On Monday 28 September 2009 7:52:47 pm Marcel Moolenaar wrote: > Author: marcel > Date: Mon Sep 28 23:52:47 2009 > New Revision: 197608 > URL: http://svn.freebsd.org/changeset/base/197608 > > Log: > The first 96 bytes may not be zeroes. It can contain trivial boot > code that merely emits an e