Re: svn commit: r192591 - head/sys/fs/nfsserver

2009-05-23 Thread Sam Leffler
Bruce Evans wrote: On Fri, 22 May 2009, Sam Leffler wrote: Alexey Dokuchaev wrote: On Fri, May 22, 2009 at 06:10:40PM +, Rick Macklem wrote: ... Log: Modified the printf message of r192590 to remove the possible DOS attack, as suggested by Sam. -printf("out of clientids, possibl

Re: svn commit: r192591 - head/sys/fs/nfsserver

2009-05-23 Thread Bruce Evans
On Sat, 23 May 2009, Bjoern A. Zeeb wrote: On Fri, 22 May 2009, Sam Leffler wrote: I requested the printf identify the call site; e.g. printf("%s: out of clientids\n", __func__); That is equally cryptic _with_ grepping through the source code, and much uglier. __func__ should only be used

Re: svn commit: r192591 - head/sys/fs/nfsserver

2009-05-23 Thread Bjoern A. Zeeb
On Fri, 22 May 2009, Sam Leffler wrote: I requested the printf identify the call site; e.g. printf("%s: out of clientids\n", __func__); That is equally cryptic _with_ grepping through the source code, and much uglier. __func__ should only be used when the function name is not a literal const

Re: svn commit: r192591 - head/sys/fs/nfsserver

2009-05-23 Thread Bruce Evans
On Fri, 22 May 2009, Sam Leffler wrote: Alexey Dokuchaev wrote: On Fri, May 22, 2009 at 06:10:40PM +, Rick Macklem wrote: ... Log: Modified the printf message of r192590 to remove the possible DOS attack, as suggested by Sam. - printf("out of clientids, possible DOS attack\n"); +

Re: svn commit: r192591 - head/sys/fs/nfsserver

2009-05-22 Thread Sam Leffler
Alexey Dokuchaev wrote: On Fri, May 22, 2009 at 06:10:40PM +, Rick Macklem wrote: Author: rmacklem Date: Fri May 22 18:10:39 2009 New Revision: 192591 URL: http://svn.freebsd.org/changeset/base/192591 Log: Modified the printf message of r192590 to remove the possible DOS attack, as s

Re: svn commit: r192591 - head/sys/fs/nfsserver

2009-05-22 Thread Alexey Dokuchaev
On Fri, May 22, 2009 at 06:10:40PM +, Rick Macklem wrote: > Author: rmacklem > Date: Fri May 22 18:10:39 2009 > New Revision: 192591 > URL: http://svn.freebsd.org/changeset/base/192591 > > Log: > Modified the printf message of r192590 to remove the > possible DOS attack, as suggested by Sa