On Thursday 15 January 2009 6:44:17 pm Max Laier wrote:
> Thank you for getting back to this ...
>
> On Thursday 15 January 2009 22:59:35 John Baldwin wrote:
> > So the usual model would be to do something like this:
> >
> > LIST(foo, ) foo_list;
> >
> > foo_add(foo *p)
> > {
> >
> > /* Co
Thank you for getting back to this ...
On Thursday 15 January 2009 22:59:35 John Baldwin wrote:
> So the usual model would be to do something like this:
>
> LIST(foo, ) foo_list;
>
> foo_add(foo *p)
> {
>
> /* Construct foo, but don't lock it. */
> WLOCK(foo_list);
> LIST_I
On Wednesday 17 December 2008 3:09:55 pm Max Laier wrote:
> As the upper half of this thread has turned into a style(9) bikeshed, let me
> replay the lower half and add more locking folks.
>
> The change in question is here:
> http://svn.freebsd.org/viewvc/base/head/sys/net/pfil.c?r1=173904&r2=1
As the upper half of this thread has turned into a style(9) bikeshed, let me
replay the lower half and add more locking folks.
The change in question is here:
http://svn.freebsd.org/viewvc/base/head/sys/net/pfil.c?r1=173904&r2=186187
On Tuesday 16 December 2008 19:20:40 Robert Watson wrote:
>
On Wed, 17 Dec 2008, Robert Watson wrote:
On Wed, 17 Dec 2008, Dag-Erling Sm??rgrav wrote:
Robert Watson writes:
exit(EX_OK);/*
* Avoid obvious comments such as
* "Exit 0 on success."
*
On Wed, 17 Dec 2008, Dag-Erling Smørgrav wrote:
Robert Watson writes:
I used to comment a bit more gratuitously along those lines, but bde
seems to have (at least partially) broken me of the habit. I felt
sure there was a note in style(9) on not commenting on obvious things,
but the closest I
Robert Watson writes:
> I used to comment a bit more gratuitously along those lines, but bde
> seems to have (at least partially) broken me of the habit. I felt
> sure there was a note in style(9) on not commenting on obvious things,
> but the closest I found was this:
>
> exit(EX_OK
On Tue, 16 Dec 2008, Julian Elischer wrote:
Generally I want more comments not less.. What is obvious to the writer may
not be obvious to the reader, or, the writer after 12 months. BDE, while
often correct goes to far sometimes.. :-)
This one seemed like an obvious one to trim, though:
Robert Watson wrote:
On Tue, 16 Dec 2008, Max Laier wrote:
Log:
A few locking fixes and cleanups to pfil hook registration,
unregistration, and execution:
- Add some brackets for clarity and trim a bit of vertical whitespace.
- Remove comments that may not contribute to clarity, such
On Tuesday 16 December 2008 19:20:40 Robert Watson wrote:
> On Tue, 16 Dec 2008, Max Laier wrote:
> >> Log:
> >> A few locking fixes and cleanups to pfil hook registration,
> >> unregistration, and execution:
> >>
> >> - Add some brackets for clarity and trim a bit of vertical whitespace.
> >
On Tue, 16 Dec 2008, Max Laier wrote:
Log:
A few locking fixes and cleanups to pfil hook registration,
unregistration, and execution:
- Add some brackets for clarity and trim a bit of vertical whitespace.
- Remove comments that may not contribute to clarity, such as "Lock"
before a
On Tuesday 16 December 2008 18:03:22 Robert Watson wrote:
> Author: rwatson
> Date: Tue Dec 16 17:03:22 2008
> New Revision: 186187
> URL: http://svn.freebsd.org/changeset/base/186187
>
> Log:
> A few locking fixes and cleanups to pfil hook registration,
> unregistration, and execution:
>
> -
12 matches
Mail list logo
