Re: svn commit: r184605 - head/sys/dev/usb

2008-11-04 Thread Carlos A. M. dos Santos
On Mon, Nov 3, 2008 at 8:54 PM, Joerg Sonnenberger <[EMAIL PROTECTED]> wrote: > On Mon, Nov 03, 2008 at 11:49:50PM +0100, Christoph Mallon wrote: >> You may want to make cmd[] static and/or const, so the compiler really >> just puts the bytes in the data section instead of generating code, >> which

Re: svn commit: r184605 - head/sys/dev/usb

2008-11-04 Thread Christoph Mallon
Joerg Sonnenberger wrote: On Mon, Nov 03, 2008 at 11:49:50PM +0100, Christoph Mallon wrote: You may want to make cmd[] static and/or const, so the compiler really just puts the bytes in the data section instead of generating code, which pretty much is the same as the assignments you just remo

Re: svn commit: r184605 - head/sys/dev/usb

2008-11-03 Thread Joerg Sonnenberger
On Mon, Nov 03, 2008 at 11:49:50PM +0100, Christoph Mallon wrote: > You may want to make cmd[] static and/or const, so the compiler really > just puts the bytes in the data section instead of generating code, > which pretty much is the same as the assignments you just removed. I didn't make it

Re: svn commit: r184605 - head/sys/dev/usb

2008-11-03 Thread Christoph Mallon
Hi Nick. Nick Hibma wrote: Author: n_hibma Date: Mon Nov 3 22:09:27 2008 New Revision: 184605 URL: http://svn.freebsd.org/changeset/base/184605 Log: Bugfix: Cut&paste error from the NetBSD code. Also: Change the initialisation of the command string to a static initialiser. Verify it