Re: Phabric IDs / URLs in commits

2014-07-18 Thread Ed Maste
On 11 July 2014 12:38, John Baldwin wrote: >> CR: https://phabric.freebsd.org/D312 >> Reviewed by:jilles >> MFC after: 1 week > > Just picking my own commit here as a sample case. > > I think we should be annotating commits with phabricator code reviews in some > way

Re: Phabric IDs / URLs in commits

2014-07-16 Thread John Baldwin
On Wednesday, July 16, 2014 09:27:57 AM Kubilay Kocak wrote: > On 16/07/2014 1:12 AM, John Baldwin wrote: > > On Friday, July 11, 2014 1:54:42 pm Baptiste Daroussin wrote: > >> On Fri, Jul 11, 2014 at 12:38:23PM -0400, John Baldwin wrote: > >>> On Friday, July 11, 2014 12:16:26 pm John Baldwin wrot

Re: Phabric IDs / URLs in commits

2014-07-16 Thread Baptiste Daroussin
On Wed, Jul 16, 2014 at 11:41:34AM -0400, John Baldwin wrote: > On Wednesday, July 16, 2014 09:27:57 AM Kubilay Kocak wrote: > > On 16/07/2014 1:12 AM, John Baldwin wrote: > > > On Friday, July 11, 2014 1:54:42 pm Baptiste Daroussin wrote: > > >> On Fri, Jul 11, 2014 at 12:38:23PM -0400, John Baldw

Re: Phabric IDs / URLs in commits

2014-07-15 Thread Kubilay Kocak
On 16/07/2014 1:12 AM, John Baldwin wrote: > On Friday, July 11, 2014 1:54:42 pm Baptiste Daroussin wrote: >> On Fri, Jul 11, 2014 at 12:38:23PM -0400, John Baldwin wrote: >>> On Friday, July 11, 2014 12:16:26 pm John Baldwin wrote: Author: jhb Date: Fri Jul 11 16:16:26 2014 New Revi

Re: Phabric IDs / URLs in commits

2014-07-15 Thread John Baldwin
On Friday, July 11, 2014 1:54:42 pm Baptiste Daroussin wrote: > On Fri, Jul 11, 2014 at 12:38:23PM -0400, John Baldwin wrote: > > On Friday, July 11, 2014 12:16:26 pm John Baldwin wrote: > > > Author: jhb > > > Date: Fri Jul 11 16:16:26 2014 > > > New Revision: 268531 > > > URL: http://svnweb.freeb

Re: Phabric IDs / URLs in commits

2014-07-11 Thread Florent Thoumie
On Fri, Jul 11, 2014 at 11:06 AM, Baptiste Daroussin wrote: > On Fri, Jul 11, 2014 at 10:51:32AM -0700, Florent Thoumie wrote: > > I don't know the ins and outs of arcanist but at Facebook we use 'arc > > amend' to update the local commit message with whatever is in > phabricator. > > This includ

Re: Phabric IDs / URLs in commits

2014-07-11 Thread John Baldwin
On Friday, July 11, 2014 1:54:42 pm Baptiste Daroussin wrote: > On Fri, Jul 11, 2014 at 12:38:23PM -0400, John Baldwin wrote: > > On Friday, July 11, 2014 12:16:26 pm John Baldwin wrote: > > > Author: jhb > > > Date: Fri Jul 11 16:16:26 2014 > > > New Revision: 268531 > > > URL: http://svnweb.freeb

Re: Phabric IDs / URLs in commits

2014-07-11 Thread Baptiste Daroussin
On Fri, Jul 11, 2014 at 10:51:32AM -0700, Florent Thoumie wrote: > I don't know the ins and outs of arcanist but at Facebook we use 'arc > amend' to update the local commit message with whatever is in phabricator. > This includes the name of the reviewer. That only works because you are using a dv

Re: Phabric IDs / URLs in commits

2014-07-11 Thread Baptiste Daroussin
On Fri, Jul 11, 2014 at 12:38:23PM -0400, John Baldwin wrote: > On Friday, July 11, 2014 12:16:26 pm John Baldwin wrote: > > Author: jhb > > Date: Fri Jul 11 16:16:26 2014 > > New Revision: 268531 > > URL: http://svnweb.freebsd.org/changeset/base/268531 > > > > Log: > > Fix some edge cases with

Re: Phabric IDs / URLs in commits

2014-07-11 Thread Florent Thoumie
I don't know the ins and outs of arcanist but at Facebook we use 'arc amend' to update the local commit message with whatever is in phabricator. This includes the name of the reviewer. Florent On Fri, Jul 11, 2014 at 9:38 AM, John Baldwin wrote: > On Friday, July 11, 2014 12:16:26 pm John Bald

Re: Phabric IDs / URLs in commits

2014-07-11 Thread Bryan Drewery
On 7/11/2014 11:47 AM, Bryan Drewery wrote: > On 7/11/2014 11:38 AM, John Baldwin wrote: >> On Friday, July 11, 2014 12:16:26 pm John Baldwin wrote: >>> Author: jhb >>> Date: Fri Jul 11 16:16:26 2014 >>> New Revision: 268531 >>> URL: http://svnweb.freebsd.org/changeset/base/268531 >>> >>> Log: >>>

Re: Phabric IDs / URLs in commits

2014-07-11 Thread Bryan Drewery
On 7/11/2014 11:38 AM, John Baldwin wrote: > On Friday, July 11, 2014 12:16:26 pm John Baldwin wrote: >> Author: jhb >> Date: Fri Jul 11 16:16:26 2014 >> New Revision: 268531 >> URL: http://svnweb.freebsd.org/changeset/base/268531 >> >> Log: >> Fix some edge cases with rewinddir(): >> - In the