> On Aug 1, 2015, at 4:50 AM, Ed Schouten wrote:
>
> Hi Luiz,
>
> 2015-07-31 23:43 GMT+02:00 Luiz Otavio O Souza :
>> - while (d->bd_hbuf_in_use)
>> - mtx_sleep(&d->bd_hbuf_in_use, &d->bd_lock,
>> - PRINET, "bd_hbuf", 0);
>
> Would
Author: ghelmer
Date: Mon May 5 16:52:38 2014
New Revision: 265368
URL: http://svnweb.freebsd.org/changeset/base/265368
Log:
MFC r264617:
Fix releasing the lock in the parent atrun process after the queue
directory has been processed. Otherwise, a long-running child process
caused othe
On Apr 17, 2014, at 11:00 AM, Guy Helmer wrote:
> Author: ghelmer
> Date: Thu Apr 17 16:00:26 2014
> New Revision: 264617
> URL: http://svnweb.freebsd.org/changeset/base/264617
>
> Log:
> Fix releasing the lock in the parent atrun process after the queue
> dire
Author: ghelmer
Date: Thu Apr 17 16:00:26 2014
New Revision: 264617
URL: http://svnweb.freebsd.org/changeset/base/264617
Log:
Fix releasing the lock in the parent atrun process after the queue
directory has been processed. Otherwise, a long-running child process
caused other atrun invocation
On Nov 27, 2013, at 12:34 AM, Peter Wemm wrote:
> On 11/26/13, 9:03 PM, Glen Barber wrote:
>> On Wed, Nov 27, 2013 at 04:54:24AM +, Peter Wemm wrote:
>>> Author: peter
>>> Date: Wed Nov 27 04:54:23 2013
>>> New Revision: 258672
>>> URL: http://svnweb.freebsd.org/changeset/base/258672
>>>
>>>
On Jul 31, 2013, at 1:09 PM, Adrian Chadd wrote:
> On 31 July 2013 07:07, Ian Lepore wrote:
>
>> I'm more concerned about the 201 files in the base that say I have to
>> give Mr. Paul credit in any product documentation and advertising
>> materials (the marketing department is going to love th
Author: ghelmer
Date: Fri Jun 14 18:56:37 2013
New Revision: 251756
URL: http://svnweb.freebsd.org/changeset/base/251756
Log:
MFC r244090, r250945
Changes to resolve races in bpfread() and catchpacket() that, at worst,
cause kernel panics.
Add a flag to the bpf descriptor to indica
Author: ghelmer
Date: Tue Jun 11 18:46:46 2013
New Revision: 251627
URL: http://svnweb.freebsd.org/changeset/base/251627
Log:
Add the name of the file that could not be opened to the error message
regarding the failure.
Suggested while working on PR bin/113239.
Modified:
head/libexec/a
Author: ghelmer
Date: Tue Jun 11 18:43:27 2013
New Revision: 251625
URL: http://svnweb.freebsd.org/changeset/base/251625
Log:
Prevent races running the queue by serializing access to the
queue directory.
PR: bin/113239
Modified:
head/libexec/atrun/atrun.c
Modified: head/libe
Author: ghelmer
Date: Thu May 23 21:33:10 2013
New Revision: 250945
URL: http://svnweb.freebsd.org/changeset/base/250945
Log:
While waiting for the bpf hold buffer to become idle, check
the return value from mtx_sleep() and exit bpfread() on
errors such as EINTR.
Reviewed by: jhb
Modi
Author: ghelmer
Date: Thu May 23 20:52:30 2013
New Revision: 250942
URL: http://svnweb.freebsd.org/changeset/base/250942
Log:
Add support for netgroup, based on patch in the PR but made consistent
with existing style.
PR: bin/132692
Modified:
head/usr.bin/getent/getent.c
Mod
Author: ghelmer
Date: Mon Dec 10 16:14:44 2012
New Revision: 244090
URL: http://svnweb.freebsd.org/changeset/base/244090
Log:
Changes to resolve races in bpfread() and catchpacket() that, at worst,
cause kernel panics.
Add a flag to the bpf descriptor to indicate whether the hold buffer
Author: ghelmer
Date: Tue Nov 6 21:07:04 2012
New Revision: 242673
URL: http://svnweb.freebsd.org/changeset/base/242673
Log:
Work around a race in bpfread() by validating the hold buffer pointer
before freeing it. Otherwise, we can lose a buffer and cause a panic
in catchpacket().
Modified
On Jun 15, 2012, at 4:26 PM, Konstantin Belousov wrote:
> On Thu, Jun 14, 2012 at 09:48:15PM +0000, Guy Helmer wrote:
>> Author: ghelmer
>> Date: Thu Jun 14 21:48:14 2012
>> New Revision: 237106
>> URL: http://svn.freebsd.org/changeset/base/237106
>>
>
Author: ghelmer
Date: Thu Jun 14 21:48:14 2012
New Revision: 237106
URL: http://svn.freebsd.org/changeset/base/237106
Log:
MFC 235739-235740,236402:
Apply style(9) to return and switch/case statements.
Add checks for memory allocation failures in appropriate places, and
avoid creating b
Author: ghelmer
Date: Fri Jun 1 15:02:23 2012
New Revision: 236402
URL: http://svn.freebsd.org/changeset/base/236402
Log:
Style(9) improvements: remove unnecessary parenthesis, improve order
of local variable declarations, remove bogus casts, and resolve long
lines.
Reviewed by: bde
On May 22, 2012, at 1:48 AM, Bruce Evans wrote:
> On Mon, 21 May 2012, Guy Helmer wrote:
>
>> Log:
>> Apply style(9) to return and switch/case statements.
>>
>> Reviewed by: delphij (prior version of the patch)
>>
>> Modified:
>> head/lib/libc/
Author: ghelmer
Date: Mon May 21 21:10:00 2012
New Revision: 235740
URL: http://svn.freebsd.org/changeset/base/235740
Log:
Add checks for memory allocation failures in appropriate places, and
avoid creating bad entries in the grp list as a result of memory allocation
failures while building
Author: ghelmer
Date: Mon May 21 21:04:29 2012
New Revision: 235739
URL: http://svn.freebsd.org/changeset/base/235739
Log:
Apply style(9) to return and switch/case statements.
Reviewed by: delphij (prior version of the patch)
Modified:
head/lib/libc/gen/getnetgrent.c
Modified: head/lib
Author: ghelmer
Date: Tue Apr 3 21:10:30 2012
New Revision: 233856
URL: http://svn.freebsd.org/changeset/base/233856
Log:
MFC: 229942, 231938
229942: Style fixes courtesy of pjd.
231938: Set the O_CLOEXEC flag when opening the pidfile to avoid leaking the
file descriptor via exec(3)
Author: ghelmer
Date: Tue Apr 3 20:49:26 2012
New Revision: 233855
URL: http://svn.freebsd.org/changeset/base/233855
Log:
MFC r229951,229985-229986,229988,230011,230037,230233,230599-230601
libutil.h and pidfile.c cleanup:
229951: Constify arguments (pjd)
229985: Fix forward structu
Author: ghelmer
Date: Tue Apr 3 15:42:08 2012
New Revision: 233837
URL: http://svn.freebsd.org/changeset/base/233837
Log:
MFC r229937:
Add pidfile_fileno() to obtain the file descriptor for an open
pidfile.
Modified:
stable/9/lib/libutil/libutil.h
stable/9/lib/libutil/pidfile.3
stabl
Author: ghelmer
Date: Mon Feb 20 13:59:24 2012
New Revision: 231938
URL: http://svn.freebsd.org/changeset/base/231938
Log:
Set the O_CLOEXEC flag when opening the pidfile to avoid leaking the
file descriptor via exec(3).
Now that daemon(8) has been fixed to resolve the issue noted by troc
On Feb 6, 2012, at 3:46 PM, Mikolaj Golub wrote:
>
> On Mon, 6 Feb 2012 09:27:06 +0100 Pawel Jakub Dawidek wrote:
>
> PJD> For the patch itself.
>
> PJD> You don't have to have two separate cases depending on request for
> PJD> pidfile. You can specify NULL pfh to the pidfile functions.
> PJD>
On Feb 5, 2012, at 3:39 AM, Pawel Jakub Dawidek wrote:
> On Sat, Feb 04, 2012 at 08:16:42PM +0200, Mikolaj Golub wrote:
>> ref8-amd64:/home/trociny% uname -r
>> 8.2-STABLE
>> ref8-amd64:/home/trociny% daemon -p /tmp/sleep.pid sleep 10
>> ref8-amd64:/home/trociny% daemon -p /tmp/sleep.pid sleep 10
Author: ghelmer
Date: Mon Feb 6 14:11:24 2012
New Revision: 231087
URL: http://svn.freebsd.org/changeset/base/231087
Log:
Using the O_CLOEXEC flag on open(2) caused the pidfile lock to be lost
when the child process execs daemon's target program thanks to flock(2)
semantics. So, we apparent
On Feb 4, 2012, at 2:23 AM, Andrey Zonov wrote:
> On 04.02.2012 11:42, Pawel Jakub Dawidek wrote:
>> On Wed, Feb 01, 2012 at 04:41:00PM +0000, Guy Helmer wrote:
>>> Author: ghelmer
>>> Date: Wed Feb 1 16:40:59 2012
>>> New Revision: 230869
>>> URL:
On Feb 4, 2012, at 1:42 AM, Pawel Jakub Dawidek wrote:
> On Wed, Feb 01, 2012 at 04:41:00PM +0000, Guy Helmer wrote:
>> Author: ghelmer
>> Date: Wed Feb 1 16:40:59 2012
>> New Revision: 230869
>> URL: http://svn.freebsd.org/changeset/base/230869
>>
>&
Author: ghelmer
Date: Wed Feb 1 16:40:59 2012
New Revision: 230869
URL: http://svn.freebsd.org/changeset/base/230869
Log:
Change the notes about the pidfile to include Doug's preference
for pre-creating the pidfile with appropriate owner and permissions.
Requested by dougb
Modified:
h
Author: ghelmer
Date: Thu Jan 26 20:40:22 2012
New Revision: 230601
URL: http://svn.freebsd.org/changeset/base/230601
Log:
Consensus between bde and pjd seemed to be that if the function names
are lined up, then any * after a long type should appear after the
type instead of being in front o
Author: ghelmer
Date: Thu Jan 26 20:35:01 2012
New Revision: 230600
URL: http://svn.freebsd.org/changeset/base/230600
Log:
Make the comments consistent (capitalization, punctuation, and
format).
Requested by bde
Modified:
head/lib/libutil/libutil.h
Modified: head/lib/libutil/libutil.h
Author: ghelmer
Date: Thu Jan 26 20:33:08 2012
New Revision: 230599
URL: http://svn.freebsd.org/changeset/base/230599
Log:
Restore the parenthesis that are necessary around the constant values.
Requested by bde.
Modified:
head/lib/libutil/libutil.h
Modified: head/lib/libutil/libutil.h
=
On Jan 26, 2012, at 4:51 AM, Doug Barton wrote:
> On 01/25/2012 06:50, Guy Helmer wrote:
>> Author: ghelmer
>> Date: Wed Jan 25 14:50:12 2012
>> New Revision: 230541
>> URL: http://svn.freebsd.org/changeset/base/230541
>>
>> Log:
>> Revert 229667: A
Author: ghelmer
Date: Wed Jan 25 14:50:12 2012
New Revision: 230541
URL: http://svn.freebsd.org/changeset/base/230541
Log:
Revert 229667: After some discussion of this change, it seems it is
better to leave the pidfile open where it was. Add a note to the
man page describing pidfile strategi
On Jan 6, 2012, at 6:16 PM, Doug Barton wrote:
> On 01/06/2012 08:18, Guy Helmer wrote:
>> On Jan 5, 2012, at 8:58 PM, Doug Barton wrote:
>>
>>> On 01/05/2012 14:48, Guy Helmer wrote:
>>>> Allow daemon(8) to run pidfile_open() before relenquishing
>>&g
On Jan 17, 2012, at 3:58 AM, Bruce Evans wrote:
> On Mon, 16 Jan 2012, Pawel Jakub Dawidek wrote:
>
>> On Mon, Jan 16, 2012 at 11:14:32AM -0600, Guy Helmer wrote:
>>> I've pasted the diff below that I think captures the majority of the issues
>>> you have
Author: ghelmer
Date: Mon Jan 16 21:25:41 2012
New Revision: 230234
URL: http://svn.freebsd.org/changeset/base/230234
Log:
Remove unnecessary includes from these libutil man pages.
Requested by bde (as was the previous commit).
Modified:
head/lib/libutil/pidfile.3
head/lib/libutil/prop
Author: ghelmer
Date: Mon Jan 16 21:19:23 2012
New Revision: 230233
URL: http://svn.freebsd.org/changeset/base/230233
Log:
Fix more disorder in prototypes and constants.
Fix header comments for each section of constants.
Fix whitespace in #define lines.
Fix unnecessary parenthesis in const
On Jan 14, 2012, at 3:02 PM, Bruce Evans wrote:
> On Sat, 14 Jan 2012, Pawel Jakub Dawidek wrote:
>
>> On Sat, Jan 14, 2012 at 09:59:27PM +1100, Bruce Evans wrote:
>>> ...
>>> It's good to declare mode_t, since pidfile_open() uses it and we want
>>> to remove the dependency on . However, this de
Author: ghelmer
Date: Thu Jan 12 22:49:36 2012
New Revision: 230037
URL: http://svn.freebsd.org/changeset/base/230037
Log:
Move struct pidfh definition into pidfile.c, and leave a forward declaration
for pidfh in libutil.h in its place.
This allows us to hide the contents of the pidfh struct
Author: ghelmer
Date: Thu Jan 12 15:45:08 2012
New Revision: 230016
URL: http://svn.freebsd.org/changeset/base/230016
Log:
Fix disorder in MAN and MLINKS lists.
Requested by bde.
Modified:
head/lib/libutil/Makefile
Modified: head/lib/libutil/Makefile
Author: ghelmer
Date: Thu Jan 12 14:40:25 2012
New Revision: 230011
URL: http://svn.freebsd.org/changeset/base/230011
Log:
More prototype formatting fixes, struct member formatting fixes,
and namespace fix for property_find() prototype.
Provided by bde.
Modified:
head/lib/libutil/libut
Author: ghelmer
Date: Thu Jan 12 14:13:49 2012
New Revision: 230010
URL: http://svn.freebsd.org/changeset/base/230010
Log:
pidfile_open() no longer uses fcntl() to set the close-on-exec flag.
Modified:
head/lib/libutil/pidfile.3
Modified: head/lib/libutil/pidfile.3
==
Author: ghelmer
Date: Wed Jan 11 22:45:15 2012
New Revision: 229988
URL: http://svn.freebsd.org/changeset/base/229988
Log:
Fix prototype formatting (indentation, long lines, and continued lines).
Requested by bde.
Modified:
head/lib/libutil/libutil.h
Modified: head/lib/libutil/libutil.h
Author: ghelmer
Date: Wed Jan 11 22:33:41 2012
New Revision: 229986
URL: http://svn.freebsd.org/changeset/base/229986
Log:
Fix namespace issues with prototype parameter names.
Add missing prototype parameter names.
Requested by bde.
Modified:
head/lib/libutil/libutil.h
Modified: head/
Author: ghelmer
Date: Wed Jan 11 22:12:45 2012
New Revision: 229985
URL: http://svn.freebsd.org/changeset/base/229985
Log:
Fix forward structure declaration and prototype disorder.
Requested by bde.
Modified:
head/lib/libutil/libutil.h
Modified: head/lib/libutil/libutil.h
==
On Jan 10, 2012, at 5:06 PM, Jilles Tjoelker wrote:
> On Tue, Jan 10, 2012 at 06:43:27PM +0000, Guy Helmer wrote:
>> Author: ghelmer
>> Date: Tue Jan 10 18:43:27 2012
>> New Revision: 229936
>> URL: http://svn.freebsd.org/changeset/base/229936
>
>> Log:
>
Author: ghelmer
Date: Wed Jan 11 16:35:26 2012
New Revision: 229966
URL: http://svn.freebsd.org/changeset/base/229966
Log:
jilles pointed out that O_CLOEXEC could be used in the open(2) flags
rather than using fcntl(2) later, and in addition to saving a system
call, removes a possible race w
On Jan 11, 2012, at 6:25 AM, Bruce Evans wrote:
> On Tue, 10 Jan 2012, Pawel Jakub Dawidek wrote:
>
>> On Tue, Jan 10, 2012 at 07:53:25PM +, Guy Helmer wrote:
>> [...]
>>> Modified:
Author: ghelmer
Date: Tue Jan 10 22:22:35 2012
New Revision: 229943
URL: http://svn.freebsd.org/changeset/base/229943
Log:
Add link for pidfile_fileno.3 to pidfile.3 - thanks again pjd!
Modified:
head/lib/libutil/Makefile
Modified: head/lib/libutil/Makefile
==
On Jan 10, 2012, at 3:42 PM, Pawel Jakub Dawidek wrote:
> On Tue, Jan 10, 2012 at 07:53:25PM +0000, Guy Helmer wrote:
>> Author: ghelmer
>> Date: Tue Jan 10 19:53:25 2012
>> New Revision: 229937
>> URL: http://svn.freebsd.org/changeset/base/229937
>>
>>
Author: ghelmer
Date: Tue Jan 10 21:47:58 2012
New Revision: 229942
URL: http://svn.freebsd.org/changeset/base/229942
Log:
Style fixes courtesy of pjd.
Modified:
head/lib/libutil/pidfile.3
head/lib/libutil/pidfile.c
Modified: head/lib/libutil/pidfile.3
=
On Jan 10, 2012, at 3:27 PM, Pawel Jakub Dawidek wrote:
> On Tue, Jan 10, 2012 at 10:25:26PM +0100, Pawel Jakub Dawidek wrote:
>> On Tue, Jan 10, 2012 at 06:43:27PM +0000, Guy Helmer wrote:
>>> Author: ghelmer
>>> Date: Tue Jan 10 18:43:27 2012
>>>
Author: ghelmer
Date: Tue Jan 10 21:39:43 2012
New Revision: 229941
URL: http://svn.freebsd.org/changeset/base/229941
Log:
Document that pidfile_open() now sets the FD_CLOEXEC flag on the open
file descriptor, and that errors can be returned as a result of the
fcntl(2) system call.
Modified
On Jan 6, 2012, at 12:00 AM, Garrett Cooper wrote:
> On Thu, Jan 5, 2012 at 6:58 PM, Doug Barton wrote:
>> On 01/05/2012 14:48, Guy Helmer wrote:
>>> Allow daemon(8) to run pidfile_open() before relenquishing privileges
>>> so pid files can be written in /v
Author: ghelmer
Date: Tue Jan 10 19:54:53 2012
New Revision: 229938
URL: http://svn.freebsd.org/changeset/base/229938
Log:
Revert unintentional commit of changes to getnetgrent.c.
Modified:
head/lib/libc/gen/getnetgrent.c
Modified: head/lib/libc/gen/getnetgrent.c
Author: ghelmer
Date: Tue Jan 10 19:53:25 2012
New Revision: 229937
URL: http://svn.freebsd.org/changeset/base/229937
Log:
Add pidfile_fileno() to obtain the file descriptor for an open
pidfile.
Modified:
head/lib/libc/gen/getnetgrent.c
head/lib/libutil/libutil.h
head/lib/libutil/pidfil
Author: ghelmer
Date: Tue Jan 10 18:43:27 2012
New Revision: 229936
URL: http://svn.freebsd.org/changeset/base/229936
Log:
Set the FD_CLOEXEC flag on the open pidfile file descriptor.
Discussed with: pjd, des
Modified:
head/lib/libutil/pidfile.c
Modified: head/lib/libutil/pidfile.c
Author: ghelmer
Date: Fri Jan 6 21:28:29 2012
New Revision: 229735
URL: http://svn.freebsd.org/changeset/base/229735
Log:
Handle memory allocation failures in devstat_getdevs(), devstat_selectdevs(),
and devstat_buildmatch().
PR: bin/83359
Reviewed by: ken
Modified:
head/
On Jan 5, 2012, at 8:58 PM, Doug Barton wrote:
> On 01/05/2012 14:48, Guy Helmer wrote:
>> Allow daemon(8) to run pidfile_open() before relenquishing privileges
>> so pid files can be written in /var/run when started as root.
>
> I'm not sure how useful this is since
Author: ghelmer
Date: Thu Jan 5 23:08:11 2012
New Revision: 229668
URL: http://svn.freebsd.org/changeset/base/229668
Log:
Fix a memory leak in addgroup() by ensuring the allocated memory
is freed if an error occurs.
PR: bin/161510
MFC after:4 weeks
Modified:
head/usr.b
Author: ghelmer
Date: Thu Jan 5 22:48:36 2012
New Revision: 229667
URL: http://svn.freebsd.org/changeset/base/229667
Log:
Allow daemon(8) to run pidfile_open() before relenquishing privileges
so pid files can be written in /var/run when started as root.
I do not expect this to cause any
Author: ghelmer
Date: Fri Dec 23 02:13:42 2011
New Revision: 228828
URL: http://svn.freebsd.org/changeset/base/228828
Log:
Handle malloc failures in yplib.c.
PR: bin/83349
Modified:
head/lib/libc/yp/yplib.c
Modified: head/lib/libc/yp/yplib.c
===
Author: ghelmer
Date: Fri Dec 23 01:56:25 2011
New Revision: 228826
URL: http://svn.freebsd.org/changeset/base/228826
Log:
Handle failures to malloc memory to hold key or val copies.
PR: bin/83348
Modified:
head/lib/libc/yp/xdryp.c
Modified: head/lib/libc/yp/xdryp.c
==
>
> Flow control was something my validation group specifically ragged on me
> about... and was the reason I changed to a per-adapter setting.
>
> Let me think about it.
>
> Jack
>
>
> On Tue, Jun 21, 2011 at 9:17 AM, Guy Helmer
> wrote:
> On Jun 21, 2011, a
On Jun 21, 2011, at 11:07 AM, Jack Vogel wrote:
> LOL, the old adage is true, you just can't please all the people... :)
>
> The way the code now is it assigns a default, but you could still have
> a loader entry that would change it for all adapters if you wanted to,
> but ok, if you prefer the
On Jun 21, 2011, at 8:07 AM, John Baldwin wrote:
> On Monday, June 20, 2011 6:59:29 pm Jack F Vogel wrote:
>> Author: jfv
>> Date: Mon Jun 20 22:59:29 2011
>> New Revision: 223350
>> URL: http://svn.freebsd.org/changeset/base/223350
>>
>> Log:
>> Eliminate some global tuneables in favor of adap
67 matches
Mail list logo
