On 5 Aug, Mateusz Guzik wrote:
> Author: mjg
> Date: Wed Aug 5 09:24:38 2020
> New Revision: 363891
> URL: https://svnweb.freebsd.org/changeset/base/363891
>
> Log:
> cache: reduce zone alignment to 8 bytes
>
> It used to be sizeof of the given struct to accomodate for 32 bit mips
> doi
Author: truckman
Date: Wed Jul 29 04:36:45 2020
New Revision: 363658
URL: https://svnweb.freebsd.org/changeset/base/363658
Log:
Make lex a bootstrap tool when cross-building on recent 13-CURRENT if
binutils/ld is going to be built. The latter is no longer true by default.
The import of f
Author: truckman
Date: Tue Jul 28 19:35:24 2020
New Revision: 363653
URL: https://svnweb.freebsd.org/changeset/base/363653
Log:
Make lex a bootstrap tool when cross-building on recent 13-CURRENT.
The import of flex 2.6.4 into -CURRENT changed the type of yy_n_chars
in the lex skeleton fro
Author: truckman
Date: Sat Jul 25 23:08:51 2020
New Revision: 363536
URL: https://svnweb.freebsd.org/changeset/base/363536
Log:
MFC r362569 (by jkim):
Fix build with recent byacc.
S3curity:
Modified:
stable/11/libexec/ftpd/ftpcmd.y
stable/11/usr.bin/localedef/localedef.c
sta
Author: truckman
Date: Sat Jul 25 23:06:47 2020
New Revision: 363535
URL: https://svnweb.freebsd.org/changeset/base/363535
Log:
MFC r362569 (by jkim):
Fix build with recent byacc.
Modified:
stable/12/libexec/ftpd/ftpcmd.y
stable/12/usr.bin/localedef/localedef.c
stable/12/usr.bin/
On 2 Feb, Warner Losh wrote:
> Author: imp
> Date: Sun Feb 2 11:37:27 2020
> New Revision: 357407
> URL: https://svnweb.freebsd.org/changeset/base/357407
>
> Log:
> Per the firm plan, start to remove sparc64
>
> The sparc64 architecture is being removed from FreeBSD 13, starting
> now.
Author: truckman
Date: Sun Jan 26 01:45:22 2020
New Revision: 357133
URL: https://svnweb.freebsd.org/changeset/base/357133
Log:
MFC r33
Fix a logic bug in error handling code. It is an error if p == NULL.
The linelen tests are only meaningful when p != NULL.
Reported by: Coveri
Author: truckman
Date: Sun Jan 26 01:42:47 2020
New Revision: 357132
URL: https://svnweb.freebsd.org/changeset/base/357132
Log:
MFC r33
Fix a logic bug in error handling code. It is an error if p == NULL.
The linelen tests are only meaningful when p != NULL.
Reported by: Coveri
Author: truckman
Date: Mon Dec 9 07:18:40 2019
New Revision: 33
URL: https://svnweb.freebsd.org/changeset/base/33
Log:
Fix a logic bug in error handling code. It is an error if p == NULL.
The linelen tests are only meaningful when p != NULL.
Reported by: Coverity
Coverity CID
On 21 Jun, Xin LI wrote:
> But ultimately, I think the real design question here that needs to be
> solved would probably be "Why are piling up multiple layers of workarounds
> around motd? Does it even need to be located in /etc?" The contents is
> meant to be updated every time when there is a
On 10 Oct, John Baldwin wrote:
> Author: jhb
> Date: Wed Oct 10 21:28:04 2018
> New Revision: 339293
> URL: https://svnweb.freebsd.org/changeset/base/339293
>
> Log:
> Disable the KASSERT for curcpu == 0 in netisr for EARLY_AP_STARTUP.
>
> In the EARLY_AP_STARTUP case, thread0 can migrate t
Author: truckman
Date: Sun Aug 12 03:22:28 2018
New Revision: 337678
URL: https://svnweb.freebsd.org/changeset/base/337678
Log:
MFC r336855
Fix the long term ULE load balancer so that it actually works. The
initial call to sched_balance() during startup is meant to initialize
balance_t
On 29 Jul, Ian Lepore wrote:
> On Sun, 2018-07-29 at 09:59 -0700, Don Lewis wrote:
>> On 29 Jul, Ian Lepore wrote:
>> > On Sun, 2018-07-29 at 05:42 +, Don Lewis wrote:
>> >> Author: truckman
>> >> Date: Sun Jul 29 05:42:07 2018
>> >> New
On 29 Jul, Ian Lepore wrote:
> On Sun, 2018-07-29 at 05:42 +0000, Don Lewis wrote:
>> Author: truckman
>> Date: Sun Jul 29 05:42:07 2018
>> New Revision: 336859
>> URL: https://svnweb.freebsd.org/changeset/base/336859
>>
>> Log:
>> Fix a variable
Author: truckman
Date: Sun Jul 29 05:42:07 2018
New Revision: 336859
URL: https://svnweb.freebsd.org/changeset/base/336859
Log:
Fix a variable name typo in r336845 that prevented the rc.d scripts
from being installed in the correct directory.
Resurrect a few rc.d scripts that were prematu
Author: truckman
Date: Sun Jul 29 00:30:06 2018
New Revision: 336855
URL: https://svnweb.freebsd.org/changeset/base/336855
Log:
Fix the long term ULE load balancer so that it actually works. The
initial call to sched_balance() during startup is meant to initialize
balance_ticks, but does no
On 7 Jul, Alexey Dokuchaev wrote:
> On Fri, Jul 06, 2018 at 05:06:03PM -0700, Don Lewis wrote:
>> The other machine is my Pentium-M laptop, which is mostly used for light
>> browsing and as a VNC client when I'm on the road. Performance is
>> acceptable for thos
On 6 Jul, Warner Losh wrote:
> On Fri, Jul 6, 2018 at 6:06 PM, Don Lewis wrote:
>
>> On 6 Jul, Warner Losh wrote:
>> > On Fri, Jul 6, 2018 at 9:32 AM, Rodney W. Grimes <
>> > free...@pdx.rh.cn85.dnsmgr.net> wrote:
>> >
>> >> > Author:
On 6 Jul, Warner Losh wrote:
> On Fri, Jul 6, 2018 at 9:32 AM, Rodney W. Grimes <
> free...@pdx.rh.cn85.dnsmgr.net> wrote:
>
>> > Author: hselasky
>> > Date: Fri Jul 6 10:13:42 2018
>> > New Revision: 336025
>> > URL: https://svnweb.freebsd.org/changeset/base/336025
>> >
>> > Log:
>> > Make su
On 2 Jun, Rodney W. Grimes wrote:
>> Author: eadler
>> Date: Sat Jun 2 22:06:27 2018
>> New Revision: 334543
>> URL: https://svnweb.freebsd.org/changeset/base/334543
>>
>> Log:
>> top(1): chdir to / as init; remove unneeded comment
>>
>> - chdir to / to allow unmounting of wd
>> - remov
Author: truckman
Date: Mon Mar 26 04:41:23 2018
New Revision: 331541
URL: https://svnweb.freebsd.org/changeset/base/331541
Log:
MFC r329844
MFC r329875 (by kib)
r329844 | truckman | 2018-02-22 16:12:51 -0800 (Thu, 22 Feb 2018) | 52 lines
Decrease latency by not wrapping the idle loop
On 23 Feb, Rick Macklem wrote:
> Konstantin Belousov wrote:
>>Author: kib
>>Date: Fri Feb 23 18:26:31 2018
>>New Revision: 329875
>>URL: https://svnweb.freebsd.org/changeset/base/329875
>>
>>Log:
>> Restore UP build.
>>
>> Reviewed by: truckman
>> Sponsored by: The FreeBSD Foundation
>>
>>Modif
Author: truckman
Date: Fri Feb 23 00:12:51 2018
New Revision: 329844
URL: https://svnweb.freebsd.org/changeset/base/329844
Log:
Decrease latency by not wrapping the idle loop's potentially lengthy
search for a thread to steal inside a critical section. Since this
allows the search to be pre
Author: truckman
Date: Thu Feb 22 00:36:12 2018
New Revision: 329767
URL: https://svnweb.freebsd.org/changeset/base/329767
Log:
MFC r323067, r323184, r323185, r323195, r323196 (by cem)
r323067 | cem | 2017-08-31 11:3
On 19 Jan, Conrad Meyer wrote:
> On Fri, Jan 19, 2018 at 9:37 AM, Rodney W. Grimes
> wrote:
>> If you think in assembler it is easy to understand why this is UB,
>> most (all) architectures Right Logic or Arithmetic Shift only accept an
>> operand that is a size that can hold log2(wordsize).
>
>
On 19 Jan, David Chisnall wrote:
> On 19 Jan 2018, at 05:07, Conrad Meyer wrote:
>>
>> The spec says the behavior is undefined; not that the compiler has to
>> produce a warning or error message. The compiler *does* get to
>> arbitrarily decide what it wants to do when it encounters UB. It is
>
On 12 Dec, Eugene Grosbein wrote:
> Now I run FreeBSD 11/i386 as my home router with IPSEC and torrent
> client, and I run several virtualized routers with IPSEC tunnels,
> jabber and mail server, squid and ZFS for src/obj/ports compression
> and they all easily crash unless kern.kstack_pages rais
On 29 Nov, Cy Schubert wrote:
> In message <201711292328.vatnseom046...@repo.freebsd.org>, Hans Petter
> Selasky
> writes:
>> Author: hselasky
>> Date: Wed Nov 29 23:28:40 2017
>> New Revision: 326376
>> URL: https://svnweb.freebsd.org/changeset/base/326376
>>
>> Log:
>> The sched_add() function
Author: truckman
Date: Sun Nov 12 01:28:20 2017
New Revision: 325731
URL: https://svnweb.freebsd.org/changeset/base/325731
Log:
MFC r325008
Fix Dummynet AQM packet marking function ecn_mark() and fq_codel /
fq_pie schedulers packet classification functions in layer2 (bridge mode).
Du
Author: truckman
Date: Sun Nov 12 01:26:43 2017
New Revision: 325730
URL: https://svnweb.freebsd.org/changeset/base/325730
Log:
MFC r325008
Fix Dummynet AQM packet marking function ecn_mark() and fq_codel /
fq_pie schedulers packet classification functions in layer2 (bridge mode).
Du
On 4 Nov, Bryan Drewery wrote:
> On 11/4/2017 3:30 PM, Cy Schubert wrote:
>> In message <0fc7e918-dcf8-0197-6b50-5936dee23...@freebsd.org>, Bryan
>> Drewery wr
>> ites:
>>> This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
>>> --dokLDw6wDnv1gUfKm3uwMSMnWeibN2RaD
>>> Content-Type: multipa
Author: truckman
Date: Thu Oct 26 10:11:35 2017
New Revision: 325008
URL: https://svnweb.freebsd.org/changeset/base/325008
Log:
Fix Dummynet AQM packet marking function ecn_mark() and fq_codel /
fq_pie schedulers packet classification functions in layer2 (bridge mode).
Dummynet AQM packet
On 8 Oct, Konstantin Belousov wrote:
> On Sat, Oct 07, 2017 at 01:54:05PM -0700, Don Lewis wrote:
>> On 7 Oct, Konstantin Belousov wrote:
>> > On Sat, Oct 07, 2017 at 01:04:09PM -0700, Don Lewis wrote:
>> >> On 5 Oct, Konstantin Belousov wrote:
>> >> &g
On 7 Oct, Konstantin Belousov wrote:
> On Sat, Oct 07, 2017 at 01:04:09PM -0700, Don Lewis wrote:
>> On 5 Oct, Konstantin Belousov wrote:
>> > Author: kib
>> > Date: Thu Oct 5 12:50:03 2017
>> > New Revision: 324313
>> > URL: https://svnweb.fre
On 5 Oct, Konstantin Belousov wrote:
> Author: kib
> Date: Thu Oct 5 12:50:03 2017
> New Revision: 324313
> URL: https://svnweb.freebsd.org/changeset/base/324313
>
> Log:
> Avoid a race betweem freeing LDT and context switches.
>
> cpu_switch.S uses curproc->p_md.md_ldt value as the flag
Author: truckman
Date: Wed Aug 16 07:59:57 2017
New Revision: 322569
URL: https://svnweb.freebsd.org/changeset/base/322569
Log:
MFC r321899
Lower the amd64 shared page, which contains the signal trampoline,
from the top of user memory to one page lower on machines with the
Ryzen (AMD Fa
Author: truckman
Date: Wed Aug 2 01:43:35 2017
New Revision: 321899
URL: https://svnweb.freebsd.org/changeset/base/321899
Log:
Lower the amd64 shared page, which contains the signal trampoline,
from the top of user memory to one page lower on machines with the
Ryzen (AMD Family 17h) CPU. T
On 3 Jun, Rodney W. Grimes wrote:
> As far as fixing the builds for optional stuff that is rather
> easily done in the Makefile with some if's to build a list of
> files that can then be catted to conf.foo, using m4 or even
> cpp to pre process conf.foo.src, etc, several very easy ways
> to solv
Author: truckman
Date: Thu May 25 22:41:34 2017
New Revision: 318905
URL: https://svnweb.freebsd.org/changeset/base/318905
Log:
MFC r318527
Fix the queue delay estimation in PIE/FQ-PIE when the timestamp
(TS) method is used. When packet timestamp is used, the "current_qdelay"
keeps sto
Author: truckman
Date: Thu May 25 22:39:48 2017
New Revision: 318904
URL: https://svnweb.freebsd.org/changeset/base/318904
Log:
MFC r318527
Fix the queue delay estimation in PIE/FQ-PIE when the timestamp
(TS) method is used. When packet timestamp is used, the "current_qdelay"
keeps sto
Author: truckman
Date: Thu May 25 17:23:26 2017
New Revision: 318886
URL: https://svnweb.freebsd.org/changeset/base/318886
Log:
MFC r318511
The result of right shifting a negative signed value is implementation
defined. On machines without arithmetic shift instructions, zero bits
may b
Author: truckman
Date: Thu May 25 17:22:13 2017
New Revision: 318885
URL: https://svnweb.freebsd.org/changeset/base/318885
Log:
MFC r318511
The result of right shifting a negative signed value is implementation
defined. On machines without arithmetic shift instructions, zero bits
may b
Author: truckman
Date: Fri May 19 08:38:03 2017
New Revision: 318527
URL: https://svnweb.freebsd.org/changeset/base/318527
Log:
Fix the queue delay estimation in PIE/FQ-PIE when the timestamp
(TS) method is used. When packet timestamp is used, the "current_qdelay"
keeps storing the last que
Author: truckman
Date: Fri May 19 01:23:06 2017
New Revision: 318511
URL: https://svnweb.freebsd.org/changeset/base/318511
Log:
The result of right shifting a negative signed value is implementation
defined. On machines without arithmetic shift instructions, zero bits
may be shifted in from
Author: truckman
Date: Thu Apr 27 07:32:07 2017
New Revision: 317489
URL: https://svnweb.freebsd.org/changeset/base/317489
Log:
MFC r316777 (by cem)
dummynet: Use strlcpy to appease static checkers
Some dummynet modules used strcpy() to copy from a larger buffer
(dn_aqm->name) to a s
Author: truckman
Date: Thu Apr 27 07:30:48 2017
New Revision: 317488
URL: https://svnweb.freebsd.org/changeset/base/317488
Log:
MFC r316777 (by cem)
dummynet: Use strlcpy to appease static checkers
Some dummynet modules used strcpy() to copy from a larger buffer
(dn_aqm->name) to a s
Author: truckman
Date: Fri Mar 31 06:33:20 2017
New Revision: 316325
URL: https://svnweb.freebsd.org/changeset/base/316325
Log:
MFC r315516
Change several constants used by the PIE algorithm from unsigned to signed.
- PIE_MAX_PROB is compared to variable of int64_t and the type promot
Author: truckman
Date: Fri Mar 31 06:20:06 2017
New Revision: 316324
URL: https://svnweb.freebsd.org/changeset/base/316324
Log:
MFC r315516
Change several constants used by the PIE algorithm from unsigned to signed.
- PIE_MAX_PROB is compared to variable of int64_t and the type promot
Author: truckman
Date: Sat Mar 18 23:00:13 2017
New Revision: 315516
URL: https://svnweb.freebsd.org/changeset/base/315516
Log:
Change several constants used by the PIE algorithm from unsigned to signed.
- PIE_MAX_PROB is compared to variable of int64_t and the type promotion
rules ca
On 13 Oct, Alan Somers wrote:
> On Thu, Jul 2, 2015 at 11:31 AM, Renato Botelho wrote:
>> Author: garga (ports committer)
>> Date: Thu Jul 2 17:30:59 2015
>> New Revision: 285050
>> URL: https://svnweb.freebsd.org/changeset/base/285050
>>
>> Log:
>> When passwd or group information is changed (
Author: truckman
Date: Mon Jul 18 06:09:52 2016
New Revision: 302987
URL: https://svnweb.freebsd.org/changeset/base/302987
Log:
MFC r302667
Fix problems in the FQ-PIE AQM cleanup code that could leak memory or
cause a crash.
Because dummynet calls pie_cleanup() while holding a mutex,
Author: truckman
Date: Sat Jul 16 06:41:02 2016
New Revision: 302927
URL: https://svnweb.freebsd.org/changeset/base/302927
Log:
MFC r302667
Fix problems in the FQ-PIE AQM cleanup code that could leak memory or
cause a crash.
Because dummynet calls pie_cleanup() while holding a mutex,
Author: truckman
Date: Tue Jul 12 17:32:40 2016
New Revision: 302667
URL: https://svnweb.freebsd.org/changeset/base/302667
Log:
Fix problems in the FQ-PIE AQM cleanup code that could leak memory or
cause a crash.
Because dummynet calls pie_cleanup() while holding a mutex, pie_cleanup()
Author: truckman
Date: Fri Jul 8 02:52:39 2016
New Revision: 302422
URL: https://svnweb.freebsd.org/changeset/base/302422
Log:
MFC r302338
Fix a race condition between the main thread in aqm_pie_cleanup() and the
callout thread that can cause a kernel panic. Always do the final cleanup
Author: truckman
Date: Wed Jul 6 17:45:38 2016
New Revision: 302377
URL: https://svnweb.freebsd.org/changeset/base/302377
Log:
MFC r300547
Fix multiple Coverity Out-of-bounds access false postive issues in CAM
The currently used idiom for clearing the part of a ccb after its
header
Author: truckman
Date: Wed Jul 6 17:42:09 2016
New Revision: 302376
URL: https://svnweb.freebsd.org/changeset/base/302376
Log:
MFC r299371 (by trasz)
Add "camcontrol reprobe" subcommand, and implement it for da(4).
This makes it possible to manually force updating capacity data
after t
Author: truckman
Date: Tue Jul 5 00:53:01 2016
New Revision: 302338
URL: https://svnweb.freebsd.org/changeset/base/302338
Log:
Fix a race condition between the main thread in aqm_pie_cleanup() and the
callout thread that can cause a kernel panic. Always do the final cleanup
in the callout
Author: truckman
Date: Mon Jun 20 19:00:47 2016
New Revision: 302032
URL: https://svnweb.freebsd.org/changeset/base/302032
Log:
MFC r300240
Change net.inet.tcp.ecn.enable sysctl mib from a binary off/on
control to a three way setting.
0 - Totally disable ECN. (no change)
1 - Enabl
Author: truckman
Date: Wed Jun 15 06:27:43 2016
New Revision: 301917
URL: https://svnweb.freebsd.org/changeset/base/301917
Log:
MFC r299484, r301574
r299484 | cem | 2016-05-11 15:04:28 -0700 (Wed, 11 May 2016) | 13 lines
random(6): Fix double-close
In the case where a file lacks a
Author: truckman
Date: Wed Jun 15 06:42:30 2016
New Revision: 301921
URL: https://svnweb.freebsd.org/changeset/base/301921
Log:
MFC r301596
Don't leak olinep if malloc() fails.
If malloc() fails to allocate linep, then free olinep (if it exists)
before returning to avoid a memory lea
Author: truckman
Date: Wed Jun 15 06:40:30 2016
New Revision: 301920
URL: https://svnweb.freebsd.org/changeset/base/301920
Log:
MFC r301592
Don't leak addrinfo if ai->ai_addrlen <= minsiz test fails.
If the ai->ai_addrlen <= minsiz test fails, then freeaddrinfo()
does not get called
Author: truckman
Date: Wed Jun 15 06:33:40 2016
New Revision: 301919
URL: https://svnweb.freebsd.org/changeset/base/301919
Log:
MFC r301582
Explicitly NUL terminate the buffer filled by fread().
The fix in r300649 was not sufficient to convince Coverity that the
buffer was NUL te
Author: truckman
Date: Fri Jun 10 00:00:25 2016
New Revision: 301772
URL: https://svnweb.freebsd.org/changeset/base/301772
Log:
MFC r300779, r300781, r300783, r300784, r300949, r301162, r301180
r300779 | truckman | 2016-05-26 14:40:13 -0700 (Thu, 26 May 2016) | 64 lines
Import Dummynet
Author: truckman
Date: Wed Jun 8 10:25:16 2016
New Revision: 301596
URL: https://svnweb.freebsd.org/changeset/base/301596
Log:
Don't leak olinep if malloc() fails.
If malloc() fails to allocate linep, then free olinep (if it exists)
before returning to avoid a memory leak.
Reported
Author: truckman
Date: Wed Jun 8 09:40:06 2016
New Revision: 301592
URL: https://svnweb.freebsd.org/changeset/base/301592
Log:
Don't leak addrinfo if ai->ai_addrlen <= minsiz test fails.
If the ai->ai_addrlen <= minsiz test fails, then freeaddrinfo()
does not get called to free the memor
Author: truckman
Date: Wed Jun 8 05:32:39 2016
New Revision: 301582
URL: https://svnweb.freebsd.org/changeset/base/301582
Log:
Explicitly NUL terminate the buffer filled by fread().
The fix in r300649 was not sufficient to convince Coverity that the
buffer was NUL terminated, even with t
Author: truckman
Date: Wed Jun 8 02:14:05 2016
New Revision: 301574
URL: https://svnweb.freebsd.org/changeset/base/301574
Log:
Fix a (false positive?) Argument cannot be negative coverity defect.
Rather than guarding close(fd) with an fd >= 0 test and setting fd
to -1 when it is closed t
Author: truckman
Date: Wed Jun 8 01:17:22 2016
New Revision: 301571
URL: https://svnweb.freebsd.org/changeset/base/301571
Log:
MFC r301139
The (i < PROMPTLEN - 1) test added by r300442 in the code for the default
case of \c in the prompt format string is a no-op. We already passed
thi
Author: truckman
Date: Tue Jun 7 16:56:15 2016
New Revision: 301557
URL: https://svnweb.freebsd.org/changeset/base/301557
Log:
MFC r300564
Fix CID 1006692 in /usr/sbin/pw pw_log() function and other fixes
The length of the name returned from the $LOGNAME and $USER can be
very long a
Author: truckman
Date: Tue Jun 7 16:53:05 2016
New Revision: 301556
URL: https://svnweb.freebsd.org/changeset/base/301556
Log:
MFC r299921
Add an assertion to catch a potential underflow in an array index
calculation, though this should not happen in the current code.
Reported by:
On 7 Jun, Steven Kreuzer wrote:
> Author: skreuzer (doc,ports committer)
> Date: Tue Jun 7 14:11:15 2016
> New Revision: 301546
> URL: https://svnweb.freebsd.org/changeset/base/301546
>
> Log:
> Document 300779, Dummynet AQM version 0.2.1
>
> Approved by:re (gjb, implicit, relnote
Author: truckman
Date: Fri Jun 3 00:48:50 2016
New Revision: 301231
URL: https://svnweb.freebsd.org/changeset/base/301231
Log:
MFC r266941, r266955
Needed for anticipated dummynet AQM MFC next week.
r266941 | hiren | 2014-06-01 00:28:24 -0700 (Sun, 01 Jun 2014) | 9 lines
ECN mark
Author: truckman
Date: Wed Jun 1 22:39:15 2016
New Revision: 301178
URL: https://svnweb.freebsd.org/changeset/base/301178
Log:
MFC r300705 (compensating for fortune moving from games to usr.bin)
Avoid buffer overflow when copying the input file name and appending .dat.
Check the retur
Author: truckman
Date: Thu Jun 2 00:42:15 2016
New Revision: 301180
URL: https://svnweb.freebsd.org/changeset/base/301180
Log:
Belatedly bump .Dd date for Dummynet AQM import in r300779.
Modified:
head/sbin/ipfw/ipfw.8
Modified: head/sbin/ipfw/ipfw.8
Author: truckman
Date: Wed Jun 1 20:04:24 2016
New Revision: 301162
URL: https://svnweb.freebsd.org/changeset/base/301162
Log:
Replace constant expressions that contain multiplications by
fractional floating point values with integer divides. This will
eliminate any chance that the compile
Author: truckman
Date: Wed Jun 1 17:57:56 2016
New Revision: 301156
URL: https://svnweb.freebsd.org/changeset/base/301156
Log:
MFC r300706
Avoid buffer overflow or truncation when constructing path_zoneinfo_file.
Reported by: Coverity
CID: 1011160
Modified:
stable/10/us
Author: truckman
Date: Wed Jun 1 17:47:34 2016
New Revision: 301155
URL: https://svnweb.freebsd.org/changeset/base/301155
Log:
MFC r300692
Close the input FILE * in read_file() and the output FILE * in write_file()
if read_stream() or write_stream() fails to avoid leaking the FILE.
Author: truckman
Date: Wed Jun 1 17:45:00 2016
New Revision: 301154
URL: https://svnweb.freebsd.org/changeset/base/301154
Log:
MFC r300666
Call closedir() before returning from fetchListFile() to avoid a leak.
Reported by: Coverity
CID: 1016697
Modified:
stable/10/lib/l
Author: truckman
Date: Wed Jun 1 17:43:04 2016
New Revision: 301153
URL: https://svnweb.freebsd.org/changeset/base/301153
Log:
MFC r300665
Don't leak addrinfo in fetch_bind()
Submitted by: Coverity
CID: 1225038
Modified:
stable/10/lib/libfetch/common.c
Directory Properti
Author: truckman
Date: Wed Jun 1 17:41:00 2016
New Revision: 301152
URL: https://svnweb.freebsd.org/changeset/base/301152
Log:
MFC r300664
Fix Coverity CID 978183 Resource leak in rexec().
Close the socket if connect() fails to avoid leaking it.
Reported by: Coverity
CID:
Author: truckman
Date: Wed Jun 1 17:39:03 2016
New Revision: 301151
URL: https://svnweb.freebsd.org/changeset/base/301151
Log:
MFC r300662
Fix Coverity CID 1016714 Resource leak in process_file_actions_entry()
Don't leak a file descriptor of _dup2() fails (shouldn't happen).
Repo
Author: truckman
Date: Wed Jun 1 17:37:16 2016
New Revision: 301150
URL: https://svnweb.freebsd.org/changeset/base/301150
Log:
MFC r300660
Fix 1016718 Resource leak.
Don't leak a file descriptor if fchdir() fails.
Reported by: Coverity
CID: 1016718
Modified:
stable
Author: truckman
Date: Wed Jun 1 17:35:03 2016
New Revision: 301149
URL: https://svnweb.freebsd.org/changeset/base/301149
Log:
MFC r300649
Fix Coverity CID 1019054 (String not null terminated) in setfacl.
Increase the size of buf[] by one to allow room for a NUL character
at the end
Author: truckman
Date: Wed Jun 1 17:33:02 2016
New Revision: 301148
URL: https://svnweb.freebsd.org/changeset/base/301148
Log:
MFC r300648
Fix CID 1011370 (Resource leak) in ps.
There is no need to to call strdup() on the value returned by fmt().
The latter calls fmt_argv() which al
Author: truckman
Date: Wed Jun 1 17:30:50 2016
New Revision: 301147
URL: https://svnweb.freebsd.org/changeset/base/301147
Log:
MFC r300643
Close from_fd if malloc() fails to avoid a file descriptor leak.
Reported by: Coverity
CID: 1007203
Modified:
stable/10/bin/mv/mv.c
Author: truckman
Date: Wed Jun 1 17:29:15 2016
New Revision: 301146
URL: https://svnweb.freebsd.org/changeset/base/301146
Log:
MFC r300642
Match the descriptions of the \H and \h prompt string sequences to reality.
They were swapped.
X-Confirmed by: jilles
Modified:
stable/
Author: truckman
Date: Wed Jun 1 17:20:36 2016
New Revision: 301144
URL: https://svnweb.freebsd.org/changeset/base/301144
Log:
MFC r300636
Delay calling yp_malloc_dnsent() until after some additional sanity
checks to avoid leaking memory on error returns.
Reported by: Coverity
CI
Author: truckman
Date: Wed Jun 1 17:18:35 2016
New Revision: 301143
URL: https://svnweb.freebsd.org/changeset/base/301143
Log:
MFC r300635
Call free(cur) if strdup(dirp->d_name) fails to avoid a memory leak.
Reported by: Coverity
CID: 1007414
Modified:
stable/10/usr.sbi
Author: truckman
Date: Wed Jun 1 17:16:35 2016
New Revision: 301142
URL: https://svnweb.freebsd.org/changeset/base/301142
Log:
MFC r300633
Fix acpidb CIDs 1011279 (Buffer not null terminated) and 978405 and
1199380 (Resource leak).
load_dsdt() calls strncpy() to copy a filename and
Author: truckman
Date: Wed Jun 1 17:13:43 2016
New Revision: 301141
URL: https://svnweb.freebsd.org/changeset/base/301141
Log:
MFC r300632
Fix acpidump CID 1011278 (Buffer not null terminated) and other issues
Coverity reports that a buffer used for temporary file generation
might n
Author: truckman
Date: Wed Jun 1 17:09:50 2016
New Revision: 301140
URL: https://svnweb.freebsd.org/changeset/base/301140
Log:
MFC r300442
Hopefully fix Coverity CID 1008328 (Out-of-bounds write) in /bin/sh.
Replace the magic constant 127 in the loop interation count with
"PROMPTLEN
On 1 Jun, To: src-committ...@freebsd.org wrote:
> Author: truckman
> Date: Wed Jun 1 16:56:29 2016
> New Revision: 301139
> URL: https://svnweb.freebsd.org/changeset/base/301139
>
> Log:
> The (i < PROMPTLEN - 1) test added by r300442 in the code for the default
> case of \c in the prompt fo
Author: truckman
Date: Wed Jun 1 16:56:29 2016
New Revision: 301139
URL: https://svnweb.freebsd.org/changeset/base/301139
Log:
The (i < PROMPTLEN - 1) test added by r300442 in the code for the default
case of \c in the prompt format string is a no-op. We already passed
this test at the top
On 29 May, Alan Somers wrote:
> On Sun, May 29, 2016 at 4:41 AM, Ed Schouten wrote:
>> Author: ed
>> Date: Sun May 29 10:41:27 2016
>> New Revision: 300952
>> URL: https://svnweb.freebsd.org/changeset/base/300952
>>
>> Log:
>> Invoke the dirname() function in a POSIX compliant way.
>>
>> POSIX
On 29 May, Bruce Evans wrote:
> On Sun, 29 May 2016, Don Lewis wrote:
>
>> Log:
>> Cast some expressions that multiply a long long constant by a
>> floating point constant to int64_t. This avoids the runtime
>> conversion of the the other operand in a set of c
Author: truckman
Date: Sun May 29 07:29:35 2016
New Revision: 300950
URL: https://svnweb.freebsd.org/changeset/base/300950
Log:
Now that PIE is free of runtime floating point, revert r300853 to
reconnect PIE to the build.
Modified:
head/sys/conf/files
head/sys/modules/dummynet/Makefile
Author: truckman
Date: Sun May 29 07:23:56 2016
New Revision: 300949
URL: https://svnweb.freebsd.org/changeset/base/300949
Log:
Cast some expressions that multiply a long long constant by a
floating point constant to int64_t. This avoids the runtime
conversion of the the other operand in a
Author: truckman
Date: Fri May 27 17:07:07 2016
New Revision: 300853
URL: https://svnweb.freebsd.org/changeset/base/300853
Log:
Disconnect PIE from the build until it is free of floating point math.
Reported by: lidl, adrian
Modified:
head/sys/conf/files
head/sys/modules/dummynet/Make
On 27 May, Adrian Chadd wrote:
> Hi,
>
> Did this introduce floating point into the kernel?
Cr*p, it did. It looks fixable, but I'll disconnect PIE from the build
for now.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/lis
On 26 May, To: src-committ...@freebsd.org wrote:
> Author: truckman
> Date: Thu May 26 21:40:13 2016
> New Revision: 300779
> URL: https://svnweb.freebsd.org/changeset/base/300779
>
> Log:
> Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE).
>
> Centre for Advanced Interne
1 - 100 of 318 matches
Mail list logo
