On 31.10.2013 23:32, Ian Lepore wrote:
On Thu, 2013-10-31 at 23:17 +0100, Andre Oppermann wrote:
On 31.10.2013 20:27, Ian Lepore wrote:
On Thu, 2013-10-31 at 20:08 +0100, Andre Oppermann wrote:
On 31.10.2013 19:03, Luigi Rizzo wrote:
On Thu, Oct 31, 2013 at 03:46:10PM +, Andre Oppermann
On 31.10.2013 21:15, Ian Lepore wrote:
On Thu, 2013-10-31 at 21:05 +0100, Luigi Rizzo wrote:
On Thu, Oct 31, 2013 at 01:27:25PM -0600, Ian Lepore wrote:
...
Is there any chance all this reworking might get us to a position where
the protocol header in an mbuf doesn't have to be 32-bit aligned
a
On 31.10.2013 20:27, Ian Lepore wrote:
On Thu, 2013-10-31 at 20:08 +0100, Andre Oppermann wrote:
On 31.10.2013 19:03, Luigi Rizzo wrote:
On Thu, Oct 31, 2013 at 03:46:10PM +, Andre Oppermann wrote:
Author: andre
Date: Thu Oct 31 15:46:10 2013
New Revision: 257455
URL: http
On 31.10.2013 19:03, Luigi Rizzo wrote:
On Thu, Oct 31, 2013 at 03:46:10PM +, Andre Oppermann wrote:
Author: andre
Date: Thu Oct 31 15:46:10 2013
New Revision: 257455
URL: http://svnweb.freebsd.org/changeset/base/257455
Log:
Make struct ifnet readable and comprehensible again by
Author: andre
Date: Thu Oct 31 15:46:10 2013
New Revision: 257455
URL: http://svnweb.freebsd.org/changeset/base/257455
Log:
Make struct ifnet readable and comprehensible again by grouping
and ordering related variables, fields and locks next to each
other. Add more comments to variables.
On 30.10.2013 18:40, Sergey Kandaurov wrote:
On 30 October 2013 20:56, Andre Oppermann wrote:
Author: andre
Date: Wed Oct 30 16:56:46 2013
New Revision: 257391
URL: http://svnweb.freebsd.org/changeset/base/257391
Log:
nclude missing net/if_var.h.
Due to header pollution it wasn&#
Author: andre
Date: Wed Oct 30 16:56:46 2013
New Revision: 257391
URL: http://svnweb.freebsd.org/changeset/base/257391
Log:
nclude missing net/if_var.h.
Due to header pollution it wasn't noticed before.
Modified:
head/sys/dev/snc/dp83932.c
head/sys/mips/nlm/dev/net/xlpge.c
Modified: h
Author: andre
Date: Tue Oct 29 21:00:54 2013
New Revision: 257367
URL: http://svnweb.freebsd.org/changeset/base/257367
Log:
MFC r256920:
The TCP delayed ACK logic isn't aware of LRO passing up large aggregated
segments thinking it received only one segment. This causes it to enable
Author: andre
Date: Tue Oct 29 17:48:08 2013
New Revision: 257351
URL: http://svnweb.freebsd.org/changeset/base/257351
Log:
Move all interface queue related structures, macros and definitions
from net/if_var to it own new net/ifq.h.
For now net/ifq.h is unconditionally included through ne
Author: andre
Date: Tue Oct 22 18:24:34 2013
New Revision: 256920
URL: http://svnweb.freebsd.org/changeset/base/256920
Log:
The TCP delayed ACK logic isn't aware of LRO passing up large aggregated
segments thinking it received only one segment. This causes it to enable
the delay the ACK for
On 16.09.2013 08:25, Konstantin Belousov wrote:
Author: kib
Date: Mon Sep 16 06:25:54 2013
New Revision: 255608
URL: http://svnweb.freebsd.org/changeset/base/255608
Log:
Remove zero-copy sockets code. It only worked for anonymous memory,
and the equivalent functionality is now provided by
On 07.09.2013 17:30, Mikolaj Golub wrote:
Hi,
On Sat, Aug 24, 2013 at 11:17:25AM +, Andre Oppermann wrote:
Author: andre
Date: Sat Aug 24 11:17:25 2013
New Revision: 254773
URL: http://svnweb.freebsd.org/changeset/base/254773
Log:
Resolve the confusion between the head_list and the
Author: andre
Date: Tue Aug 27 20:52:02 2013
New Revision: 254973
URL: http://svnweb.freebsd.org/changeset/base/254973
Log:
Pad m_hdr on 32bit architectures to to prevent alignment and padding
problems with the way MLEN, MHLEN, and struct mbuf are set up.
CTASSERT's are provided to detect
On 26.08.2013 13:00, Gleb Smirnoff wrote:
On Sat, Aug 24, 2013 at 07:58:36PM +, Andre Oppermann wrote:
A> Author: andre
A> Date: Sat Aug 24 19:58:36 2013
A> New Revision: 254805
A> URL: http://svnweb.freebsd.org/changeset/base/254805
A>
A> Log:
A> Add mtodo(m, o) macro
On 26.08.2013 12:50, Gleb Smirnoff wrote:
On Sat, Aug 24, 2013 at 12:24:59PM +, Andre Oppermann wrote:
A> Author: andre
A> Date: Sat Aug 24 12:24:58 2013
A> New Revision: 254779
A> URL: http://svnweb.freebsd.org/changeset/base/254779
A>
A> Log:
A> Avoid code
On 26.08.2013 11:43, Gleb Smirnoff wrote:
A> Author: andre
A> Date: Mon Aug 19 14:25:11 2013
A> New Revision: 254527
A> URL: http://svnweb.freebsd.org/changeset/base/254527
A>
A> Log:
A> Reorder the mbuf defines to make more sense and group related flags
A> together.
A>
A> Add M_FLAG_PRINTF
Author: andre
Date: Mon Aug 26 13:17:37 2013
New Revision: 254910
URL: http://svnweb.freebsd.org/changeset/base/254910
Log:
Fix mbuf debugging printf()'s after the recent mbuf header changes.
Modified:
head/sys/dev/xen/netback/netback.c
Modified: head/sys/dev/xen/netback/netback.c
==
Author: andre
Date: Sun Aug 25 13:30:37 2013
New Revision: 254857
URL: http://svnweb.freebsd.org/changeset/base/254857
Log:
Fix CSUM compatibility mapping. SCTP is a layer 4 protocol.
Submitted by: tuexen
Modified:
head/sys/sys/mbuf.h
Modified: head/sys/sys/mbuf.h
=
Author: andre
Date: Sun Aug 25 11:01:18 2013
New Revision: 254844
URL: http://svnweb.freebsd.org/changeset/base/254844
Log:
Bump FreeBSD_version after the struct mbuf changes in r254780,
r254799, r254804, r254807, and r254842.
Sponsored by: The FreeBSD Foundation
Modified:
head/sys/sys
Author: andre
Date: Sun Aug 25 10:57:09 2013
New Revision: 254842
URL: http://svnweb.freebsd.org/changeset/base/254842
Log:
Give (*ext_free) an int return value allowing for very sophisticated
external mbuf buffer management capabilities in the future.
For now only EXT_FREE_OK is defined
Author: andre
Date: Sun Aug 25 09:49:00 2013
New Revision: 254834
URL: http://svnweb.freebsd.org/changeset/base/254834
Log:
For now limit printf(9) %x of the 64bit pkthdr.csum_flags field to 32bits.
The upper 32bits are not occupied for now.
Sponsored by: The FreeBSD Foundation
Modified:
Author: andre
Date: Sun Aug 25 09:45:26 2013
New Revision: 254832
URL: http://svnweb.freebsd.org/changeset/base/254832
Log:
Change m->pkthdr.header to m->pkthdr.PH_loc.ptr after r254804
to transiently store pointers to packet headers.
Sponsored by: The FreeBSD Foundation
Modified:
head
Author: andre
Date: Sun Aug 25 09:41:37 2013
New Revision: 254831
URL: http://svnweb.freebsd.org/changeset/base/254831
Log:
Remove unnecessary setup of the m->pkthdr.header pointer.
Sponsored by: The FreeBSD Foundation
Modified:
head/sys/net/if_fddisubr.c
head/sys/net/if_iso88025subr.c
Author: andre
Date: Sun Aug 25 09:40:15 2013
New Revision: 254830
URL: http://svnweb.freebsd.org/changeset/base/254830
Log:
Adjust socow_iodone() after r254799.
Sponsored by: The FreeBSD Foundation
Modified:
head/sys/kern/uipc_cow.c
Modified: head/sys/kern/uipc_cow.c
===
On 24.08.2013 23:25, Benjamin Kaduk wrote:
On Sat, Aug 24, 2013 at 6:38 AM, Andre Oppermann mailto:an...@freebsd.org>> wrote:
Author: andre
Date: Sat Aug 24 10:38:02 2013
New Revision: 254772
URL: http://svnweb.freebsd.org/changeset/base/254772
Log:
pfil_ho
Author: andre
Date: Sat Aug 24 21:30:35 2013
New Revision: 254815
URL: http://svnweb.freebsd.org/changeset/base/254815
Log:
Fix BUGS section after botched modify in r254772.
Reported by: bjk
Modified:
head/share/man/man9/pfil.9
Modified: head/share/man/man9/pfil.9
=
On 24.08.2013 23:13, Glen Barber wrote:
On Sat, Aug 24, 2013 at 12:24:59PM +, Andre Oppermann wrote:
Author: andre
Date: Sat Aug 24 12:24:58 2013
New Revision: 254779
URL: http://svnweb.freebsd.org/changeset/base/254779
Log:
Avoid code duplication for mbuf initialization and use m_init
Author: andre
Date: Sat Aug 24 21:25:53 2013
New Revision: 254814
URL: http://svnweb.freebsd.org/changeset/base/254814
Log:
After r254779 "error" must always be present in mb_ctor_pack(),
not only when MAC is defined.
Reported by: gjb / tinderbox
Sponsored by: The FreeBSD Foundation
M
Author: andre
Date: Sat Aug 24 21:09:57 2013
New Revision: 254812
URL: http://svnweb.freebsd.org/changeset/base/254812
Log:
Remove unused m_free_fast(). The difference to m_free() is only
2 predictable branches nowadays. However as a pre-condition the
caller had to ensure that the mbuf pkt
Author: andre
Date: Sat Aug 24 20:26:41 2013
New Revision: 254807
URL: http://svnweb.freebsd.org/changeset/base/254807
Log:
Compact m_hdr by packing the type and flags fields into one uint32_t.
The mbuf type is an enumerator with only a handful of types in use and
thus reduced from int to
Author: andre
Date: Sat Aug 24 19:58:36 2013
New Revision: 254805
URL: http://svnweb.freebsd.org/changeset/base/254805
Log:
Add mtodo(m, o) macro taking an additional offset into the mbuf data section.
Sponsored by: The FreeBSD Foundation
Modified:
head/sys/sys/mbuf.h
Modified: head/sys
Author: andre
Date: Sat Aug 24 19:51:18 2013
New Revision: 254804
URL: http://svnweb.freebsd.org/changeset/base/254804
Log:
Restructure the mbuf pkthdr to make it fit for upcoming capabilities and
features. The changes in particular are:
o Remove rarely used "header" pointer and replace
Author: andre
Date: Sat Aug 24 19:38:36 2013
New Revision: 254803
URL: http://svnweb.freebsd.org/changeset/base/254803
Log:
Change local variable tso_segsz to tsosegsz to avoid mbuf.h macro conflicts.
Sponsored by: The FreeBSD Foundation
Modified:
head/sys/dev/jme/if_jme.c
head/sys/dev
Author: andre
Date: Sat Aug 24 17:14:14 2013
New Revision: 254800
URL: http://svnweb.freebsd.org/changeset/base/254800
Log:
Remove unnecessary setup of the m->pkthdr.header pointer.
Sponsored by: The FreeBSD Foundation
Modified:
head/sys/dev/cxgb/cxgb_sge.c
head/sys/dev/sfxge/sfxge_rx.
Author: andre
Date: Sat Aug 24 16:57:44 2013
New Revision: 254799
URL: http://svnweb.freebsd.org/changeset/base/254799
Log:
Add an mbuf pointer parameter to (*ext_free) to give the external
free function access to the mbuf the external memory was attached
to.
Mechanically adjust all use
On 24.08.2013 15:15, Andre Oppermann wrote:
Author: andre
Date: Sat Aug 24 13:15:42 2013
New Revision: 254780
URL: http://svnweb.freebsd.org/changeset/base/254780
Log:
dd a 24 bits wide ext_flags field to m_ext by reducing ext_type
to 8 bits. ext_type is an enumerator and the number of
Author: andre
Date: Sat Aug 24 13:15:42 2013
New Revision: 254780
URL: http://svnweb.freebsd.org/changeset/base/254780
Log:
dd a 24 bits wide ext_flags field to m_ext by reducing ext_type
to 8 bits. ext_type is an enumerator and the number of types we
have is a mere dozen.
A couple of
Author: andre
Date: Sat Aug 24 12:24:58 2013
New Revision: 254779
URL: http://svnweb.freebsd.org/changeset/base/254779
Log:
Avoid code duplication for mbuf initialization and use m_init() instead
in mb_ctor_mbuf() and mb_ctor_pack().
Modified:
head/sys/kern/kern_mbuf.c
Modified: head/sys/k
Author: andre
Date: Sat Aug 24 12:03:24 2013
New Revision: 254777
URL: http://svnweb.freebsd.org/changeset/base/254777
Log:
Whitespace, style cleanups, and improved comments.
Modified:
head/sys/net/pfil.h
Modified: head/sys/net/pfil.h
=
Author: andre
Date: Sat Aug 24 11:57:02 2013
New Revision: 254775
URL: http://svnweb.freebsd.org/changeset/base/254775
Log:
Adjust for the pfil_func_t typedef added in r254769.
Modified:
head/share/man/man9/pfil.9
Modified: head/share/man/man9/pfil.9
=
Author: andre
Date: Sat Aug 24 11:24:15 2013
New Revision: 254774
URL: http://svnweb.freebsd.org/changeset/base/254774
Log:
ename PFIL_LIST_[UN]LOCK() to PFIL_HEADLIST_[UN]LOCK() to avoid
confusion with the pfil_head chain locking macros.
Modified:
head/sys/net/pfil.c
head/sys/net/pfil.h
Author: andre
Date: Sat Aug 24 11:17:25 2013
New Revision: 254773
URL: http://svnweb.freebsd.org/changeset/base/254773
Log:
Resolve the confusion between the head_list and the hook list.
The linked list of pfil hooks is changed to "chain" and this term
is applied consistently. The head_l
Author: andre
Date: Sat Aug 24 10:38:02 2013
New Revision: 254772
URL: http://svnweb.freebsd.org/changeset/base/254772
Log:
pfil_hook_get() has been internalized in r254771 and is no longer
part of the API. It wasn't safe for external use in any case.
Modified:
head/share/man/man9/pfil.9
Author: andre
Date: Sat Aug 24 10:36:33 2013
New Revision: 254771
URL: http://svnweb.freebsd.org/changeset/base/254771
Log:
Internalize pfil_hook_get(). There are no outside consumers of
this API, it is only safe for internal use and even the pfil(9)
man page says so in the BUGS section.
Author: andre
Date: Sat Aug 24 10:30:20 2013
New Revision: 254770
URL: http://svnweb.freebsd.org/changeset/base/254770
Log:
Convert one instance of pfil hook callback missed in r254769.
Modified:
head/sys/net/pfil.c
Modified: head/sys/net/pfil.c
==
Author: andre
Date: Sat Aug 24 10:13:59 2013
New Revision: 254769
URL: http://svnweb.freebsd.org/changeset/base/254769
Log:
Introduce typedef for pfil hook callback function and replace all
spelled out occurrences with it.
Reviewed by: eri
Modified:
head/sys/net/pfil.c
head/sys/net/
On 21.08.2013 21:59, Navdeep Parhar wrote:
On 08/21/13 12:41, Scott Long wrote:
On Aug 21, 2013, at 8:59 AM, Andre Oppermann wrote:
On 19.08.2013 23:45, Navdeep Parhar wrote:
On 08/19/13 13:58, Andre Oppermann wrote:
On 19.08.2013 19:33, Navdeep Parhar wrote:
On 08/19/13 04:16, Andre
Author: andre
Date: Wed Aug 21 18:12:04 2013
New Revision: 254605
URL: http://svnweb.freebsd.org/changeset/base/254605
Log:
Revert r254520 and resurrect the M_NOFREE mbuf flag and functionality.
Requested by: np, grehan
Modified:
head/sys/kern/kern_mbuf.c
head/sys/kern/uipc_mbuf.c
he
On 21.08.2013 17:59, Davide Italiano wrote:
On Wed, Aug 21, 2013 at 5:30 PM, Andre Oppermann wrote:
On 20.08.2013 20:13, Davide Italiano wrote:
On Tue, Aug 20, 2013 at 7:42 PM, Andre Oppermann
wrote:
On 19.08.2013 19:37, Navdeep Parhar wrote:
Why reuse the freed up bits so soon (at
On 21.08.2013 17:03, Peter Grehan wrote:
The way to go should be 4K clusters as they are native to the architecture.
IIRC a PCIe DMA can't cross a 4K boundary anyway
That's a 4G boundary, for some devices.
I meant a single PCIe DMA transaction can be at most 4K before it has to set
up anoth
On 20.08.2013 20:13, Davide Italiano wrote:
On Tue, Aug 20, 2013 at 7:42 PM, Andre Oppermann wrote:
On 19.08.2013 19:37, Navdeep Parhar wrote:
Why reuse the freed up bits so soon (at least one of which I think was
prematurely GC'ed -- see my other email on M_NOFREE). There was room
b
On 20.08.2013 05:04, Julian Elischer wrote:
On 8/19/13 7:08 PM, Andre Oppermann wrote:
Author: andre
Date: Mon Aug 19 11:08:36 2013
New Revision: 254519
URL: http://svnweb.freebsd.org/changeset/base/254519
Log:
Move the global M_SKIP_FIREWALL mbuf flags to a protocol layer specific
flag
On 20.08.2013 00:03, Navdeep Parhar wrote:
On 08/19/13 14:08, Andre Oppermann wrote:
On 19.08.2013 19:40, Peter Grehan wrote:
I recently tried some experiments to reduce the number of mbuf and
cluster allocations in a 40G NIC driver. M_NOFREE and EXT_EXTREF proved
very useful and the code
On 19.08.2013 23:45, Navdeep Parhar wrote:
On 08/19/13 13:58, Andre Oppermann wrote:
On 19.08.2013 19:33, Navdeep Parhar wrote:
On 08/19/13 04:16, Andre Oppermann wrote:
Author: andre
Date: Mon Aug 19 11:16:53 2013
New Revision: 254520
URL: http://svnweb.freebsd.org/changeset/base/254520
Log
On 19.08.2013 19:37, Navdeep Parhar wrote:
On 08/19/13 06:56, Andre Oppermann wrote:
Author: andre
Date: Mon Aug 19 13:56:14 2013
New Revision: 254524
URL: http://svnweb.freebsd.org/changeset/base/254524
Log:
Add four additional M_PROTOFLAGS[9-12] for protocol specific use.
Discussed
On 19.08.2013 19:40, Peter Grehan wrote:
I recently tried some experiments to reduce the number of mbuf and
cluster allocations in a 40G NIC driver. M_NOFREE and EXT_EXTREF proved
very useful and the code changes to the kernel were minimal. See
user/np/cxl_tuning. The experiment was quite succ
On 19.08.2013 19:33, Navdeep Parhar wrote:
On 08/19/13 04:16, Andre Oppermann wrote:
Author: andre
Date: Mon Aug 19 11:16:53 2013
New Revision: 254520
URL: http://svnweb.freebsd.org/changeset/base/254520
Log:
Remove the unused M_NOFREE mbuf flag. It didn't have any in-tree users
On 19.08.2013 17:12, Adrian Chadd wrote:
Hi,
Would you please bump FreeBSD_version ?
Done:
New Revision: 254537
URL: http://svnweb.freebsd.org/changeset/base/254537
Log:
Bump __FreeBSD_version to 146 after the addition of M_PROTO[9-12]
and removal of M_NOFREE|M_FRAG|M_FIRSTFRAG|M_LAS
Author: andre
Date: Mon Aug 19 16:47:06 2013
New Revision: 254537
URL: http://svnweb.freebsd.org/changeset/base/254537
Log:
Bump __FreeBSD_version to 146 after the addition of M_PROTO[9-12]
and removal of M_NOFREE|M_FRAG|M_FIRSTFRAG|M_LASTFRAG mbuf flags.
Modified:
head/sys/sys/param.h
Author: andre
Date: Mon Aug 19 14:25:11 2013
New Revision: 254527
URL: http://svnweb.freebsd.org/changeset/base/254527
Log:
Reorder the mbuf defines to make more sense and group related flags
together.
Add M_FLAG_PRINTF for use with printf(9) %b indentifier.
Use the generic mbuf flag
Author: andre
Date: Mon Aug 19 14:07:31 2013
New Revision: 254526
URL: http://svnweb.freebsd.org/changeset/base/254526
Log:
Migrate the net80211 protocol specific use of M_FRAG, M_FIRSTFRAG and
M_LASTFRAG flags to protocol specific flags.
Remove the now unused M_FRAG, M_FIRSTFRAG and M_LA
Author: andre
Date: Mon Aug 19 13:56:14 2013
New Revision: 254524
URL: http://svnweb.freebsd.org/changeset/base/254524
Log:
Add four additional M_PROTOFLAGS[9-12] for protocol specific use.
Discussed with: trociny, glebius, adrian
Modified:
head/sys/sys/mbuf.h
Modified: head/sys/s
Author: andre
Date: Mon Aug 19 13:27:32 2013
New Revision: 254523
URL: http://svnweb.freebsd.org/changeset/base/254523
Log:
Add m_clrprotoflags() to clear protocol specific mbuf flags at up and
downwards layer crossings.
Consistently use it within IP, IPv6 and ethernet protocols.
Dis
Author: andre
Date: Mon Aug 19 12:30:18 2013
New Revision: 254521
URL: http://svnweb.freebsd.org/changeset/base/254521
Log:
Move the SCTP specific definition of M_NOTIFICATION onto a protocol
specific mbuf flag from sys/mbuf.h to netinet/sctp_os_bsd.h. It is
only relevant within SCTP.
On 19.08.2013 13:23, Davide Italiano wrote:
On Mon, Aug 19, 2013 at 1:16 PM, Andre Oppermann wrote:
Modified: head/sys/sys/mbuf.h
==
--- head/sys/sys/mbuf.h Mon Aug 19 11:08:36 2013(r254519)
+++ head/sys/sys
Author: andre
Date: Mon Aug 19 11:16:53 2013
New Revision: 254520
URL: http://svnweb.freebsd.org/changeset/base/254520
Log:
Remove the unused M_NOFREE mbuf flag. It didn't have any in-tree users
for a very long time, if ever.
Should such a functionality ever be needed again the appropria
Author: andre
Date: Mon Aug 19 11:08:36 2013
New Revision: 254519
URL: http://svnweb.freebsd.org/changeset/base/254519
Log:
Move the global M_SKIP_FIREWALL mbuf flags to a protocol layer specific
flag instead. The flag is only used within the IP and IPv6 layer 3
protocols.
Because some
Author: andre
Date: Mon Aug 19 10:34:10 2013
New Revision: 254518
URL: http://svnweb.freebsd.org/changeset/base/254518
Log:
Move ip_reassemble()'s use of the global M_FRAG mbuf flag to a protocol layer
specific flag instead. The flag is only relevant while the packet stays in
the IP reassem
Author: andre
Date: Mon Aug 19 10:30:15 2013
New Revision: 254517
URL: http://svnweb.freebsd.org/changeset/base/254517
Log:
Remove unused M_FRAG, M_FIRSTFRAG and M_LASTFRAG tagging from ip_fragment().
There wasn't any real driver (and hardware) support for it. Modern hardware
does full frag
Author: andre
Date: Mon Aug 19 10:20:20 2013
New Revision: 254516
URL: http://svnweb.freebsd.org/changeset/base/254516
Log:
Remove unused and incomplete support for delayed fragment checksums
from bce(4), bxe(4), mge(4) and ti(4) drivers.
Modified:
head/sys/dev/bce/if_bce.c
head/sys/dev/b
Author: andre
Date: Mon Aug 19 09:49:51 2013
New Revision: 254515
URL: http://svnweb.freebsd.org/changeset/base/254515
Log:
MFC a bundle of commits that bring autotuning to mbufs, maxfiles/sockets
and maxusers to the 9-stable branch. It is committed as bundle because
these patches build on
Author: andre
Date: Tue Jul 16 16:37:08 2013
New Revision: 253395
URL: http://svnweb.freebsd.org/changeset/base/253395
Log:
Free the non-fatal "timestamp missing" debug string manually as it is
not covered by the catch-all free for the error cases.
Found by: Coverity
Modified:
head
On 15.07.2013 20:38, Mikolaj Golub wrote:
On Mon, Jul 15, 2013 at 11:36:16AM +0200, Ulrich Spörlein wrote:
Hey Andre,
I don't see why this commit triggers it, but Coverity Scan found a new
resource leak in this file. syncache_expand() will leak *s when line
1071 is reached. The "failed:" case b
On 12.07.2013 09:43, Andre Oppermann wrote:
Author: andre
Date: Fri Jul 12 07:43:56 2013
New Revision: 253254
URL: http://svnweb.freebsd.org/changeset/base/253254
Log:
Unbreak VIMAGE by correctly naming the vnet pointer in struct tcp_syncache.
Reported by: trociny, rodrigc
Sorry for
Author: andre
Date: Fri Jul 12 07:43:56 2013
New Revision: 253254
URL: http://svnweb.freebsd.org/changeset/base/253254
Log:
Unbreak VIMAGE by correctly naming the vnet pointer in struct tcp_syncache.
Reported by: trociny, rodrigc
Modified:
head/sys/netinet/tcp_syncache.h
Modified: head
Author: andre
Date: Thu Jul 11 16:27:11 2013
New Revision: 253214
URL: http://svnweb.freebsd.org/changeset/base/253214
Log:
Fix const propagation issues to make GCC happy.
Submitted by: Michael Butler
Modified:
head/sys/crypto/siphash/siphash.c
Modified: head/sys/crypto/siphash/siphash
On 11.07.2013 16:18, Andre Oppermann wrote:
Author: andre
Date: Thu Jul 11 14:18:38 2013
New Revision: 253208
URL: http://svnweb.freebsd.org/changeset/base/253208
Log:
SipHash is a cryptographically strong pseudo-random function (a.k.a. keyed
hash function) optimized for speed on short
* Copyright (c) 2006 Andre Oppermann, Internet Business Solutions AG
+ * Copyright (c) 2006,2013 Andre Oppermann, Internet Business Solutions AG
* All rights reserved.
*
* This software was developed for the FreeBSD Project by Jonathan Lemon
* and McAfee Research, the Security Research Div
=
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ head/sys/crypto/siphash/siphash.c Thu Jul 11 14:18:38 2013
(r253208)
@@ -0,0 +1,241 @@
+/*-
+ * Copyright (c) 2013 Andre Oppermann
+ * All rights reserved.
+ *
+ * Red
Author: andre
Date: Thu Jul 11 12:53:13 2013
New Revision: 253207
URL: http://svnweb.freebsd.org/changeset/base/253207
Log:
Make use of the fact that uma_zone_set_max(9) already returns the
rounded limit making a call to uma_zone_get_max(9) unnecessary.
MFC after:1 day
Modified:
he
Author: andre
Date: Thu Jul 11 12:46:35 2013
New Revision: 253204
URL: http://svnweb.freebsd.org/changeset/base/253204
Log:
Fix style issues, a typo in "kern.ipc.nmbufs" and correctly plave and
expose the value of the tunable maxmbufmem as "kern.ipc.maxmbufmem"
through sysctl.
Reported
Author: andre
Date: Wed Jul 10 12:06:01 2013
New Revision: 253150
URL: http://svnweb.freebsd.org/changeset/base/253150
Log:
Extend debug logging of TCP timestamp related specification
violations.
Update related comments and style.
Modified:
head/sys/netinet/tcp_input.c
head/sys/netin
On 09.07.2013 11:32, Andrey V. Elsukov wrote:
Author: ae
Date: Tue Jul 9 09:32:06 2013
New Revision: 253081
URL: http://svnweb.freebsd.org/changeset/base/253081
Log:
Prepare network statistics structures for migration to PCPU counters.
Use uint64_t as type for all fields of structures.
Author: andre
Date: Mon Jul 8 13:24:18 2013
New Revision: 253035
URL: http://svnweb.freebsd.org/changeset/base/253035
Log:
MFC r241726:
Move UMA socket zone initialization from uipc_domain.c to uipc_socket.c
into one place next to its other related functions to avoid confusion.
MF
Author: andre
Date: Fri Jul 5 21:33:32 2013
New Revision: 252843
URL: http://svnweb.freebsd.org/changeset/base/252843
Log:
MFC r241703:
Remove double-wrapping of #ifdef ZERO_COPY_SOCKETS within
zero copy specialized sosend_copyin() helper function.
MFC r241704:
Remove unn
Author: andre
Date: Fri Jul 5 20:11:27 2013
New Revision: 252835
URL: http://svnweb.freebsd.org/changeset/base/252835
Log:
MFC r226433:
Update the comment and description of tcp_sendspace and tcp_recvspace
to better reflect their purpose.
MFC r226437:
VNET virtualize tcp_sen
Author: andre
Date: Fri Jul 5 19:43:33 2013
New Revision: 252831
URL: http://svnweb.freebsd.org/changeset/base/252831
Log:
MFC r241724:
Remove splimp() comment from sysinit table and attribute SI_SUB_PROTO_BEGIN
and SI_SUB_PROTO_END to VNET related initializations.
Modified:
stabl
Author: andre
Date: Fri Jul 5 19:36:34 2013
New Revision: 252828
URL: http://svnweb.freebsd.org/changeset/base/252828
Log:
MFC r243624:
Remove unused and unnecessary CSUM_IP_FRAGS checksumming capability.
Checksumming the IP header of fragments is no different from doing
normal I
Author: andre
Date: Fri Jul 5 19:11:12 2013
New Revision: 252825
URL: http://svnweb.freebsd.org/changeset/base/252825
Log:
MFC r242308:
Define the delayed ACK timeout value directly as hz/10 instead of
obfuscating it by going through PR_FASTHZ. No functional change.
Modified:
sta
Author: andre
Date: Fri Jul 5 18:56:04 2013
New Revision: 252824
URL: http://svnweb.freebsd.org/changeset/base/252824
Log:
MFC r242998:
Remove description of deprecated IP fragment checksum support.
Since SMPng it wasn't really supported anymore and if it worked
then only by chan
Author: andre
Date: Fri Jul 5 18:51:21 2013
New Revision: 252823
URL: http://svnweb.freebsd.org/changeset/base/252823
Log:
MFC r243628:
Update comment to prefer M_NOWAIT over M_DONTWAIT and
M_WAITOK over M_WAIT.
Modified:
stable/9/sys/sys/mbuf.h
Directory Properties:
stable/9/sy
Author: andre
Date: Fri Jul 5 16:03:19 2013
New Revision: 252796
URL: http://svnweb.freebsd.org/changeset/base/252796
Log:
MFC r242256:
Improve m_cat() by being able to also merge contents from M_EXT
mbuf's by doing proper testing with M_WRITABLE().
In m_collapse() replace an inc
Author: andre
Date: Fri Jul 5 15:57:36 2013
New Revision: 252794
URL: http://svnweb.freebsd.org/changeset/base/252794
Log:
MFC r242257:
Remove bogus 'else' in #ifdef that prevented the rttvar from being reset
tcp_timer_rexmt() on retransmit for IPv6 sessions.
MFC r242260:
Wh
Author: andre
Date: Fri Jul 5 15:47:59 2013
New Revision: 252793
URL: http://svnweb.freebsd.org/changeset/base/252793
Log:
MFC r242251, r242311:
Defer sending an independent window update if a delayed ACK is pending
saving a packet. The window update then gets piggy-backed on the next
Author: andre
Date: Fri Jul 5 15:30:02 2013
New Revision: 252792
URL: http://svnweb.freebsd.org/changeset/base/252792
Log:
MFC r244039:
Remove outdated reference to tcp inflight tuning.
Modified:
stable/9/share/man/man7/tuning.7
Directory Properties:
stable/9/ (props changed)
sta
Author: andre
Date: Fri Jul 5 15:26:12 2013
New Revision: 252791
URL: http://svnweb.freebsd.org/changeset/base/252791
Log:
MFC r243147:
Change fetch(1) to:
o Report the instantaneous bandwidth instead of an average since the
beginning of the download.
o At the finish of the dow
Author: andre
Date: Fri Jul 5 15:18:54 2013
New Revision: 252790
URL: http://svnweb.freebsd.org/changeset/base/252790
Log:
MFC r242253:
Simplify implementation of net.inet.tcp.reass.maxsegments and
net.inet.tcp.reass.cursegments.
MFC r242254:
Change the syncache count report
Author: andre
Date: Fri Jul 5 14:58:24 2013
New Revision: 252789
URL: http://svnweb.freebsd.org/changeset/base/252789
Log:
MFC r242266:
Increase the initial CWND to 10 segments as defined in IETF TCPM
draft-ietf-tcpm-initcwnd-05. It explains why the increased initial
window improves
Author: andre
Date: Fri Jul 5 14:50:06 2013
New Revision: 252788
URL: http://svnweb.freebsd.org/changeset/base/252788
Log:
MFC r226447:
Remove the ss_fltsz and ss_fltsz_local sysctl's which have
long been superseded by the RFC3390 initial CWND sizing.
Also remove the remnants of
Author: andre
Date: Fri Jul 5 14:30:54 2013
New Revision: 252787
URL: http://svnweb.freebsd.org/changeset/base/252787
Log:
MFC r249317:
Fix a race condition on tcp listen socket teardown with pending
connections in the accept queue and contiguous new incoming SYNs.
Compared to th
1 - 100 of 346 matches
Mail list logo
