svn commit: r367714 - head/sys/kern

2020-11-15 Thread Mateusz Guzik
Author: mjg Date: Mon Nov 16 03:12:21 2020 New Revision: 367714 URL: https://svnweb.freebsd.org/changeset/base/367714 Log: select: call seltdfini on process and thread exit Since thread_zone is marked NOFREE the thread_fini callback is never executed, meaning memory allocated by seltdinit

svn commit: r367713 - head/sys/kern

2020-11-15 Thread Mateusz Guzik
Author: mjg Date: Mon Nov 16 03:09:18 2020 New Revision: 367713 URL: https://svnweb.freebsd.org/changeset/base/367713 Log: select: replace reference counting with memory barriers in selfd Refcounting was added to combat a race between selfdfree and doselwakup, but it adds avoidable overhe

svn commit: r367712 - head/tools/build/mk

2020-11-15 Thread Dimitry Andric
Author: dim Date: Sun Nov 15 22:49:28 2020 New Revision: 367712 URL: https://svnweb.freebsd.org/changeset/base/367712 Log: Ensure make delete-old does not unlink the llvm-cxxfilt and its manpage, after r367304 and r367324, when WITH_LLVM_CXXFILT is enabled. Noticed by: "Herbert J. Skuhr

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Warner Losh
On Sun, Nov 15, 2020 at 1:13 PM Scott Long wrote: > > > On Nov 15, 2020, at 1:05 PM, Warner Losh wrote: > > > > Hey Scott, > > > > On Sun, Nov 15, 2020 at 11:46 AM Scott Long wrote: > > The man page for strlcpy() made reference to the return value being > > equivalent to what snprintf() does.

svn commit: r367711 - in head: lib/libutil sbin/nvmecontrol usr.sbin/mailwrapper usr.sbin/pkg

2020-11-15 Thread Scott Long
Author: scottl Date: Sun Nov 15 20:24:59 2020 New Revision: 367711 URL: https://svnweb.freebsd.org/changeset/base/367711 Log: Revert the whole getlocalbase() set of changes while a different design is hashed out. Deleted: head/lib/libutil/getlocalbase.3 head/lib/libutil/getlocalbase.c Mod

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Scott Long
> On Nov 15, 2020, at 1:05 PM, Warner Losh wrote: > > Hey Scott, > > On Sun, Nov 15, 2020 at 11:46 AM Scott Long wrote: > The man page for strlcpy() made reference to the return value being > equivalent to what snprintf() does. The man page for snprintf() states > that negatve return values a

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Warner Losh
Hey Scott, On Sun, Nov 15, 2020 at 11:46 AM Scott Long wrote: > The man page for strlcpy() made reference to the return value being > equivalent to what snprintf() does. The man page for snprintf() states > that negatve return values are possible, so I assumed the same was > true for strlcpy().

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Brandon Bergren
That would explain why I see what I see -- I did not install an updated libc yet. On Sun, Nov 15, 2020, at 1:34 PM, Scott Long wrote: > It is a magical namespace, in that it comes from libc, not from the > kernel. Please make sure that you’ve installed a more recent libc, I > guess? I just di

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Scott Long
It is a magical namespace, in that it comes from libc, not from the kernel. Please make sure that you’ve installed a more recent libc, I guess? I just did a full build and install, and I’m unable to replicate the problem. Maybe there’s a static-linked pkg running around somewhere? I’m at a l

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Brandon Bergren
I think the problem is that user.* is somehow magically namespaced, so doing a "dumb" sysctlbyname will get the wrong one. sysctl (the tool) does: __sysctl("sysctl.name2oid user.localbase",2,0xfbfffde98,0xfbfffda98,0x810809000,14) = 0 (0x0) __sysctl("sysctl.oidfmt user.localbase",4,0xff

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Jessica Clarke
On 15 Nov 2020, at 19:10, Brandon Bergren wrote: > > On powerpc64 and powerpc64le, there is some really weird behavior happening > around the sysctl itself: > > root@crow:~ # pkg > The package management tool is not yet installed on your system. > Do you want to fetch and install it now? [y/N]:

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Brandon Bergren
On powerpc64 and powerpc64le, there is some really weird behavior happening around the sysctl itself: root@crow:~ # pkg The package management tool is not yet installed on your system. Do you want to fetch and install it now? [y/N]: N root@crow:~ # sysctl user.localbase user.localbase: /usr/local

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Scott Long
> On Nov 15, 2020, at 12:01 PM, Jessica Clarke wrote: >> >> I felt similar concerns, but my misunderstanding of strlcpy() drove the >> result. Since the use case for getlocalbase() lends itself to also use >> strlcat()/strlcpy(), I was trying to replicate the API semantics of those, >> at least

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Jessica Clarke
On 15 Nov 2020, at 18:46, Scott Long wrote: >> On Nov 15, 2020, at 11:31 AM, Jessica Clarke wrote: >> >> Hi Scott, >> I'm concerned by this diff; see my comments below. >> >>> On 15 Nov 2020, at 07:48, Scott Long wrote: >>> >>> Author: scottl >>> Date: Sun Nov 15 07:48:52 2020 >>> New Revisio

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Scott Long
> On Nov 15, 2020, at 11:31 AM, Jessica Clarke wrote: > > Hi Scott, > I'm concerned by this diff; see my comments below. > >> On 15 Nov 2020, at 07:48, Scott Long wrote: >> >> Author: scottl >> Date: Sun Nov 15 07:48:52 2020 >> New Revision: 367701 >> URL: https://svnweb.freebsd.org/changese

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Jessica Clarke
Hi Scott, I'm concerned by this diff; see my comments below. > On 15 Nov 2020, at 07:48, Scott Long wrote: > > Author: scottl > Date: Sun Nov 15 07:48:52 2020 > New Revision: 367701 > URL: https://svnweb.freebsd.org/changeset/base/367701 > > Log: > Because getlocalbase() returns -1 on error, i

Re: svn commit: r367687 - in head: sbin/nvmecontrol usr.sbin/mailwrapper usr.sbin/pkg

2020-11-15 Thread Scott Long
I fixed this in r367702, sorry for the breakage. Scott > On Nov 15, 2020, at 11:12 AM, Brandon Bergren wrote: > >> --- head/usr.sbin/pkg/pkg.c Sat Nov 14 17:57:50 2020(r367686) >> +++ head/usr.sbin/pkg/pkg.c Sat Nov 14 18:01:14 2020(r367687) >> @@ -43,6 +43,7 @@ __FBSDID("$Fr

Re: svn commit: r367687 - in head: sbin/nvmecontrol usr.sbin/mailwrapper usr.sbin/pkg

2020-11-15 Thread Brandon Bergren
> --- head/usr.sbin/pkg/pkg.c Sat Nov 14 17:57:50 2020(r367686) > +++ head/usr.sbin/pkg/pkg.c Sat Nov 14 18:01:14 2020(r367687) > @@ -43,6 +43,7 @@ __FBSDID("$FreeBSD$"); > #include > #include > #include > +#include > #include > #include > #include > @@ -1037,6 +103

Re: svn commit: r367433 - in head/sys: compat/linux conf

2020-11-15 Thread Tijl Coosemans
On Fri, 6 Nov 2020 22:04:57 + (UTC) Conrad Meyer wrote: > Author: cem > Date: Fri Nov 6 22:04:57 2020 > New Revision: 367433 > URL: https://svnweb.freebsd.org/changeset/base/367433 > > Log: > linux(4): Fix loadable modules after r367395 > > Move dtrace SDT definitions into linux_commo

svn commit: r367710 - head/stand/i386/zfsboot

2020-11-15 Thread Toomas Soome
Author: tsoome Date: Sun Nov 15 14:04:27 2020 New Revision: 367710 URL: https://svnweb.freebsd.org/changeset/base/367710 Log: zfsboot: add prototype for main() Some compilers are complaining about missing prototype. PR: 251150 Reported by: markiyan.kush...@gmail.com Modif

svn commit: r367709 - head/usr.sbin/bhyve

2020-11-15 Thread Peter Grehan
Author: grehan Date: Sun Nov 15 12:59:24 2020 New Revision: 367709 URL: https://svnweb.freebsd.org/changeset/base/367709 Log: Fix regression in AHCI controller settings. When the AHCI code was reworked to use FreeBSD struct definitions, the valid element was mis-transcribed resulting in

svn commit: r367708 - stable/11/share/man/man7

2020-11-15 Thread Mateusz Piotrowski
Author: 0mp (doc,ports committer) Date: Sun Nov 15 12:31:07 2020 New Revision: 367708 URL: https://svnweb.freebsd.org/changeset/base/367708 Log: MFC r367253: Document how to use sudo for SU_CMD It is rather common for the ports users to replace su(1) with sudo(8) within the SU_CMD va

svn commit: r367707 - stable/12/share/man/man7

2020-11-15 Thread Mateusz Piotrowski
Author: 0mp (doc,ports committer) Date: Sun Nov 15 12:28:57 2020 New Revision: 367707 URL: https://svnweb.freebsd.org/changeset/base/367707 Log: MFC r367253: Document how to use sudo for SU_CMD It is rather common for the ports users to replace su(1) with sudo(8) within the SU_CMD va

svn commit: r367706 - stable/12/sys/net

2020-11-15 Thread Kristof Provost
Author: kp Date: Sun Nov 15 11:56:16 2020 New Revision: 367706 URL: https://svnweb.freebsd.org/changeset/base/367706 Log: MFC r366500: bridge: call member interface ioctl() without NET_EPOCH We're not allowed to hold NET_EPOCH while sleeping, so when we call ioctl() handlers for memb

svn commit: r367705 - stable/12/sys/net

2020-11-15 Thread Kristof Provost
Author: kp Date: Sun Nov 15 11:46:44 2020 New Revision: 367705 URL: https://svnweb.freebsd.org/changeset/base/367705 Log: bridge: epoch-ification Undo the revert (r363568). This commit still violates epoch rules by sleeping within NET_EPOCH. That will be resolved in the following commit.

svn commit: r367704 - in stable: 11/contrib/llvm-project/lld/ELF 12/contrib/llvm-project/lld/ELF

2020-11-15 Thread Dimitry Andric
Author: dim Date: Sun Nov 15 11:28:02 2020 New Revision: 367704 URL: https://svnweb.freebsd.org/changeset/base/367704 Log: MFC r367623: Merge commit 8df4e6094 from llvm git (by Fangrui Song): [ELF] Don't consider SHF_ALLOC ".debug*" sections debug sections Fixes PR48071

svn commit: r367704 - in stable: 11/contrib/llvm-project/lld/ELF 12/contrib/llvm-project/lld/ELF

2020-11-15 Thread Dimitry Andric
Author: dim Date: Sun Nov 15 11:28:02 2020 New Revision: 367704 URL: https://svnweb.freebsd.org/changeset/base/367704 Log: MFC r367623: Merge commit 8df4e6094 from llvm git (by Fangrui Song): [ELF] Don't consider SHF_ALLOC ".debug*" sections debug sections Fixes PR48071

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Igor Kolesnik
> Modified: head/lib/libutil/getlocalbase.c > == > --- head/lib/libutil/getlocalbase.c Sun Nov 15 01:54:44 2020 > (r367700) > +++ head/lib/libutil/getlocalbase.c Sun Nov 15 07:48:52 2020 > (r367701) > @