Re: svn commit: r357312 - head/sys/kern

On Thu, Jan 30, 2020 at 08:05:05PM +, Mateusz Guzik wrote: > New Revision: 357312 > URL: https://svnweb.freebsd.org/changeset/base/357312 > > Log: > Remove duplicated empty lines from kern/*.c Thank you. Every once in a while when I want/need to hack on src code base, these superfluous new

Re: svn commit: r357314 - in head/sys: conf kern sys vm

In message <202001310049.00v0np1a077...@repo.freebsd.org>, Jeff Roberson writes : > Author: jeff > Date: Fri Jan 31 00:49:51 2020 > New Revision: 357314 > URL: https://svnweb.freebsd.org/changeset/base/357314 > > Log: > Implement a safe memory reclamation feature that is tightly coupled with UM

svn commit: r357318 - head/sys/netinet6

Author: np Date: Fri Jan 31 02:23:48 2020 New Revision: 357318 URL: https://svnweb.freebsd.org/changeset/base/357318 Log: Fix NOINET builds. Modified: head/sys/netinet6/udp6_usrreq.c Modified: head/sys/netinet6/udp6_usrreq.c ===

svn commit: r357317 - in head/tools/uma: . smrstress

Author: jeff Date: Fri Jan 31 02:18:56 2020 New Revision: 357317 URL: https://svnweb.freebsd.org/changeset/base/357317 Log: Implement a simple UMA SMR stress testing tool. Added: head/tools/uma/ head/tools/uma/smrstress/ head/tools/uma/smrstress/Makefile (contents, props changed) head

svn commit: r357316 - in head/sys: kern sys

Author: jeff Date: Fri Jan 31 02:08:09 2020 New Revision: 357316 URL: https://svnweb.freebsd.org/changeset/base/357316 Log: Don't use "All rights reserved" in new copyrights. Requested by: rgrimes Modified: head/sys/kern/subr_smr.c head/sys/sys/_smr.h head/sys/sys/smr.h Modified: he

svn commit: r357315 - head/sys/vm

Author: jeff Date: Fri Jan 31 02:03:22 2020 New Revision: 357315 URL: https://svnweb.freebsd.org/changeset/base/357315 Log: Fix LINT build with MEMGUARD. Modified: head/sys/vm/uma_core.c Modified: head/sys/vm/uma_core.c

Re: svn commit: r357138 - head/bin/pwait

On 26-01-2020 11:49, Pawel Jakub Dawidek wrote: Author: pjd Date: Sun Jan 26 10:49:24 2020 New Revision: 357138 URL: https://svnweb.freebsd.org/changeset/base/357138 Log: - Be consistent with using sysexits(3) codes. - Turn fprintf()+exit() into errx(). Sponsored by: Fudo Security

svn commit: r357313 - head/sys/riscv/riscv

Author: jhb Date: Thu Jan 30 22:19:48 2020 New Revision: 357313 URL: https://svnweb.freebsd.org/changeset/base/357313 Log: Trim duplicate CSR swaps from user exceptions. The stack pointer is swapped with the sscratch CSR just before the jump to cpu_exception_handler_user where the first i

Re: svn commit: r357293 - head/sys/net

On Thu, 30 Jan 2020, Hans Petter Selasky wrote: On 2020-01-30 21:56, Gleb Smirnoff wrote: On Thu, Jan 30, 2020 at 12:04:03PM +, Hans Petter Selasky wrote: H> Author: hselasky H> Date: Thu Jan 30 12:04:02 2020 H> New Revision: 357293 H> URL: https://svnweb.freebsd.org/changeset/base/357293 H

Re: svn commit: r357293 - head/sys/net

On 2020-01-30 21:56, Gleb Smirnoff wrote: On Thu, Jan 30, 2020 at 12:04:03PM +, Hans Petter Selasky wrote: H> Author: hselasky H> Date: Thu Jan 30 12:04:02 2020 H> New Revision: 357293 H> URL: https://svnweb.freebsd.org/changeset/base/357293 H> H> Log: H> Widen EPOCH(9) usage in netisr. H>

Re: svn commit: r357293 - head/sys/net

On Thu, 30 Jan 2020, Gleb Smirnoff wrote: On Thu, Jan 30, 2020 at 12:04:03PM +, Hans Petter Selasky wrote: H> Author: hselasky H> Date: Thu Jan 30 12:04:02 2020 H> New Revision: 357293 H> URL: https://svnweb.freebsd.org/changeset/base/357293 H> H> Log: H> Widen EPOCH(9) usage in netisr. H>

Re: svn commit: r357291 - in head/sys/dev: bwi bwn ipw iwi iwm iwn malo mwl ral rtwn/pci wi wpi wtap

On Thu, Jan 30, 2020 at 10:51:23AM -1000, Jeff Roberson wrote: J> On Thu, 30 Jan 2020, Gleb Smirnoff wrote: J> J> > On Thu, Jan 30, 2020 at 10:28:01AM +, Hans Petter Selasky wrote: J> > H> Author: hselasky J> > H> Date: Thu Jan 30 10:28:01 2020 J> > H> New Revision: 357291 J> > H> URL: https:/

Re: svn commit: r357293 - head/sys/net

On Thu, Jan 30, 2020 at 12:04:03PM +, Hans Petter Selasky wrote: H> Author: hselasky H> Date: Thu Jan 30 12:04:02 2020 H> New Revision: 357293 H> URL: https://svnweb.freebsd.org/changeset/base/357293 H> H> Log: H> Widen EPOCH(9) usage in netisr. H> H> Software interrupt handlers are all

Re: svn commit: r357291 - in head/sys/dev: bwi bwn ipw iwi iwm iwn malo mwl ral rtwn/pci wi wpi wtap

On Thu, 30 Jan 2020, Gleb Smirnoff wrote: On Thu, Jan 30, 2020 at 10:28:01AM +, Hans Petter Selasky wrote: H> Author: hselasky H> Date: Thu Jan 30 10:28:01 2020 H> New Revision: 357291 H> URL: https://svnweb.freebsd.org/changeset/base/357291 H> H> Log: H> Widen EPOCH(9) usage in PCI WLAN d

Re: svn commit: r357291 - in head/sys/dev: bwi bwn ipw iwi iwm iwn malo mwl ral rtwn/pci wi wpi wtap

On Thu, Jan 30, 2020 at 10:28:01AM +, Hans Petter Selasky wrote: H> Author: hselasky H> Date: Thu Jan 30 10:28:01 2020 H> New Revision: 357291 H> URL: https://svnweb.freebsd.org/changeset/base/357291 H> H> Log: H> Widen EPOCH(9) usage in PCI WLAN drivers. H> H> Make sure all occurrences

Re: svn commit: r357291 - in head/sys/dev: bwi bwn ipw iwi iwm iwn malo mwl ral rtwn/pci wi wpi wtap

On Thu, 30 Jan 2020, Hans Petter Selasky wrote: Author: hselasky Date: Thu Jan 30 10:28:01 2020 New Revision: 357291 URL: https://svnweb.freebsd.org/changeset/base/357291 Log: Widen EPOCH(9) usage in PCI WLAN drivers. Make sure all occurrences of ieee80211_input_xxx() in sys/dev are covered

Re: svn commit: r357291 - in head/sys/dev: bwi bwn ipw iwi iwm iwn malo mwl ral rtwn/pci wi wpi wtap

On Thu, Jan 30, 2020 at 10:28:01AM +, Hans Petter Selasky wrote: H> Author: hselasky H> Date: Thu Jan 30 10:28:01 2020 H> New Revision: 357291 H> URL: https://svnweb.freebsd.org/changeset/base/357291 H> H> Log: H> Widen EPOCH(9) usage in PCI WLAN drivers. H> H> Make sure all occurrences

svn commit: r357312 - head/sys/kern

Author: mjg Date: Thu Jan 30 20:05:05 2020 New Revision: 357312 URL: https://svnweb.freebsd.org/changeset/base/357312 Log: Remove duplicated empty lines from kern/*.c No functional changes. Modified: head/sys/kern/imgact_binmisc.c head/sys/kern/imgact_elf.c head/sys/kern/init_main.c

svn commit: r357311 - head/sys/kern

Author: mjg Date: Thu Jan 30 20:02:14 2020 New Revision: 357311 URL: https://svnweb.freebsd.org/changeset/base/357311 Log: Tidy up 2 comments in smp_rendezvous_cpus. Modified: head/sys/kern/subr_smp.c Modified: head/sys/kern/subr_smp.c

svn commit: r357309 - head/sys/amd64/amd64

Author: mjg Date: Thu Jan 30 19:56:22 2020 New Revision: 357309 URL: https://svnweb.freebsd.org/changeset/base/357309 Log: amd64: speed up failing case for memcmp Instead of branching on up to 8 bytes, drop the size to 4. Assorted clean ups while here. Validated with glibc test su

svn commit: r357310 - head/lib/libc/amd64/string

Author: mjg Date: Thu Jan 30 19:57:05 2020 New Revision: 357310 URL: https://svnweb.freebsd.org/changeset/base/357310 Log: amd64: sync up libc memcmp with the kernel version (r357309) Modified: head/lib/libc/amd64/string/memcmp.S Modified: head/lib/libc/amd64/string/memcmp.S

svn commit: r357308 - head/sys/kern

Author: mjg Date: Thu Jan 30 19:38:51 2020 New Revision: 357308 URL: https://svnweb.freebsd.org/changeset/base/357308 Log: Assert that smp_rendezvous_cpus is called with interrupts enabled. Modified: head/sys/kern/subr_smp.c Modified: head/sys/kern/subr_smp.c

svn commit: r357307 - head/sys/kern

Author: mjg Date: Thu Jan 30 19:38:12 2020 New Revision: 357307 URL: https://svnweb.freebsd.org/changeset/base/357307 Log: vfs: keep the mount point referenced across sys_quotactl Otherwise we risk running into use-after-free. In particular this codepath ends up dropping all protection

svn commit: r357306 - head/sys/fs/nullfs

Author: kib Date: Thu Jan 30 19:34:37 2020 New Revision: 357306 URL: https://svnweb.freebsd.org/changeset/base/357306 Log: Fix a bug in r357199. Around a generic call to null_nodeget(), there is nothing that would prevent the unmount of the nullfs mp until we process to the insmntque1()

svn commit: r357305 - in head/sys/riscv: include riscv

Author: jhb Date: Thu Jan 30 19:15:27 2020 New Revision: 357305 URL: https://svnweb.freebsd.org/changeset/base/357305 Log: Remove unused fields from struct pcb. cpu_switch/throw() and savectx() do not save or restore any values in these fields which mostly held non-callee-save registers.

Re: svn commit: r357288 - head/sys/dev/usb/wlan

On Thu, 2020-01-30 at 09:41 +, Hans Petter Selasky wrote: > Author: hselasky > Date: Thu Jan 30 09:41:48 2020 > New Revision: 357288 > URL: https://svnweb.freebsd.org/changeset/base/357288 > > Log: > Widen EPOCH(9) usage in USB WLAN drivers. > > This patch should unbreak the USB WLAN dr

svn commit: r357304 - head/sys/arm64/arm64

Author: andrew Date: Thu Jan 30 18:49:19 2020 New Revision: 357304 URL: https://svnweb.freebsd.org/changeset/base/357304 Log: Shift the ITS processor ID after reading it. When using the processor ID value we mask off the low and high bits that should be zero. Unfortunatly we don't shift t

svn commit: r357303 - head/usr.sbin/makefs/msdos

Author: brooks Date: Thu Jan 30 18:34:08 2020 New Revision: 357303 URL: https://svnweb.freebsd.org/changeset/base/357303 Log: Fix an indentation bug in r357169. Modified: head/usr.sbin/makefs/msdos/msdosfs_denode.c Modified: head/usr.sbin/makefs/msdos/msdosfs_denode.c ===

svn commit: r357302 - head/sys/kern

Author: jhb Date: Thu Jan 30 18:28:02 2020 New Revision: 357302 URL: https://svnweb.freebsd.org/changeset/base/357302 Log: Fix use of an uninitialized variable. ctx (and thus ctx.flags) is stack garbage at the start of this function, so initialize ctx.flags to an explicit value instead of

svn commit: r357300 - head/sys/dev/aic7xxx

Author: cem Date: Thu Jan 30 18:12:24 2020 New Revision: 357300 URL: https://svnweb.freebsd.org/changeset/base/357300 Log: aic7xxx(4): Fix unintended sign extension in ahd_inq() ahd_inb() returns type uint8_t. The shift left by untyped 24 implicitly promotes the result to type (signed) i

svn commit: r357301 - head/contrib/apr/random/unix

Author: cem Date: Thu Jan 30 18:12:41 2020 New Revision: 357301 URL: https://svnweb.freebsd.org/changeset/base/357301 Log: contrib/apr: Rip out bogus [CS]PRNG implementation This construction used some relatively slow design involving SHA2; even if it were fed real entropy (unclear; exter

svn commit: r357299 - head/contrib/apr/strings

Author: cem Date: Thu Jan 30 17:50:51 2020 New Revision: 357299 URL: https://svnweb.freebsd.org/changeset/base/357299 Log: contrib/apr: Remove scope leak UB In apr_vformatter, the variable buf was declared inside a limited scope region, but a pointer to it is leaked outside of that region

svn commit: r357298 - head/lib/libusb

Author: hselasky Date: Thu Jan 30 17:30:04 2020 New Revision: 357298 URL: https://svnweb.freebsd.org/changeset/base/357298 Log: Add missing mutex unlock in failure case. Differential Revision:https://reviews.freebsd.org/D23430 Submitted by: cem Reported by: Coverity Coverity

svn commit: r357297 - stable/12/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys

Author: mav Date: Thu Jan 30 16:38:40 2020 New Revision: 357297 URL: https://svnweb.freebsd.org/changeset/base/357297 Log: MFC r356707: Map ECKSUM and EFRAGS from ZFS onto real errnos. Make it less confusing when, for example, stat sets errno to 122 because a checksum failed in ZFS:

Re: svn commit: r357233 - head/sys/net

On Tue, Jan 28, 2020 at 10:44:25PM +, Kristof Provost wrote: K> Author: kp K> Date: Tue Jan 28 22:44:24 2020 K> New Revision: 357233 K> URL: https://svnweb.freebsd.org/changeset/base/357233 K> K> Log: K> epair: Do not abuse params to register the second interface K> K> if_epair used the

svn commit: r357296 - in stable/12: cddl/lib/libdtrace contrib/libxo/tests/gettext contrib/libxo/tests/gettext/po/pig_latin contrib/llvm-project/libcxx/include contrib/openbsm/libbsm contrib/openbs...

Author: mav Date: Thu Jan 30 16:11:19 2020 New Revision: 357296 URL: https://svnweb.freebsd.org/changeset/base/357296 Log: MFC r343111,343113-343115 (by mckusick): Create new EINTEGRITY error with message "Integrity check failed". An integrity check such as a check-hash or a cross-correla

svn commit: r357295 - stable/12/sys/arm64/arm64

Author: markj Date: Thu Jan 30 15:00:41 2020 New Revision: 357295 URL: https://svnweb.freebsd.org/changeset/base/357295 Log: MFC r357048: arm64: Don't enable interrupts in init_secondary(). Modified: stable/12/sys/arm64/arm64/mp_machdep.c Directory Properties: stable/12/ (props changed)

Re: svn commit: r357203 - head/sys/compat/linux

On Tue, 28 Jan 2020 at 18:55, Gleb Smirnoff wrote: > > On Tue, Jan 28, 2020 at 01:57:25PM +, Edward Tomasz Napierala wrote: > E> Author: trasz > E> Date: Tue Jan 28 13:57:24 2020 > E> New Revision: 357203 > E> URL: https://svnweb.freebsd.org/changeset/base/357203 > E> > E> Log: > E> Add TCP_

svn commit: r357294 - in head/sys/dev/mlx5: . mlx5_core mlx5_en

Author: hselasky Date: Thu Jan 30 12:35:13 2020 New Revision: 357294 URL: https://svnweb.freebsd.org/changeset/base/357294 Log: Widen EPOCH(9) usage in mlx5en(4). Make completion event path mostly lockless using EPOCH(9). Implement a mechanism using EPOCH(9) which allows us to make t

svn commit: r357293 - head/sys/net

Author: hselasky Date: Thu Jan 30 12:04:02 2020 New Revision: 357293 URL: https://svnweb.freebsd.org/changeset/base/357293 Log: Widen EPOCH(9) usage in netisr. Software interrupt handlers are allowed to sleep. In swi_net() there is a read lock behind NETISR_RLOCK() which in turn ends up c

svn commit: r357292 - head/sys/dev/acpi_support

Author: philip Date: Thu Jan 30 10:40:38 2020 New Revision: 357292 URL: https://svnweb.freebsd.org/changeset/base/357292 Log: acpi_ibm: add support for ThinkPad PrivacyGuard ThinkPad PrivacyGuard is a built-in toggleable privacy filter that restricts viewing angles when on. It is an avail

svn commit: r357291 - in head/sys/dev: bwi bwn ipw iwi iwm iwn malo mwl ral rtwn/pci wi wpi wtap

Author: hselasky Date: Thu Jan 30 10:28:01 2020 New Revision: 357291 URL: https://svnweb.freebsd.org/changeset/base/357291 Log: Widen EPOCH(9) usage in PCI WLAN drivers. Make sure all occurrences of ieee80211_input_xxx() in sys/dev are covered by a network epoch section. Do not depend on

svn commit: r357289 - stable/12/usr.sbin/periodic/etc/security

Author: kp Date: Thu Jan 30 09:56:56 2020 New Revision: 357289 URL: https://svnweb.freebsd.org/changeset/base/357289 Log: MFC r356816: Fix pfdenied not returning any results When _a is empty we end up with an invalid invocation of pfctl, and no output. We must add quotes to make it c

svn commit: r357290 - stable/11/etc/periodic/security

Author: kp Date: Thu Jan 30 09:56:57 2020 New Revision: 357290 URL: https://svnweb.freebsd.org/changeset/base/357290 Log: MFC r356816: Fix pfdenied not returning any results When _a is empty we end up with an invalid invocation of pfctl, and no output. We must add quotes to make it c

svn commit: r357288 - head/sys/dev/usb/wlan

Author: hselasky Date: Thu Jan 30 09:41:48 2020 New Revision: 357288 URL: https://svnweb.freebsd.org/changeset/base/357288 Log: Widen EPOCH(9) usage in USB WLAN drivers. This patch should unbreak the USB WLAN drivers after r357004. Pointy hat: glebius@ Sponsored by: Mellanox Techno

svn commit: r357287 - in head/sys: fs/nullfs sys

Author: mjg Date: Thu Jan 30 08:56:22 2020 New Revision: 357287 URL: https://svnweb.freebsd.org/changeset/base/357287 Log: vfs: remove the never set VDESC_NOMAP_VPP flag Modified: head/sys/fs/nullfs/null_vnops.c head/sys/sys/vnode.h Modified: head/sys/fs/nullfs/null_vnops.c ===