svn commit: r198358 - head/sys/dev/ppbus

2009-10-21 Thread Christian Brueffer
Author: brueffer Date: Thu Oct 22 06:51:29 2009 New Revision: 198358 URL: http://svn.freebsd.org/changeset/base/198358 Log: Check pointer for NULL before dereferencing it, not after. PR: 138387, 138388 Submitted by: Patroklos Argyroudis MFC after:1 week Modified: head/

svn commit: r198357 - head/sys/net

2009-10-21 Thread Christian Brueffer
Author: brueffer Date: Thu Oct 22 06:17:04 2009 New Revision: 198357 URL: http://svn.freebsd.org/changeset/base/198357 Log: Check pointer for NULL before dereferencing it, not after. PR: 138390 Submitted by: Patroklos Argyroudis MFC after:1 week Modified: head/sys/net/

svn commit: r198356 - head/sys/cam/scsi

2009-10-21 Thread Christian Brueffer
Author: brueffer Date: Thu Oct 22 06:13:07 2009 New Revision: 198356 URL: http://svn.freebsd.org/changeset/base/198356 Log: Fix a memory leak in an error case. PR: 138376 Submitted by: Patroklos Argyroudis Reviewed by: scottl MFC after:1 week Modified: head/sys/cam/

svn commit: r198353 - head/sys/net

2009-10-21 Thread Qing Li
Author: qingli Date: Thu Oct 22 00:32:01 2009 New Revision: 198353 URL: http://svn.freebsd.org/changeset/base/198353 Log: Verify "smp_started" is true before calling sched_bind() and sched_unbind(). Reviewed by: kmacy MFC after:3 days Modified: head/sys/net/flowtable.c Modified

svn commit: r198352 - head/sbin/dhclient

2009-10-21 Thread Philip Paeps
Author: philip Date: Wed Oct 21 23:50:35 2009 New Revision: 198352 URL: http://svn.freebsd.org/changeset/base/198352 Log: Make dhclient use bootpc (68) as the source port for unicast DHCPREQUEST packets instead of allowing the protocol stack to pick a random source port. This fixes the be

Re: svn commit: r198335 - head/share/mk

2009-10-21 Thread Ruslan Ermilov
On Wed, Oct 21, 2009 at 05:07:46PM +, Roman Divacky wrote: > Author: rdivacky > Date: Wed Oct 21 17:07:46 2009 > New Revision: 198335 > URL: http://svn.freebsd.org/changeset/base/198335 > > Log: > Set CSTD in all cases except when CC=icc and NO_WARNS is set. This > way we can set desired C

svn commit: r198351 - head/share/zoneinfo

2009-10-21 Thread Edwin Groothuis
Author: edwin Date: Wed Oct 21 20:59:12 2009 New Revision: 198351 URL: http://svn.freebsd.org/changeset/base/198351 Log: After the installation of the /usr/share/zoneinfo, run tzsetup if /var/db/zoneinfo exists. MFC after:1 week Modified: head/share/zoneinfo/Makefile Modified: hea

svn commit: r198350 - head/usr.sbin/tzsetup

2009-10-21 Thread Edwin Groothuis
Author: edwin Date: Wed Oct 21 20:55:04 2009 New Revision: 198350 URL: http://svn.freebsd.org/changeset/base/198350 Log: - Add support for chrooted installs. - Add examples to the man-page. MFC after:1 week Modified: head/usr.sbin/tzsetup/tzsetup.8 head/usr.sbin/tzsetup/tzsetup.c

svn commit: r198348 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/usb/storage dev/xen/xenpci

2009-10-21 Thread Andrew Thompson
Author: thompsa Date: Wed Oct 21 19:48:27 2009 New Revision: 198348 URL: http://svn.freebsd.org/changeset/base/198348 Log: MFC r198307 Change from CAM_TID_INVALID to CAM_SEL_TIMEOUT error code when the usb device has been yanked, this works around a cam recounting bug when CAM_DEV_UN

svn commit: r198347 - head

2009-10-21 Thread Ruslan Ermilov
Author: ru Date: Wed Oct 21 19:39:34 2009 New Revision: 198347 URL: http://svn.freebsd.org/changeset/base/198347 Log: Move sed(1) from cross-tools to bootstrap-tools. Modified: head/Makefile.inc1 Modified: head/Makefile.inc1 ===

Re: svn commit: r198344 - head/contrib/gcc/config/i386

2009-10-21 Thread Roman Divacky
On Wed, Oct 21, 2009 at 07:26:13PM +, John Baldwin wrote: > Author: jhb > Date: Wed Oct 21 19:26:12 2009 > New Revision: 198344 > URL: http://svn.freebsd.org/changeset/base/198344 > > Log: > Change gcc to assume a default machine architecture of 486 instead of 386 > on "i386". Doing it in

svn commit: r198346 - head/sys/net80211

2009-10-21 Thread Rui Paulo
Author: rpaulo Date: Wed Oct 21 19:31:23 2009 New Revision: 198346 URL: http://svn.freebsd.org/changeset/base/198346 Log: Don't call the newstate callback as that's dangerous. Rely no ENETRESET to DTRT. MFC after:3 days Modified: head/sys/net80211/ieee80211_mesh.c Modified: head/s

svn commit: r198344 - head/contrib/gcc/config/i386

2009-10-21 Thread John Baldwin
Author: jhb Date: Wed Oct 21 19:26:12 2009 New Revision: 198344 URL: http://svn.freebsd.org/changeset/base/198344 Log: Change gcc to assume a default machine architecture of 486 instead of 386 on "i386". Doing it in the compiler is deemed to be less fragile then attempting to provide a defa

Re: svn commit: r198339 - head/lib/libfetch

2009-10-21 Thread Fabien THOMAS
oops sorry... is it possible to change it? Changing revision properties is prohibited Le 21 oct. 2009 à 20:30, Roman Divacky a écrit : On Wed, Oct 21, 2009 at 06:29:27PM +, Fabien Thomas wrote: Author: fabient Date: Wed Oct 21 18:29:26 2009 New Revision: 198339 URL: http://svn.freebsd.org

svn commit: r198343 - head/sys/dev/hwpmc

2009-10-21 Thread Fabien Thomas
Author: fabient Date: Wed Oct 21 18:46:36 2009 New Revision: 198343 URL: http://svn.freebsd.org/changeset/base/198343 Log: Handle the case where there is only one PMC in the system. Approved by: jkoshy (mentor) MFC after: 3 days Modified: head/sys/dev/hwpmc/hwpmc_mod.c Modified: head/

svn commit: r198342 - head/sys/arm/mv

2009-10-21 Thread Marcel Moolenaar
Author: marcel Date: Wed Oct 21 18:44:00 2009 New Revision: 198342 URL: http://svn.freebsd.org/changeset/base/198342 Log: Review previous change. It has no relation to the I-cache coherency changes and thus unintentional. Spotted by: rdivacky@ Modified: head/sys/arm/mv/mv_machdep.c Mo

Re: svn commit: r198341 - in head/sys: amd64/amd64 arm/arm arm/mv i386/i386 i386/xen ia64/ia64 kern mips/mips powerpc/aim powerpc/booke powerpc/include powerpc/powerpc sparc64/sparc64 sun4v/sun4v vm

2009-10-21 Thread Roman Divacky
> > Modified: head/sys/arm/mv/mv_machdep.c > == > --- head/sys/arm/mv/mv_machdep.c Wed Oct 21 18:31:54 2009 > (r198340) > +++ head/sys/arm/mv/mv_machdep.c Wed Oct 21 18:38:02 2009 > (r198341) > @@

svn commit: r198341 - in head/sys: amd64/amd64 arm/arm arm/mv i386/i386 i386/xen ia64/ia64 kern mips/mips powerpc/aim powerpc/booke powerpc/include powerpc/powerpc sparc64/sparc64 sun4v/sun4v vm

2009-10-21 Thread Marcel Moolenaar
Author: marcel Date: Wed Oct 21 18:38:02 2009 New Revision: 198341 URL: http://svn.freebsd.org/changeset/base/198341 Log: o Introduce vm_sync_icache() for making the I-cache coherent with the memory or D-cache, depending on the semantics of the platform. vm_sync_icache() is basical

svn commit: r198340 - head/sbin/sysctl

2009-10-21 Thread Ed Schouten
Author: ed Date: Wed Oct 21 18:31:54 2009 New Revision: 198340 URL: http://svn.freebsd.org/changeset/base/198340 Log: Make input parsing in Farhenheit actually work. Don't clobber *p with '\0' when testing whether it has the value of 'F'. Just use the semantics of strtof() properly. If it

Re: svn commit: r198339 - head/lib/libfetch

2009-10-21 Thread Roman Divacky
On Wed, Oct 21, 2009 at 06:29:27PM +, Fabien Thomas wrote: > Author: fabient > Date: Wed Oct 21 18:29:26 2009 > New Revision: 198339 > URL: http://svn.freebsd.org/changeset/base/198339 > > Log: > PR: 139751 > Approved by: des > Obtained from: Xavier Heiny > MFC after: 3 weeks and whe

svn commit: r198339 - head/lib/libfetch

2009-10-21 Thread Fabien Thomas
Author: fabient Date: Wed Oct 21 18:29:26 2009 New Revision: 198339 URL: http://svn.freebsd.org/changeset/base/198339 Log: PR: 139751 Approved by: des Obtained from: Xavier Heiny MFC after: 3 weeks Modified: head/lib/libfetch/common.c Modified: head/lib/libfetch/common.c =

svn commit: r198338 - head/sys/ia64/include

2009-10-21 Thread Marcel Moolenaar
Author: marcel Date: Wed Oct 21 18:09:48 2009 New Revision: 198338 URL: http://svn.freebsd.org/changeset/base/198338 Log: o Align function on a 32-byte boundary so that the core's front-end can deliver 2 bundles per cycle to the back-end. o Mark syscall stubs with a special unwind AB

svn commit: r198337 - in stable/8/release: . doc doc/en_US.ISO8859-1/hardware scripts

2009-10-21 Thread Ken Smith
Author: kensmith Date: Wed Oct 21 17:18:48 2009 New Revision: 198337 URL: http://svn.freebsd.org/changeset/base/198337 Log: MFC r198287: Update package list for 8.0-REL. Reviewed by: re@, portmgr@ Approved by: re (implicit) Modified: stable/8/release/ (props changed) stable/8

svn commit: r198335 - head/share/mk

2009-10-21 Thread Roman Divacky
Author: rdivacky Date: Wed Oct 21 17:07:46 2009 New Revision: 198335 URL: http://svn.freebsd.org/changeset/base/198335 Log: Set CSTD in all cases except when CC=icc and NO_WARNS is set. This way we can set desired C standard even for cross tools etc. Tested by:make universe Approved

Re: svn commit: r198334 - in stable/7/sys: . contrib/pf dev/ata

2009-10-21 Thread Dmitry Morozovsky
On Wed, 21 Oct 2009, Alexander Motin wrote: AM> Author: mav AM> Date: Wed Oct 21 16:12:09 2009 AM> New Revision: 198334 AM> URL: http://svn.freebsd.org/changeset/base/198334 AM> AM> Log: AM> MFC rev. 178375: AM> Add HW level support for the Adaptec 1420SA controller. Thank you! -- Sincere

svn commit: r198334 - in stable/7/sys: . contrib/pf dev/ata

2009-10-21 Thread Alexander Motin
Author: mav Date: Wed Oct 21 16:12:09 2009 New Revision: 198334 URL: http://svn.freebsd.org/changeset/base/198334 Log: MFC rev. 178375: Add HW level support for the Adaptec 1420SA controller. Modified: stable/7/sys/ (props changed) stable/7/sys/contrib/pf/ (props changed) stable/7/s

svn commit: r198333 - head/sys/cam

2009-10-21 Thread Alexander Motin
Author: mav Date: Wed Oct 21 15:57:16 2009 New Revision: 198333 URL: http://svn.freebsd.org/changeset/base/198333 Log: MFp4: Do not search for bus when it is not needed, Modified: head/sys/cam/cam_xpt.c Modified: head/sys/cam/cam_xpt.c ==

svn commit: r198332 - head/sys/dev/drm

2009-10-21 Thread Christian Brueffer
Author: brueffer Date: Wed Oct 21 15:54:45 2009 New Revision: 198332 URL: http://svn.freebsd.org/changeset/base/198332 Log: Check pointer for NULL before dereferencing it, not after. PR: 138383 Submitted by: Patroklos Argyroudis Reviewed by: rnoland MFC after:1 week M

svn commit: r198331 - in head/sys/cam: . ata

2009-10-21 Thread Alexander Motin
Author: mav Date: Wed Oct 21 15:27:48 2009 New Revision: 198331 URL: http://svn.freebsd.org/changeset/base/198331 Log: MFp4: Separate CAM_DEV_IDENTIFY_DATA_VALID flag from CAM_DEV_INQUIRY_DATA_VALID. Add workaround for very old devices without support for mode setting. Add some PATA bus sc

svn commit: r198330 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci vm

2009-10-21 Thread Konstantin Belousov
Author: kib Date: Wed Oct 21 15:07:34 2009 New Revision: 198330 URL: http://svn.freebsd.org/changeset/base/198330 Log: MFC r198201: Remove spurious call to priv_check(PRIV_VM_SWAP_NOQUOTA). Call priv_check(PRIV_VM_SWAP_NORLIMIT) only when per-uid limit is actually exceed. Approved by:

svn commit: r198329 - head/sys/dev/ips

2009-10-21 Thread Christian Brueffer
Author: brueffer Date: Wed Oct 21 15:04:50 2009 New Revision: 198329 URL: http://svn.freebsd.org/changeset/base/198329 Log: Check pointer for NULL before dereferencing it, not after. PR: 138384 Submitted by: Patroklos Argyroudis MFC after:1 week Modified: head/sys/dev/

Re: svn commit: r198316 - head/sbin/tunefs

2009-10-21 Thread Bruce Evans
On Thu, 22 Oct 2009, Bruce Evans wrote: ... NetBSD's 2005 version says: % BUGS % This program should work on mounted and active file systems. Because the % super-block is not kept in the buffer cache, the changes will only take % effect if the program is run on unmounted file

svn commit: r198328 - head/sys/cam/ata

2009-10-21 Thread Alexander Motin
Author: mav Date: Wed Oct 21 14:20:55 2009 New Revision: 198328 URL: http://svn.freebsd.org/changeset/base/198328 Log: MFp4: Add support for PIO-only devices. Fix maxio values and 256 sectors transactions for 28bits commands. Implement periodic ordered commands insertion, sames as da drive

Re: svn commit: r198316 - head/sbin/tunefs

2009-10-21 Thread Bruce Evans
On Wed, 21 Oct 2009, Remko Lodder wrote: I'll try to implement your suggestions in a patch. Hopefully I'll have that available later today. Can I send it over to you for reviewal so that we are sure to have the correct fix ? It turned out to be mostly a kernel bug (I think -- I most don't use

svn commit: r198327 - head/sys/dev/aic7xxx/aicasm

2009-10-21 Thread Christian Brueffer
Author: brueffer Date: Wed Oct 21 14:09:06 2009 New Revision: 198327 URL: http://svn.freebsd.org/changeset/base/198327 Log: Add a missing free() call. PR: 138379 Submitted by: Patroklos Argyroudis Reviewed by: gibbs MFC after:1 week Modified: head/sys/dev/aic7xxx/ai

svn commit: r198326 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net

2009-10-21 Thread Robert Watson
Author: rwatson Date: Wed Oct 21 14:05:51 2009 New Revision: 198326 URL: http://svn.freebsd.org/changeset/base/198326 Log: Merge r198233 from head to stable/8: Clean up comments, white space, and style in pfil.c (VNET changes not MFC'd) Approved by: re (kib) Modified: stable/

Re: svn commit: r198316 - head/sbin/tunefs

2009-10-21 Thread Bruce Evans
On Wed, 21 Oct 2009, Andriy Gapon wrote: on 21/10/2009 14:28 Ivan Voras said the following: 2009/10/21 Remko Lodder : Log: The tunefs utility does not work on active filesystems. .Sh BUGS -This utility should work on active file systems. +This utility does not work on active file systems.

Re: svn commit: r198316 - head/sbin/tunefs

2009-10-21 Thread Remko Lodder
Hey Bruce, On Oct 21, 2009, at 2:19 PM, Bruce Evans wrote: On Wed, 21 Oct 2009, Remko Lodder wrote: Log: The tunefs utility does not work on active filesystems. Er, that's what it already said. Now it says less. Except, it is implicit in the statement being in the BUGS section that it is

Re: svn commit: r198317 - head/usr.sbin/sysinstall

2009-10-21 Thread John Baldwin
On Wednesday 21 October 2009 7:10:34 am Rink Springer wrote: > Author: rink > Date: Wed Oct 21 11:10:34 2009 > New Revision: 198317 > URL: http://svn.freebsd.org/changeset/base/198317 > > Log: > Introduce 'netDev=ANY' support for scripted (install.cfg) installs, which results in the first ether

svn commit: r198324 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net

2009-10-21 Thread Robert Watson
Author: rwatson Date: Wed Oct 21 13:11:38 2009 New Revision: 198324 URL: http://svn.freebsd.org/changeset/base/198324 Log: Merge r198198 from head to stable/8: Line-wrap pfil.c so that it prints more nicely. Approved by: re (kensmith) Modified: stable/8/sys/ (props changed) s

svn commit: r198322 - in head/sys: cam/ata dev/ahci dev/siis

2009-10-21 Thread Alexander Motin
Author: mav Date: Wed Oct 21 13:00:01 2009 New Revision: 198322 URL: http://svn.freebsd.org/changeset/base/198322 Log: MFp4: Report real max_target = 15. SIM doesn't need to know that target 15 is PMP. It is XPT business. Modified: head/sys/cam/ata/ata_xpt.c head/sys/dev/ahci/ahci.c h

svn commit: r198321 - head/sys/dev/siis

2009-10-21 Thread Alexander Motin
Author: mav Date: Wed Oct 21 12:47:39 2009 New Revision: 198321 URL: http://svn.freebsd.org/changeset/base/198321 Log: MFp4: Freeze device queue on error to permit periph driver to do proper recovery. Modified: head/sys/dev/siis/siis.c Modified: head/sys/dev/siis/siis.c ===

svn commit: r198320 - in head/sys: conf dev/bce

2009-10-21 Thread Stanislav Sedov
Author: stas Date: Wed Oct 21 12:47:09 2009 New Revision: 198320 URL: http://svn.freebsd.org/changeset/base/198320 Log: - Introduce new option BCE_JUMBO_HDRSPLIT that allows user to enable header splitting in bce(4) instead of (ab)using ZERO_COPY_SOCKETS that was not propagated into if_b

svn commit: r198319 - head/sys/dev/ahci

2009-10-21 Thread Alexander Motin
Author: mav Date: Wed Oct 21 12:42:25 2009 New Revision: 198319 URL: http://svn.freebsd.org/changeset/base/198319 Log: MFp4: On error, freeze device queue, to allow periph driver to do proper recovery. Freeze SIM queue only in some cases, when it is needed to protect SIM. Implement bett

Re: svn commit: r198316 - head/sbin/tunefs

2009-10-21 Thread Bruce Evans
On Wed, 21 Oct 2009, Remko Lodder wrote: Log: The tunefs utility does not work on active filesystems. Er, that's what it already said. Now it says less. Except, it is implicit in the statement being in the BUGS section that it is a bug for tunefs to not work on active file systems, just lik

Re: svn commit: r198316 - head/sbin/tunefs

2009-10-21 Thread Andriy Gapon
on 21/10/2009 14:28 Ivan Voras said the following: > 2009/10/21 Remko Lodder : >> Author: remko >> Date: Wed Oct 21 10:15:26 2009 >> New Revision: 198316 >> URL: http://svn.freebsd.org/changeset/base/198316 >> >> Log: >> The tunefs utility does not work on active filesystems. > >> .Sh BUGS >> -T

Re: svn commit: r198316 - head/sbin/tunefs

2009-10-21 Thread Remko Lodder
On Oct 21, 2009, at 1:28 PM, Ivan Voras wrote: 2009/10/21 Remko Lodder : Author: remko Date: Wed Oct 21 10:15:26 2009 New Revision: 198316 URL: http://svn.freebsd.org/changeset/base/198316 Log: The tunefs utility does not work on active filesystems. .Sh BUGS -This utility should work on a

svn commit: r198318 - head/sys/dev/bge

2009-10-21 Thread Stanislav Sedov
Author: stas Date: Wed Oct 21 11:50:18 2009 New Revision: 198318 URL: http://svn.freebsd.org/changeset/base/198318 Log: - On entrance to the rx_eof sync RX rings maps with POSTWRITE flag instead of POSTREAD: the hardware do not touch this memory (CPU updates it). It is already synchroni

Re: svn commit: r198316 - head/sbin/tunefs

2009-10-21 Thread Ivan Voras
2009/10/21 Remko Lodder : > Author: remko > Date: Wed Oct 21 10:15:26 2009 > New Revision: 198316 > URL: http://svn.freebsd.org/changeset/base/198316 > > Log: >  The tunefs utility does not work on active filesystems. >  .Sh BUGS > -This utility should work on active file systems. > +This utility

svn commit: r198317 - head/usr.sbin/sysinstall

2009-10-21 Thread Rink Springer
Author: rink Date: Wed Oct 21 11:10:34 2009 New Revision: 198317 URL: http://svn.freebsd.org/changeset/base/198317 Log: Introduce 'netDev=ANY' support for scripted (install.cfg) installs, which results in the first ethernet interface with physical link being selected. While here, fix a min

svn commit: r198316 - head/sbin/tunefs

2009-10-21 Thread Remko Lodder
Author: remko Date: Wed Oct 21 10:15:26 2009 New Revision: 198316 URL: http://svn.freebsd.org/changeset/base/198316 Log: The tunefs utility does not work on active filesystems. PR: docs/139705 Submitted by: Warren Block Approved by: imp (mentor, implicit) Modified: head/s

svn commit: r198315 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net

2009-10-21 Thread Robert Watson
Author: rwatson Date: Wed Oct 21 09:53:55 2009 New Revision: 198315 URL: http://svn.freebsd.org/changeset/base/198315 Log: Merge r198219 from head to stable/8: Remove unused pfil_flags field in packet_filter_hook. Approved by: re (kib) Modified: stable/8/sys/ (props changed)

svn commit: r198314 - head/etc/defaults

2009-10-21 Thread Christian Brueffer
Author: brueffer Date: Wed Oct 21 09:43:22 2009 New Revision: 198314 URL: http://svn.freebsd.org/changeset/base/198314 Log: Add empty watchdogd_flags. PR: 136620 Submitted by: amdmi3 MFC after:3 days Modified: head/etc/defaults/rc.conf Modified: head/etc/defaults/rc.co

svn commit: r198313 - head/share/man/man4

2009-10-21 Thread Christian Brueffer
Author: brueffer Date: Wed Oct 21 09:22:40 2009 New Revision: 198313 URL: http://svn.freebsd.org/changeset/base/198313 Log: Improve the description of the malofw kernel module installation. PR: 132193 Submitted by: Frank Staals Based on a patch by: gavin MFC after:3 day

Re: svn commit: r198301 - head/sys/netinet

2009-10-21 Thread Robert Watson
On Wed, 21 Oct 2009, Qing Li wrote: I believe this patch will fix your crash. Sounds good, thanks! Robert -- Qing On Wed, Oct 21, 2009 at 12:58 AM, Robert Watson wrote: On Tue, 20 Oct 2009, Qing Li wrote:  In the ARP callout timer expiration function, the current time_second  is com

Re: svn commit: r198301 - head/sys/netinet

2009-10-21 Thread Qing Li
I believe this patch will fix your crash. -- Qing On Wed, Oct 21, 2009 at 12:58 AM, Robert Watson wrote: > On Tue, 20 Oct 2009, Qing Li wrote: > >>  In the ARP callout timer expiration function, the current time_second >>  is compared against the entry expiration time value (that was set based

Re: svn commit: r198301 - head/sys/netinet

2009-10-21 Thread Robert Watson
On Tue, 20 Oct 2009, Qing Li wrote: In the ARP callout timer expiration function, the current time_second is compared against the entry expiration time value (that was set based on time_second) to check if the current time is larger than the set expiration time. Due to the +/- timer granular