Re: svn commit: r184208 - head/sys/dev/uart

2008-10-23 Thread Ed Schouten
* John Baldwin <[EMAIL PROTECTED]> wrote: > Perhaps have tty drivers sleep in detach until the tty is completely gone? > Either that or free the unit number in the tty layer when the tty is > abandoned. Well, I could add a routine to the TTY layer that does that. The reason why the TTY layer is

Re: svn commit: r184193 - in head/sys: arm/conf conf

2008-10-23 Thread Warner Losh
From: Dag-Erling Smørgrav <[EMAIL PROTECTED]> Subject: Re: svn commit: r184193 - in head/sys: arm/conf conf Date: Fri, 24 Oct 2008 03:26:43 +0200 > Warner Losh <[EMAIL PROTECTED]> writes: > > We already have a better mechanism for including config files. We > > should be using that instead of pol

Re: svn commit: r184193 - in head/sys: arm/conf conf

2008-10-23 Thread Dag-Erling Smørgrav
Warner Losh <[EMAIL PROTECTED]> writes: > We already have a better mechanism for including config files. We > should be using that instead of poluting another port with the > DEFAULTS file. Should we even have DEFAULTS files at all? IMHO they just confuse matters by introducing "stealth" options

Re: svn commit: r184194 - in head/sys: conf mips/conf

2008-10-23 Thread Warner Losh
> Add mips/conf/DEFAULTS and populate it with: > machine arm > device mem > device uart_ns8250 > options GEOM_BSD > options GEOM_MBR > > Remove the first three from all kernel configuration files > (sometimes commented-out) and change geom_bs

Re: svn commit: r184193 - in head/sys: arm/conf conf

2008-10-23 Thread Warner Losh
From: Marcel Moolenaar <[EMAIL PROTECTED]> Subject: svn commit: r184193 - in head/sys: arm/conf conf Date: Thu, 23 Oct 2008 01:51:55 + (UTC) > Author: marcel > Date: Thu Oct 23 01:51:55 2008 > New Revision: 184193 > URL: http://svn.freebsd.org/changeset/base/184193 > > Log: > Add arm/conf/D

svn commit: r184217 - head/sys/kern

2008-10-23 Thread David Xu
Author: davidxu Date: Fri Oct 24 01:09:24 2008 New Revision: 184217 URL: http://svn.freebsd.org/changeset/base/184217 Log: Don't rearm callout if the process is exiting, it may leak a callout because callout_drain() only waits for running callout, but not disable it if it is rearmed. Modifi

svn commit: r184216 - head/sys/kern

2008-10-23 Thread David Xu
Author: davidxu Date: Fri Oct 24 01:03:31 2008 New Revision: 184216 URL: http://svn.freebsd.org/changeset/base/184216 Log: partly revert revision 184199, because TDF_NEEDSIGCHK is persitent when thread is in kernel mode, it can cause dead loop, now unlock process lock after acquired sleep qu

svn commit: r184215 - head/sys/kern

2008-10-23 Thread John Baldwin
Author: jhb Date: Thu Oct 23 21:50:16 2008 New Revision: 184215 URL: http://svn.freebsd.org/changeset/base/184215 Log: Whitespace fix. Modified: head/sys/kern/vfs_syscalls.c Modified: head/sys/kern/vfs_syscalls.c ==

svn commit: r184214 - in head/sys: contrib/altq/altq dev/hwpmc dev/ray dev/sr fs/hpfs fs/ntfs fs/udf fs/unionfs kern net netgraph netgraph/bluetooth/socket netgraph/netflow netinet netinet6 nfs4cli...

2008-10-23 Thread Dag-Erling Smorgrav
Author: des Date: Thu Oct 23 20:26:15 2008 New Revision: 184214 URL: http://svn.freebsd.org/changeset/base/184214 Log: Fix a number of style issues in the MALLOC / FREE commit. I've tried to be careful not to fix anything that was already broken; the NFSv4 code is particularly bad in this r

svn commit: r184213 - head/sys/dev/drm

2008-10-23 Thread Robert Noland
Author: rnoland Date: Thu Oct 23 20:23:03 2008 New Revision: 184213 URL: http://svn.freebsd.org/changeset/base/184213 Log: Replace calls to minor() with dev2unit(). Ed already fixed this once, but I inadvertently overwrote the change when I synced to git. Commit the fix in both places, so

svn commit: r184212 - head/sys/dev/drm

2008-10-23 Thread Robert Noland
Author: rnoland Date: Thu Oct 23 20:19:56 2008 New Revision: 184212 URL: http://svn.freebsd.org/changeset/base/184212 Log: This check is invalid and I disabled it once already. I accidentally reintroduced it with the sync to git master. Commit the fix in both places this time. Approve

Re: svn commit: r184208 - head/sys/dev/uart

2008-10-23 Thread John Baldwin
On Thursday 23 October 2008 03:11:44 pm Ed Schouten wrote: > Author: ed > Date: Thu Oct 23 19:11:44 2008 > New Revision: 184208 > URL: http://svn.freebsd.org/changeset/base/184208 > > Log: > Fix detaching of uart(4) devices. > > With our new TTY layer we use a two step device destruction pr

svn commit: r184210 - in head/sys: net80211 sys

2008-10-23 Thread Dag-Erling Smorgrav
Author: des Date: Thu Oct 23 19:57:13 2008 New Revision: 184210 URL: http://svn.freebsd.org/changeset/base/184210 Log: Revert the removal of the MALLOC and FREE macros from the net80211 code. Requested by: sam Modified: head/sys/net80211/ieee80211_acl.c head/sys/net80211/ieee80211_cryp

svn commit: r184209 - head/sys/dev/usb

2008-10-23 Thread Ed Schouten
Author: ed Date: Thu Oct 23 19:16:57 2008 New Revision: 184209 URL: http://svn.freebsd.org/changeset/base/184209 Log: Don't include inside ucom(4) and ufoma(4). After being ported to the MPSAFE TTY layer, these drivers do not use clists anymore. Don't include their header files. Modifie

Re: svn commit: r184205 - in head: . share/man/man9 sys/arm/arm sys/cam/scsi sys/compat/linux sys/contrib/altq/altq sys/contrib/ipfilter/netinet sys/dev/ar sys/dev/ce sys/dev/hwpmc sys/dev/lmc sys/dev

2008-10-23 Thread Dag-Erling Smørgrav
Jaakko Heinonen <[EMAIL PROTECTED]> writes: > This change introduces some bad formatting. Many statements would now > fit to 80 columns and don't need to be wrapped. You're right, and I'd appreciate a patch, if you feel like it - but not right away, as I'm about to revert the net80211 parts of the

svn commit: r184208 - head/sys/dev/uart

2008-10-23 Thread Ed Schouten
Author: ed Date: Thu Oct 23 19:11:44 2008 New Revision: 184208 URL: http://svn.freebsd.org/changeset/base/184208 Log: Fix detaching of uart(4) devices. With our new TTY layer we use a two step device destruction procedure. The TTY first gets abandoned by the device driver. When the TTY la

Re: svn commit: r184205 - in head: . share/man/man9 sys/arm/arm sys/cam/scsi sys/compat/linux sys/contrib/altq/altq sys/contrib/ipfilter/netinet sys/dev/ar sys/dev/ce sys/dev/hwpmc sys/dev/lmc sys/dev

2008-10-23 Thread Jaakko Heinonen
Hi, On 2008-10-23, Dag-Erling Smorgrav wrote: > Log: > Retire the MALLOC and FREE macros. They are an abomination unto style(9). This change introduces some bad formatting. Many statements would now fit to 80 columns and don't need to be wrapped. > - MALLOC(softc, struct targ_softc *, si

svn commit: r184207 - head/sys/dev/sound/pci/hda

2008-10-23 Thread Alexander Motin
Author: mav Date: Thu Oct 23 18:30:06 2008 New Revision: 184207 URL: http://svn.freebsd.org/changeset/base/184207 Log: Add Intel ICH10 and SCH HDA controllers PCI IDs. Modified: head/sys/dev/sound/pci/hda/hdac.c Modified: head/sys/dev/sound/pci/hda/hdac.c

Re: svn commit: r184205 - in head: . share/man/man9 sys/arm/arm sys/cam/scsi sys/compat/linux sys/contrib/altq/altq sys/contrib/ipfilter/netinet sys/dev/ar sys/dev/ce sys/dev/hwpmc sys/dev/lmc sys/dev

2008-10-23 Thread Dag-Erling Smørgrav
Dag-Erling Smorgrav <[EMAIL PROTECTED]> writes: > Retire the MALLOC and FREE macros. They are an abomination unto style(9). The following one-liner can be used to convert existing code: find . -type f -name \*.c | xargs perl -p -i -e ' s/\bMALLOC(\s*\()([^,]+?),\s*([^,]+?),\s*/$2 = malloc$1/;

Re: svn commit: r184205 - in head: . share/man/man9 sys/arm/arm sys/cam/scsi sys/compat/linux sys/contrib/altq/altq sys/contrib/ipfilter/netinet sys/dev/ar sys/dev/ce sys/dev/hwpmc sys/dev/lmc sys/dev

2008-10-23 Thread Dag-Erling Smørgrav
Dag-Erling Smørgrav <[EMAIL PROTECTED]> writes: > Sam Leffler <[EMAIL PROTECTED]> writes: > > I didn't see this discussed anywhere. You have now generated huge > > gratuitous differences in net80211 against other code bases I > > maintain. > I suggest you look at ipfilter, for instance, which defi

Re: svn commit: r184205 - in head: . share/man/man9 sys/arm/arm sys/cam/scsi sys/compat/linux sys/contrib/altq/altq sys/contrib/ipfilter/netinet sys/dev/ar sys/dev/ce sys/dev/hwpmc sys/dev/lmc sys/dev

2008-10-23 Thread Dag-Erling Smørgrav
Sam Leffler <[EMAIL PROTECTED]> writes: > I didn't see this discussed anywhere. You have now generated huge > gratuitous differences in net80211 against other code bases I > maintain. I suggest you look at ipfilter, for instance, which defines its own cross-platform malloc / free wrappers. DES -

svn commit: r184206 - head

2008-10-23 Thread Dag-Erling Smorgrav
Author: des Date: Thu Oct 23 16:06:49 2008 New Revision: 184206 URL: http://svn.freebsd.org/changeset/base/184206 Log: Back out testing aid that was inadvertantly committed as part of r184205. Noticed by: rdivacky Modified: head/Makefile.inc1 Modified: head/Makefile.inc1 =

Re: svn commit: r184205 - in head: . share/man/man9 sys/arm/arm sys/cam/scsi sys/compat/linux sys/contrib/altq/altq sys/contrib/ipfilter/netinet sys/dev/ar sys/dev/ce sys/dev/hwpmc sys/dev/lmc sys/dev

2008-10-23 Thread Dag-Erling Smørgrav
Roman Divacky <[EMAIL PROTECTED]> writes: > Dag-Erling Smorgrav <[EMAIL PROTECTED]> writes: > > Modified: head/Makefile.inc1 > > [...] > are you sure this belongs here? No. This was something I threw in to make testing easier. Thanks for noticing. DES -- Dag-Erling Smørgrav - [EMAIL PROTECTED]

Re: svn commit: r184205 - in head: . share/man/man9 sys/arm/arm sys/cam/scsi sys/compat/linux sys/contrib/altq/altq sys/contrib/ipfilter/netinet sys/dev/ar sys/dev/ce sys/dev/hwpmc sys/dev/lmc sys/dev

2008-10-23 Thread Sam Leffler
Dag-Erling Smorgrav wrote: Author: des Date: Thu Oct 23 15:53:51 2008 New Revision: 184205 URL: http://svn.freebsd.org/changeset/base/184205 Log: Retire the MALLOC and FREE macros. They are an abomination unto style(9). I didn't see this discussed anywhere. You have now generated huge

Re: svn commit: r184205 - in head: . share/man/man9 sys/arm/arm sys/cam/scsi sys/compat/linux sys/contrib/altq/altq sys/contrib/ipfilter/netinet sys/dev/ar sys/dev/ce sys/dev/hwpmc sys/dev/lmc sys/dev

2008-10-23 Thread Roman Divacky
On Thu, Oct 23, 2008 at 03:53:52PM +, Dag-Erling Smorgrav wrote: > Author: des > Date: Thu Oct 23 15:53:51 2008 > New Revision: 184205 > URL: http://svn.freebsd.org/changeset/base/184205 > > Log: > Retire the MALLOC and FREE macros. They are an abomination unto style(9). > > MFC after:

svn commit: r184205 - in head: . share/man/man9 sys/arm/arm sys/cam/scsi sys/compat/linux sys/contrib/altq/altq sys/contrib/ipfilter/netinet sys/dev/ar sys/dev/ce sys/dev/hwpmc sys/dev/lmc sys/dev/...

2008-10-23 Thread Dag-Erling Smorgrav
Author: des Date: Thu Oct 23 15:53:51 2008 New Revision: 184205 URL: http://svn.freebsd.org/changeset/base/184205 Log: Retire the MALLOC and FREE macros. They are an abomination unto style(9). MFC after:3 months Modified: head/Makefile.inc1 head/share/man/man9/Makefile head/shar

svn commit: r184204 - in stable/7/sys: . geom/part

2008-10-23 Thread Marcel Moolenaar
Author: marcel Date: Thu Oct 23 15:44:00 2008 New Revision: 184204 URL: http://svn.freebsd.org/changeset/base/184204 Log: MFC rev 183455: Return G_PART_PROBE_PRI_HIGH instead of G_PART_PROBE_PRI_NORM if the probe succeeds. This guarantees that the BSD scheme wins over the MBR scheme when M

svn commit: r184203 - head/lib/libc/gen

2008-10-23 Thread Roman Divacky
Author: rdivacky Date: Thu Oct 23 15:32:06 2008 New Revision: 184203 URL: http://svn.freebsd.org/changeset/base/184203 Log: Fix a typo. Approved by: kib (mentor) Modified: head/lib/libc/gen/posix_spawn.c Modified: head/lib/libc/gen/posix_spawn.c

svn commit: r184202 - releng/6.4/release/scripts

2008-10-23 Thread Ken Smith
Author: kensmith Date: Thu Oct 23 13:24:58 2008 New Revision: 184202 URL: http://svn.freebsd.org/changeset/base/184202 Log: Adjust package set for 6.4-REL. Approved by: re (kib) Modified: releng/6.4/release/scripts/package-split.py Modified: releng/6.4/release/scripts/package-split.py

svn commit: r184201 - stable/6/release/scripts

2008-10-23 Thread Ken Smith
Author: kensmith Date: Thu Oct 23 13:23:14 2008 New Revision: 184201 URL: http://svn.freebsd.org/changeset/base/184201 Log: Adjust package set for 6.4-REL. Approved by: re (kib) Modified: stable/6/release/scripts/package-split.py Modified: stable/6/release/scripts/package-split.py

Re: svn commit: r184108 - head/sys/i386/i386

2008-10-23 Thread Dag-Erling Smørgrav
"Attilio Rao" <[EMAIL PROTECTED]> writes: > I think it is silly we have different quirks flag states for TSC. We > should just having a table assuming that the TSC is safe to use in SMP > environments and gets rid of any other flag (in this case, for amd64 > based machine, the logic could, for exa

svn commit: r184200 - head/release/doc/en_US.ISO8859-1/hardware

2008-10-23 Thread Dmitry Morozovsky
Author: marck (doc committer) Date: Thu Oct 23 10:38:04 2008 New Revision: 184200 URL: http://svn.freebsd.org/changeset/base/184200 Log: Correct a typo in Nocona core name. MFC after:3 days (modulo RE approval) Modified: head/release/doc/en_US.ISO8859-1/hardware/article.sgml Modifie

svn commit: r184199 - in head/sys: kern sys

2008-10-23 Thread David Xu
Author: davidxu Date: Thu Oct 23 07:55:38 2008 New Revision: 184199 URL: http://svn.freebsd.org/changeset/base/184199 Log: Actually, for signal and thread suspension, extra process spin lock is unnecessary, the normal process lock and thread lock are enough. The spin lock is still needed for

svn commit: r184198 - in head/sys: i386/include i386/include/xen i386/xen xen/evtchn

2008-10-23 Thread Kip Macy
Author: kmacy Date: Thu Oct 23 07:20:43 2008 New Revision: 184198 URL: http://svn.freebsd.org/changeset/base/184198 Log: Fix IPI support Modified: head/sys/i386/include/pcpu.h head/sys/i386/include/smp.h head/sys/i386/include/xen/xen-os.h head/sys/i386/include/xen/xen_intr.h head/sys/