Re: [alsa-devel] [PATCH] ASoC: compress: Fix compress device direction check

2016-01-07 Thread Vinod Koul
On Thu, Jan 07, 2016 at 11:19:17AM +0100, Takashi Iwai wrote: > On Thu, 07 Jan 2016 09:23:11 +0100, > Vinod Koul wrote: > > > > The detection of direction for compress takes into account codec > > capabilities only and not the CPU ones. Fix this by checking the > >

Re: [PATCH v2] ARM: pxa: ssp: Fix build error by removing originally incorrect DT binding

2015-09-21 Thread Vinod Koul
On Mon, Sep 21, 2015 at 11:03:18AM +0200, Robert Jarzmik wrote: > Jarkko Nikula writes: > > > Hi > > > > On 09/12/2015 04:43 PM, Robert Jarzmik wrote: > >> Jarkko Nikula writes: > >> > >>> Commit 03fbf488cece ("spi: pxa2xx: Differentiate Intel LPSS types") caused > >>> build error here because i

Re: [PATCH v3] ASoC: Intel: Get correct usage_count value to load firmware

2015-07-15 Thread Vinod Koul
e IPC messages are > processed correctly. Acked-by: Vinod Koul -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dmaengine: pl330: Really fix choppy sound because of wrong residue calculation

2015-07-06 Thread Vinod Koul
On Mon, Jun 15, 2015 at 11:00:09PM +0900, Krzysztof Kozlowski wrote: > When pl330 driver was used during sound playback, after some time or > after a number of plays the sound became choppy or totally noisy. For > example on Odroid XU3 board the first four executions of aplay with > small WAVE work

Re: [PATCH] dmaengine: pl330: Fix overflow when reporting residue in memcpy

2015-07-06 Thread Vinod Koul
On Mon, Jun 15, 2015 at 05:25:16PM +0900, Krzysztof Kozlowski wrote: > During memcpy operations the residue was always set to an u32 overflowed > value. > > In pl330_tx_status() function number of currently transferred bytes was > subtracted from internal "bytes_requested" field. However this > "b

Re: [PATCH] dmaengine: pl330: Really fix choppy sound because of wrong residue calculation

2015-06-29 Thread Vinod Koul
On Mon, Jun 22, 2015 at 11:14:42AM +0900, Krzysztof Kozłowski wrote: > 2015-06-15 23:00 GMT+09:00 Krzysztof Kozlowski : > > When pl330 driver was used during sound playback, after some time or > > after a number of plays the sound became choppy or totally noisy. For > > example on Odroid XU3 board

Re: [RFT PATCH] dmaengine: Fix choppy sound because of unimplemented resume

2015-06-12 Thread Vinod Koul
On Wed, Jun 10, 2015 at 05:17:07PM +0900, Krzysztof Kozlowski wrote: > Some drivers implement only pause operation (no resuming). Example is > pl330 where pause is needed for getting residuum. pl330 does not support > resume operation, transfer must be stopped after pause. > > However for slaves t

Re: [PATCH] dmaengine: at_xdmac: fix slave configuration issue

2015-04-26 Thread Vinod Koul
On Thu, Apr 16, 2015 at 05:04:00PM +0200, Ludovic Desroches wrote: > When doing the slave configuration, an error is returned if the maxburst > value is not supported. The bug comes from the fact that we always check > the maxburst for both directions but in the case of an unidirectional > channel,

Re: [PATCH 2/5] dmaengine: omap-dma: Fix memory leak when terminating running transfer

2015-03-30 Thread Vinod Koul
On Fri, Mar 27, 2015 at 01:35:52PM +0200, Peter Ujfalusi wrote: > In omap_dma_start_desc the vdesc->node is removed from the virt-dma > framework managed lists (to be precise from the desc_issued list). > If a terminate_all comes before the transfer finishes the omap_desc will > not be freed up bec

Re: [PATCH 1/5] dmaengine: edma: fix memory leak when terminating running transfers

2015-03-30 Thread Vinod Koul
On Fri, Mar 27, 2015 at 01:35:51PM +0200, Peter Ujfalusi wrote: > From: Petr Kulhavy > > If edma_terminate_all() was called while a transfer was running (i.e. after > edma_execute() but before edma_callback()) the echan->edesc was not freed. > > This was due to the fact that a running transfer i

Re: [PATCH v2] dmaengine: dw: update MAINTAINERS file

2015-01-17 Thread Vinod Koul
On Wed, Jan 14, 2015 at 12:00:16PM +0200, Andy Shevchenko wrote: > On Tue, 2015-01-13 at 23:19 +0530, Vinod Koul wrote: > > On Tue, Jan 13, 2015 at 07:13:48PM +0200, Andy Shevchenko wrote: > > > This is a follow up to the previously done changes in the layout of the > >

Re: [PATCH v2] dmaengine: dw: update MAINTAINERS file

2015-01-13 Thread Vinod Koul
On Tue, Jan 13, 2015 at 07:13:48PM +0200, Andy Shevchenko wrote: > This is a follow up to the previously done changes in the layout of the driver > files. We now have an additional file include/linux/dma/dw.h which is missed > in > the MAINTAINERS data base. > > Fixes: 3d588f83e4d6 (dmaengine: dw

Re: [PATCH] dmaengine: sun6i: Fix memcpy operation

2014-11-12 Thread Vinod Koul
On Tue, Nov 11, 2014 at 07:35:52PM +0100, Maxime Ripard wrote: > The prep_memcpy call was not setting any meaningful burst and width because it > was relying on the dma_slave_config was not set already. > > Rework the needed conversion functions, and hardcode the width and burst to > use. > Appli

Re: [RESEND PATCH v2 4/4] dmaengine: pl330: Fix NULL pointer dereference on driver unbind

2014-10-14 Thread Vinod Koul
On Mon, Sep 29, 2014 at 02:42:21PM +0200, Krzysztof Kozlowski wrote: > Fix a NULL pointer dereference after unbinding the driver, if channel > resources were not yet allocated (no call to > pl330_alloc_chan_resources()): > $ echo 1285.mdma > /sys/bus/amba/drivers/dma-pl330/unbind > [ 13.60653

Re: [RESEND PATCH v2 3/4] dmaengine: pl330: Fix NULL pointer dereference on probe failure

2014-10-14 Thread Vinod Koul
On Mon, Sep 29, 2014 at 02:42:20PM +0200, Krzysztof Kozlowski wrote: > If dma_async_device_register() returns error and probe should clean up > and return error, a NULL pointer exception happens because of > dereference of not allocated channel thread: > > Dmesg log (from early printk): > dma-pl33

Re: [PATCH] dma: ste_dma40: don't dereference free:d descriptor

2014-02-17 Thread Vinod Koul
On Thu, Feb 13, 2014 at 10:39:01AM +0100, Linus Walleij wrote: > It appears that in the DMA40 driver the DMA tasklet will very > often dereference memory for a descriptor just free:d from the > DMA40 slab. Nothing happens because no other part of the driver > has yet had a chance to claim this memo

Re: [PATCH 1/2] dma: pl08x: fix descriptor unmapping

2013-12-18 Thread Vinod Koul
On Wed, Dec 18, 2013 at 09:50:36PM +0530, Vinod Koul wrote: > On Sat, Dec 14, 2013 at 12:16:07AM +0100, Linus Walleij wrote: > > The descriptor unmapping code introduced in commit > > d38a8c622a1b3 "dmaengine: prepare for generic 'unmap' data" > > accide

Re: [PATCH 1/2] dma: pl08x: fix descriptor unmapping

2013-12-18 Thread Vinod Koul
On Sat, Dec 14, 2013 at 12:16:07AM +0100, Linus Walleij wrote: > The descriptor unmapping code introduced in commit > d38a8c622a1b3 "dmaengine: prepare for generic 'unmap' data" > accidentally affects a local struct rather than the > async TX descriptor, resulting in this compile error: > > CC

Re: [PATCH 3.11-stable] dmaengine: imx-dma: fix lockdep issue between irqhandler

2013-10-09 Thread Vinod Koul
403.738078] 3f40: 0002 c0b69620 a0004000 41069264 a03fb5f4 c0403f7c > c0403f40 c0403f70 > [ 403.746301] 3f60: c004b92c c0009e74 2013 > [ 403.751383] r6: r5:2013 r4:c0009e74 r3:c004b92c > [ 403.757210] [] (arch_cpu_idle+0x0/0x4c) from [] > (cpu_startup

Re: [PATCH 2/9] ALSA: compress: use mutex in drain

2013-08-27 Thread Vinod Koul
On Tue, Aug 27, 2013 at 12:25:23PM +0200, Takashi Iwai wrote: > At Tue, 27 Aug 2013 12:10:32 +0530, > Vinod Koul wrote: > > > > Since we dont have lock over the function, we need to aquire mutex when > > checking > > and modfying states in drain and partial_drain h

Re: [PATCH 1/9] ALSA: Compress - dont use lock for all ioctls

2013-08-27 Thread Vinod Koul
On Tue, Aug 27, 2013 at 12:22:31PM +0200, Takashi Iwai wrote: > At Tue, 27 Aug 2013 12:10:31 +0530, > Vinod Koul wrote: > > > > Some simple ioctls like timsetamp query, capabities query can be done > > anytime > > and should not be under

[PATCH 9/9] ALSA: compress: use rate values for passing sampling rates

2013-08-27 Thread Vinod Koul
: Vinod Koul Cc: --- include/uapi/sound/compress_offload.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/uapi/sound/compress_offload.h b/include/uapi/sound/compress_offload.h index d630163..cad87ff 100644 --- a/include/uapi/sound/compress_offload.h +++ b

[PATCH 3/9] ASoC: compress: dont aquire lock for draining states

2013-08-27 Thread Vinod Koul
Both draining and partial draning states will take a while getting executed. The lock aquired will block the other operations like pause, stop etc which are perfectly valid cmds during these states. So dont use mutex while invoking DSP for these ops Signed-off-by: Vinod Koul Cc: --- sound/soc

[PATCH 2/9] ALSA: compress: use mutex in drain

2013-08-27 Thread Vinod Koul
Since we dont have lock over the function, we need to aquire mutex when checking and modfying states in drain and partial_drain handlers Signed-off-by: Vinod Koul Cc: --- sound/core/compress_offload.c | 22 +++--- 1 files changed, 19 insertions(+), 3 deletions(-) diff --git

[PATCH 1/9] ALSA: Compress - dont use lock for all ioctls

2013-08-27 Thread Vinod Koul
Some simple ioctls like timsetamp query, capabities query can be done anytime and should not be under the stream lock. Move these to snd_compress_simple_iotcls() which is invoked without lock held While at it, improve readblity a bit by sprinkling some empty lines Signed-off-by: Vinod Koul Cc

Re: [PATCH] ALSA: compress: fix the return value for SNDRV_COMPRESS_VERSION

2013-07-29 Thread Vinod Koul
On Mon, Jul 29, 2013 at 11:53:15AM +0200, Takashi Iwai wrote: > At Sun, 28 Jul 2013 20:04:03 +0530, > Vinod Koul wrote: > > > > Reported-by: Haynes > > CC: stable@vger.kernel.org > > Signed-off-by: Vinod Koul > > The fix is trivial, but please give a bit m

[PATCH] ALSA: compress: fix the return value for SNDRV_COMPRESS_VERSION

2013-07-29 Thread Vinod Koul
the return value of SNDRV_COMPRESS_VERSION always return default -ENOTTY as the return value was never updated for this call assign return value from put_user() Reported-by: Haynes CC: stable@vger.kernel.org Signed-off-by: Vinod Koul --- sound/core/compress_offload.c |2 +- 1 files changed

[PATCH] ALSA: compress: fix the return value for SNDRV_COMPRESS_VERSION

2013-07-28 Thread Vinod Koul
Reported-by: Haynes CC: stable@vger.kernel.org Signed-off-by: Vinod Koul --- sound/core/compress_offload.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c index 99db892..9896954 100644 --- a/sound/core

Re: [PATCH v2] dma: pl330: Fix cyclic transfers

2013-07-28 Thread Vinod Koul
On Tue, Jul 23, 2013 at 10:24:50AM +0200, Lars-Peter Clausen wrote: > Allocate a descriptor for each period of a cyclic transfer, not just the > first. > Also since the callback needs to be called for each finished period make sure > to > initialize the callback and callback_param fields of each

Re: [PATCH resend] dma: pl330: Fix cyclic transfers

2013-07-22 Thread Vinod Koul
On Tue, Jul 16, 2013 at 04:13:23PM +0200, Lars-Peter Clausen wrote: > Allocate a descriptor for each period of a cyclic transfer, not just the > first. > Also since the callback needs to be called for each finished period make sure > to > initialize the callback and callback_param fields of each

Re: helping with tracking commits across repos

2013-04-13 Thread Vinod Koul
in linus tree, although they are... perhaps a bug? http://o.cs.uvic.ca:20810/perl/cid.pl?cid=765024697807ad1e1cac332aa891253ca4a339da It shows the same for linus's merge! http://o.cs.uvic.ca:20810/perl/cid.pl?cid=cfb63bafdb87bbcdc5d6dbbca623d3f69475f118 -- Vinod Koul Intel Corp. -- To uns

Re: [PATCH v2] ioat: remove chanerr mask setting for IOAT v3.x

2013-03-20 Thread Vinod Koul
On Wed, Nov 28, 2012 at 03:46:08AM +0530, Jiang, Dave wrote: > The existing code set a value in the PCI_CHANERRMSK_INT register > for a workaround to address a pre-silicon bug on the Intel 5520 IO hub that > has been fixed when the hardware was released. There is no need for this > code. > > Signe

Re: [PATCH] ioat: Fix DMA memory sync direction correct flag

2012-10-28 Thread Vinod Koul
. Applied, thanks -- Vinod Koul Intel Corp. -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dmaengine: pl330: dont complete descriptor for cyclic dma

2012-06-07 Thread Vinod Koul
On Wed, 2012-05-23 at 16:47 +0530, Tushar Behera wrote: > Commit eab215855803 ("dmaengine: pl330: dont complete descriptor for > cyclic dma") wrongly completes descriptor for cyclic dma, hence following > BUG_ON is still hit with cyclic DMA operations. > > kernel BUG at drivers/dma/dmaengine.h:53!

Re: [PATCH] dmaengine: at_hdmac: remove clear-on-read in atc_dostart()

2012-04-20 Thread Vinod Koul
On Mon, 2012-04-16 at 14:46 +0200, Nicolas Ferre wrote: > This loop on EBCISR register was designed to clear IRQ sources before enabling > a DMA channel. This register is clear-on-read so a race condition can appear > if > another channel is already active and has just finished its transfer. > Rem