&&
> + intel_connector->encoder->hpd_pin > HPD_NONE)
> connector->polled = DRM_CONNECTOR_POLL_HPD;
> }
>
> --
> 2.5.0
>
> ___
> Intel-gfx mailing list
> intel-...@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
vger.kernel.org
References: http://www.spinics.net/lists/intel-gfx/msg83075.html
Signed-off-by: Daniel Vetter
---
Meelis, can you pls retest this one?
Thanks, Daniel
---
drivers/gpu/drm/i915/i915_dma.c | 6 +++---
drivers/gpu/drm/i915/intel_display.c | 2 ++
2 files changed, 5 insertions(+), 3 del
/i915: Introduce a gmbus power domain")
Cc: stable@vger.kernel.org
References: http://www.spinics.net/lists/intel-gfx/msg83075.html
Tested-by: Meelis Roos
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/i915_dma.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git
On Thu, Jan 7, 2016 at 1:52 PM, Ville Syrjälä
wrote:
> On Thu, Jan 07, 2016 at 12:44:21PM +0100, Daniel Vetter wrote:
>> Since
>>
>> commit ac9b8236551d1177fd07b56aef9b565d1864420d
>> Author: Ville Syrjälä
>> Date: Fri Nov 27 18:55:26 2015 +0200
>>
&
/intel-gfx/msg83075.html
Tested-by: Meelis Roos
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/i915_dma.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
index 988a3806512a..490d8b0d931e 10
use them.
Cc: Ville Syrjälä
Cc: Patrik Jakobsson
Cc: Imre Deak
Cc: Jani Nikula
Cc: Meelis Roos
Fixes: ac9b8236551d ("drm/i915: Introduce a gmbus power domain")
Cc: stable@vger.kernel.org
References: http://www.spinics.net/lists/intel-gfx/msg83075.html
Signed-off-by: Daniel Vetter
--
if (!connector->polled && I915_HAS_HOTPLUG(dev) &&
intel_connector->encoder->hpd_pin > HPD_NONE)
connector->polled = DRM_CONNECTOR_POLL_HPD;
}
That yields even tidier code and gives us a place for a comment.
On Mon, Dec 21, 2015 at 02:49:18PM +0100, Daniel Vetter wrote:
> On Fri, Dec 18, 2015 at 07:24:39PM +0200, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > Turns out CHV pipe C was glued on somewhat poorly, and there's something
> > wron
-off-by: Ville Syrjälä
Well can't really review with Bspec and I don't expect we can get
confirmation from hw engineers. But does what it says in the commit
message.
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/i915/intel_display.c | 17 +
> 1 file ch
> Signed-off-by: Chris Wilson
> Cc: Daniel Vetter
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/i915/i915_gem_context.c | 29 +
> 1 file changed, 17 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_context.
timing issue).
> Here, we do not need the w/a to force ordering of the read with an
> interrupt.
>
> Signed-off-by: Chris Wilson
> Reviewed-by: Tvrtko Ursulin
> Cc: "Rogozhkin, Dmitry V"
> Cc: Daniel Vetter
> Cc: Tvrtko Ursulin
> Cc: Eero Tamminen
>
> > >
> > > v4: Try to simplify the pinning even further.
> > > v5: Leak the VMA (cleaned up by object-free) to avoid complicated error
> > > paths.
> > >
> > > Signed-off-by: Chris Wilson
> > > Cc: "Goel, Akash"
> > &g
ion, the declaration of fb can then be
> changed thus:
>
> - struct drm_framebuffer *fb = NULL;
> + struct drm_framebuffer *fb;
>
> Kind regards,
Yeah there's room for follow-up polish, but this seems good enough at
least for -fixes.
Reviewed-by: Daniel Vetter
L
atomic helpers. But that's way too
much for -fixes.
On the patch itself, for -fixes: Reviewed-by: Daniel Vetter
> Cc: Ander Conselvan de Oliveira
> Fixes: 5448a00d3f06 ("drm/i915: Don't use staged config in
> check_digital_port_conflicts()")
> Signed-off-by: Vi
den to keep
> plane_state->visible set, or a WARN_ON in intel_plane_atomic_calc_changes
> triggers. There are other code points that rely on accurate
> plane_state->visible
> too, so make sure the bool is cleared.
Oh dear is this a mess :(
As a bugfix this is Reviewed-by: Daniel V
idn't spot one
> > callsite in wait-ioctl was passing the wrong pointer.
> >
> > Signed-off-by: Chris Wilson
> > Cc: Daniel Vetter
> > Cc: stable@vger.kernel.org
>
> Fwiw, the impact of this bug is zero. Along the rps path, we always
> first call list_e
that list). This way we will
> correctly prune away any mode from the old mode list that didn't
> appear on the probed_modes list.
>
> Cc: stable@vger.kernel.org
> Cc: Adam Jackson
> Fixes: 05acaec334fc ("drm: Reorganize probed mode validation")
> Signed-off-by:
gned-off-by: Chris Wilson
> Cc: Lionel Landwerlin
> Cc: Tvrtko Ursulin
> Cc: Daniel Vetter
> Cc: stable@vger.kernel.org
Commit message should explain what the actual problem is - we add 1 jiffy
of delay for each wait_request, potentially waiting quite a bit longer
than what userspace as
DRM_ERROR("Failed to allocate fb_info\n");
>232ret = PTR_ERR(info);
>233goto out_unpin;
>
> ---
> 0-DAY kernel test infrastructureOpen Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
patches to prevent userspace ever seeing
> unknown swizzling through the normal get-tiling-ioctl. Also use the same
> path for the existing uneven bank detection for mobile gen4.
>
> Reported-by: Matti Hämäläinen
> Tested--by: Matti Hämäläinen
> References: https://bugs.freedeskt
le_y = I915_BIT_6_SWIZZLE_9;
> --
> 2.6.2
>
> ___
> Intel-gfx mailing list
> intel-...@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.
ursor_needs_physical)) {
> intel_unpin_fb_obj(old_state->fb, old_state);
> + }
>
> /* prepare_fb aborted? */
> if ((old_obj && (old_obj->frontbuffer_bits &
> intel_plane->frontbuffer_bit)) ||
> --
> 2.1.0
>
mary plane must be fullscreen, and on
> the rest only the first eye would get a visible plane.
>
> Cc: Daniel Vetter
> Cc: stable@vger.kernel.org
> Fixes: 042652ed9599 ("drm/atomic-helper: implementatations for legacy
> interfaces")
> Signed-off-by: Ville Syrj
ch, but a bit a terse commit message. We should add "Without this
fix the plane->fb refcounting might get out of sync on retries, resulting
in either leaked memory or use-after-free." With that:
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/drm_atomic.c | 3 ++-
>
addfb2, the ioctl will be rejected since it's now asking for
> some modifiers w/o the flag set.
>
> Fix the problem by making a copy of the user provided structure. We can
> play any games we want with the copy.
>
> Cc: stable@vger.kernel.org
> Cc: Daniel Vetter
>
> Can we allow this for unsynchronized userptrs?
I'd like to not add more complexity to a root-only feature.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a m
s(crtc);
Does this ever do anything at all? We just killed the crtc completely
above, those watermark writes will get cleansed as soon as the power well
goes down.
-Daniel
> }
> }
>
> --
> 2.1.0
>
> ___
> Inte
power well is off.
>
> Signed-off-by: Maarten Lankhorst
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92181
> Cc: stable@vger.kernel.org
Reviewed-by: Daniel Vetter
Jani, one for you.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_pm.c | 5 +
> 1 file changed, 5 i
esg about a feature which isn't even
implemented and took about 20+ patches to get right in Linus tree. Option
B is to waste reporters time if we leave that DRM_ERROR in there with
filing bugs that we'll close right away. There's no way we can backport
DVFS support without breaking the w
t;tries to unmap its address space. The situation can be even more
> >complicated when the buffer is passed between processes, between a
> >client and display server, where the lifetime and hardware access is
> >even more confusing. Deny it.
>
> Reviewed-by: Tvrtko Urs
On Tue, Oct 13, 2015 at 04:10:19PM +0300, Jani Nikula wrote:
> On Thu, 08 Oct 2015, Ville Syrjälä wrote:
> > On Thu, Oct 08, 2015 at 10:17:30AM +0200, Daniel Vetter wrote:
> >> On Wed, Oct 07, 2015 at 10:08:24PM +0300, ville.syrj...@linux.intel.com
> >> wrote:
On Tue, Oct 13, 2015 at 03:45:58PM +0300, Jani Nikula wrote:
> On Wed, 26 Aug 2015, Chris Wilson wrote:
> > On Wed, Aug 26, 2015 at 11:16:34AM +0200, Daniel Vetter wrote:
> >> On Fri, Aug 21, 2015 at 04:08:41PM +0100, Chris Wilson wrote:
> >> > In order to f
> ___
> Intel-gfx mailing list
> intel-...@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line &q
On Thu, Oct 01, 2015 at 07:13:11PM +0300, Francisco Jerez wrote:
> Daniel Vetter writes:
>
> > In
> >
> > commit 8f0e2b9d95a88ca5d8349deef2375644faf184ae
> > Author: Daniel Vetter
> > Date: Tue Dec 2 16:19:07 2014 +0100
> >
> > drm/i9
In
commit 8f0e2b9d95a88ca5d8349deef2375644faf184ae
Author: Daniel Vetter
Date: Tue Dec 2 16:19:07 2014 +0100
drm/i915: Move golden context init into ->init_context
I've shuffled around per-ctx init code a bit for legacy contexts but
accidentally dropped the render state init call
o just grab the
mode_config.connection_mutex, but we can do a bit better.
v2: Remove unused variables I failed to git add for real.
Reported-by: Jens Axboe
Cc: Jens Axboe
Cc: Rob Clark
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/drm_sysfs.c | 12 +++-
1 file changed, 3 i
o just grab the
mode_config.connection_mutex, but we can do a bit better.
Reported-by: Jens Axboe
Cc: Jens Axboe
Cc: Rob Clark
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/drm_sysfs.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_sy
>
> v2: Use the most recent values when erring out on an unstable register.
>
> Reported-by: russianneuroman...@ya.ru
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91906
> Signed-off-by: Chris Wilson
> Cc: Michał Winiarski
> Cc: Daniel Vetter
> Cc: Jani Nikula
are not stable.
> > Just give up after a couple of tries and report whatever we read last.
> >
> > Reported-by: russianneuroman...@ya.ru
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91906
> > Signed-off-by: Chris Wilson
> > Cc: Michał Winiarski
tions under which userspace may wish to tell white lies to the
> kernel...
>
> Signed-off-by: Chris Wilson
> Cc: Daniel Vetter
> Cc: Kristian Høgsberg
> Cc: Jesse Barnes
> Cc: "Goel, Akash"
> Cc: Michał Winiarski
> Cc: stable@vger.kernel.org
Reviewed-by
On Wed, Aug 26, 2015 at 03:06:59PM +0200, Daniel Vetter wrote:
> On Wed, Aug 26, 2015 at 12:55:57PM +0100, Chris Wilson wrote:
> > As we mark the preallocated objects as bound, we should also flag them
> > correctly as being map-and-fenceable (if appropriate!) so that latter
>
et a map-and-fenceable binding.
>
> Signed-off-by: Chris Wilson
> Cc: "Goel, Akash"
> Cc: Daniel Vetter
> Cc: Jesse Barnes
> Cc: stable@vger.kernel.org
Reviewed-by: Daniel Vetter
Jani, can you please pick up both? And some bugzilla references for either
would be gre
flags |= PIPE_CONTROL_FLUSH_ENABLE;
> }
> if (invalidate_domains) {
> flags |= PIPE_CONTROL_TLB_INVALIDATE;
> --
> 2.5.0
>
> _______
> Intel-gfx mailing list
> intel-...@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel
t; Date: Fri May 2 14:02:48 2014 +1000
> >
> > drm/i915: add DP 1.2 MST support (v0.7)
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89453
>
> Tested-by: Palmer Dabbelt
Reviewed-by: Daniel Vetter
>
> > Bugzilla: https://bugs.freedesktop.
ther way round: First we
synchronously kfree the port, then we call the driver's connector cleanup
function asynchronously. And that is very unhappy that the port is now
gone.
So perfectly ok regression fix imo to restore the ordering we had before
your patch in the cleanup code.
-Daniel
--
Dani
s this
already. Reviewed-by: Daniel Vetter
-Daniel
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c
> b/drivers/gpu/drm/i915/intel_lrc.c
> index 138964afd187..41cfa6fa909d 100644
> --- a/d
> This fixes a regression introduced with
> 6b8eeca65b18ae77e175cc2b6571731f0ee413bf
> "drm/dp/mst: close deadlock in connector destruction."
>
> Cc: stable@vger.kernel.org
> Cc: Dave Airlie
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Daniel Vetter
Jani, can you
Apparently been in there since forever and fairly easy to hit when
hotplugging really fast. I can do that since my mst hub has a manual
button to flick the hpd line for reprobing. The resulting WARNING spam
isn't pretty.
Cc: Dave Airlie
Cc: stable@vger.kernel.org
Signed-off-by: Daniel V
manually detile
> > into memory as the swizzling for an individual page is unknown (it
> > depends on its physical address only known to the kernel), userspace
> > cannot correctly swizzle.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91105
&
On Tue, Jul 21, 2015 at 10:45:45AM +0100, Chris Wilson wrote:
> On Tue, Jul 21, 2015 at 08:49:31AM +0200, Daniel Vetter wrote:
> > On Fri, Jul 17, 2015 at 05:10:25PM +0200, Michał Winiarski wrote:
> > > On Thu, Jul 16, 2015 at 12:37:56PM +0100, Chris Wilson wrote:
> >
@ -1087,6 +1087,14 @@ struct drm_i915_reg_read {
> > __u64 offset;
> > __u64 val; /* Return value */
> > };
> > +/* Known registers:
> > + *
> > + * Render engine timestamp - 0x2358 + 64bit - gen7+
> > + * - Note this register returns an invalid value if using the default
> > + * single instruction 8byte read, in order to workaround that use
> > + * offset (0x2538 | 1) instead.
> > + *
> > + */
> >
> > struct drm_i915_reset_stats {
> > __u32 ctx_id;
> > --
> > 2.1.4
> >
> ___
> Intel-gfx mailing list
> intel-...@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
http://article.gmane.org/gmane.comp.freedesktop.xorg.drivers.intel/62584
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=100641
Cc: Rui Matos
Cc: Julien Wajsberg
Cc: kuddel.m...@gmx.de
Cc: Lennart Poettering
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/drm_crtc.c | 5 +
1 file changed, 1
this we need to extend the ioctl with
new paramters that only new userspace looks at.
Cc: Harald Arnesen
Cc: Chris Wilson
Reported-by: Harald Arnesen
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/i915_gem_tiling.c | 12 +---
1 file changed, 1 inse
and makes the ioctl need explicit
> compat handling.
>
> v2: Removed the typedef. (Daniel Vetter)
>
> Signed-off-by: Tvrtko Ursulin
> Reviewed-by: Daniel Vetter
> Cc: dri-de...@lists.freedesktop.org
> Cc: Rob Clark
> Cc: Daniel Stone
> Cc: Daniel Vetter
> Cc: s
on its physical address only known to the kernel), userspace
> cannot correctly swizzle objects.
>
> v2: Mark the global swizzling as unknown rather than adjust the value
> reported to userspace.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91105
> Signed-of
he mapping.
>
> Signed-off-by: Daniel Kurtz
> Reviewed-by: Daniel Vetter
> Cc: stable@vger.kernel.org
Applied to topic/drm-fixes to make sure it won't get lost, but I expect
rockchip maintainers to pick this one up.
-Daniel
>
> ---
> drivers/gpu/drm/rockchip/rockchip_d
When inlining the actual hpd output probing in
commit 69787f7da6b2adc4054357a661aaa1701a9ca76f
Author: Daniel Vetter
Date: Tue Oct 23 18:23:34 2012 +
drm: run the hpd irq event code directly
the check for the drm_kms_hlper.poll module option was lost. This
regressed systems where
s.freedesktop.org/show_bug.cgi?id=91127
> References: https://bugzilla.freedesktop.org/show_bug.cgi?id=60391
> Signed-off-by: Chris Wilson
> Cc: Daniel Vetter
> Cc: stable@vger.kernel.org
Oops, can't count how often we've committed this mistake.
Reviewed-by: Daniel Vetter
>
on its physical address only known to the kernel), userspace
> cannot correctly swizzle.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91105
> Signed-off-by: Chris Wilson
> Cc: Daniel Vetter
> Cc: stable@vger.kernel.org
Reviewed-by: Daniel Vetter
> ---
Since there's only one global instance ever we don't need to have
anything fancy. Stops a WARNING in the get_unique ioctl that the
unique name isn't set.
Cc: # 4.1+ only
Reportedy-and-tested-by: Fabio Coatti
Cc: Fabio Coatti
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/
On Tue, Jun 23, 2015 at 01:05:41PM +0300, Jani Nikula wrote:
> On Fri, 19 Jun 2015, Daniel Vetter wrote:
> > We've never figured out the magic trick to make irq vs. seqno
> > updates coherent, only tricks to make it work. And since
> >
> > commit 094f9a54
On Tue, Jun 23, 2015 at 9:12 AM, Jani Nikula wrote:
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89600
>> Cc: stable@vger.kernel.org # 4.0+
>> Signed-off-by: Peter Antoine
>> Reviewed-by: Daniel Vetter
>> [Jani: fixed typo in subject, massaged the co
it might be of value for bug reports (Chris).
Cc: Mark Janes
Cc: Chris Wilson
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/i915_irq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/
nes
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/i915_irq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index e6bb72dca3ff..9350f2e5cd04 100644
--- a/drivers/gpu/drm/i915/i
struct intel_gmbus,
adapter);
struct drm_i915_private *dev_priv = bus->dev_priv;
- int i, reg_offset;
+ int i = 0, reg_offset;
int ret = 0;
intel_aux_display_runtime_get(dev_priv);
@@ -499,9 +499,10 @@ gmbus_xfer(struct i2c_adapter *adapter,
reg_offset = dev_priv->gpio_mmio_base;
+retry:
I915_WRITE(GMBUS0 + reg_offset, bus->reg0);
- for (i = 0; i < num; i++) {
+ for (i; i < num; i++) {
if (gmbus_is_index_read(msgs, i, num)) {
ret = gmbus_xfer_index_read(dev_priv, &msgs[i]);
i += 1; /* set i to the index of the read xfer */
@@ -576,6 +577,9 @@ clear_err:
adapter->name, msgs[i].addr,
(msgs[i].flags & I2C_M_RD) ? 'r' : 'w', msgs[i].len);
+ if (bla)
+ goto retry;
+
goto out;
timeout:
---
Totally untested ofc ;-)
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 26, 2015 at 09:49:15AM +0100, Chris Wilson wrote:
> On Tue, May 26, 2015 at 10:01:24AM +0200, Daniel Vetter wrote:
> > On Mon, May 25, 2015 at 06:48:44PM +0100, Chris Wilson wrote:
> > > Since the advent of mmap(wc), where we reused the same cache domain for
> >
On Thu, May 21, 2015 at 5:30 PM, Daniel Vetter wrote:
> On Thu, May 21, 2015 at 04:22:55PM +0100, Chris Wilson wrote:
>> On Thu, May 21, 2015 at 04:21:46PM +0200, Daniel Vetter wrote:
>> > Hm right. What about emphasising this a bit more in the comment:
>> >
>&g
on the other path.
> + */
> + if (write)
> + mb();
> + else
> + wmb();
> return 0;
> }
>
> --
> 2.1.4
>
> ___
> Intel-gfx mailing list
> intel-...@lists.freedesktop.
On Thu, May 21, 2015 at 04:22:55PM +0100, Chris Wilson wrote:
> On Thu, May 21, 2015 at 04:21:46PM +0200, Daniel Vetter wrote:
> > Hm right. What about emphasising this a bit more in the comment:
> >
> > /*
> > * Empirical evidence indicates that
On Thu, May 21, 2015 at 02:13:01PM +0100, Chris Wilson wrote:
> On Thu, May 21, 2015 at 03:07:54PM +0200, Daniel Vetter wrote:
> > On Thu, May 21, 2015 at 02:00:34PM +0100, Chris Wilson wrote:
> > > On Tue, May 19, 2015 at 03:41:48PM +0100, Chris Wilson wrote:
> > > >
On Thu, May 21, 2015 at 02:00:34PM +0100, Chris Wilson wrote:
> On Tue, May 19, 2015 at 03:41:48PM +0100, Chris Wilson wrote:
> > On Mon, May 11, 2015 at 04:25:52PM +0100, Chris Wilson wrote:
> > > On Mon, May 11, 2015 at 12:34:37PM +0200, Daniel Vetter wrote:
> > > >
In
commit f02ad907cd9e7fe3a6405d2d005840912f1ed258
Author: Daniel Vetter
Date: Thu Jan 22 16:36:23 2015 +0100
drm/atomic-helpers: Recover full cursor plane behaviour
we've added a hack to atomic helpers to never to vblank waits for
cursor updates through the legacy apis since that&#
yrjälä
Cc: Ramalingam C
Cc: Rodrigo Vivi
Cc: Vandana Kannan
Cc: stable@vger.kernel.org (4.0+ only)
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/intel_dp.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gp
> Reported-by: Rob Engle
> Tested-by: Jolan Luff
> Cc: stable@vger.kernel.org
> Signed-off-by: Jani Nikula
Since it's harmless I wonder whether we shouldn't just do this in
drm_add_edid_modes unconditionally. But this looks like the right minimal
patch for -fixes, so Reviewe
On Fri, Mar 06, 2015 at 08:54:35AM +, Chris Wilson wrote:
> On Thu, Mar 05, 2015 at 01:27:43PM +0100, Daniel Vetter wrote:
> > On Wed, Mar 04, 2015 at 06:09:26PM +, Chris Wilson wrote:
> > > This fixes a regression from
> > >
> > > commit 5ed0
hat made a negative timeout return immediately rather than the
> previously defined behaviour of waiting indefinitely.
>
> Signed-off-by: Chris Wilson
> Cc: Daniel Vetter
> Cc: Ben Widawsky
> Cc: Kristian Høgsberg
> Cc: stable@vger.kernel.org
Do you have the igt for this too?
ipe))
> > >> +!to_intel_crtc(crtc)->cpu_fifo_underrun_disabled)
>
> Should be without the '!':
> if (HAS_GMCH_DISPLAY(dev_priv->dev) &&
> to_intel_crtc(crtc)->cpu_fifo_underrun_disabled)
Somewhere on my todo is to invert the sense of
Originally it was impossible to be dropping the last refcount in this
function since there was always one around still from the idr. But in
commit 83f45fc360c8e16a330474860ebda872d1384c8c
Author: Daniel Vetter
Date: Wed Aug 6 09:10:18 2014 +0200
drm: Don't grab an fb reference for th
ernal() into the addfb ioctl implementation, which is
> > the only place it is needed. And also rename the function for a more
> > accurate since it only creates the fb, but doesn't add it anywhere.
> >
> > Signed-off-by: Daniel Vetter (fix & commit msg)
> > Sign
> +{
> + struct drm_device *drm_dev = dev_to_i915(dev)->dev;
> +
> + if (drm_dev->switch_power_state == DRM_SWITCH_POWER_OFF)
> + return 0;
> +
> + return i915_drm_suspend_late(drm_dev, true);
> }
>
> static int i915_pm_resume_early(struct
On Mon, Feb 23, 2015 at 01:29:57PM -0800, Jesse Barnes wrote:
> On 11/24/2014 06:13 AM, Chris Wilson wrote:
> > On Mon, Nov 24, 2014 at 03:10:05PM +0100, Daniel Vetter wrote:
> >> On Mon, Nov 24, 2014 at 10:35:29AM +, Chris Wilson wrote:
> >>> Pinning is a us
similar.
Otherwise when we extended them in upstream (which we're just doing,
the kernel 0-fills the new fields automatically) it'll break because
after a recompile there's now garbage in the new fields.
I just spent a while fixing up libdrm ;-)
-Daniel
--
Daniel Vetter
Software Engin
l.org
Cc: Johannes W
Cc: Chris Wilson
Cc: Jani Nikula
Reported-by: Johannes W
Signed-off-by: Daniel Vetter
--
Johannes, can you please test this patch instead of the one from
Chris?
Thanks, Daniel
---
drivers/gpu/drm/i915/i915_gem_stolen.c | 5 +
drivers/gpu/drm/i915/intel_display.c
Nikula
Reported-by: Johannes W
Signed-off-by: Daniel Vetter
--
Johannes, can you please test this patch instead of the one from
Chris?
Thanks, Daniel
---
drivers/gpu/drm/i915/i915_gem_stolen.c | 5 +
drivers/gpu/drm/i915/intel_display.c | 18 --
2 files changed, 13
patch also fully reverts this fixup. Apparently this
is just too tricky.
Reported-by: Sean V Kelley
Signed-off-by: Chris Wilson
Cc: Sean V Kelley
Cc: stable@vger.kernel.org
Cc: Chris Wilson
Cc: Jani Nikula
Signed-off-by: Daniel Vetter (v2)
---
drivers/gpu/drm/i915/i915_gem.c
is in gen8_emit_flush and gen6_bsd_ring_flush I think.
And interesting that the subsequent seqno write can apparently be
reordered with cache flushing. Or do we just need lots more of those
(wasn't the magic number once 32 or so)?
Anyway can't argue with hw, so Acked (with the other 2 functions upd
On Wed, Jan 21, 2015 at 07:45:01PM +0200, Jani Nikula wrote:
> On Wed, 10 Dec 2014, Daniel Vetter wrote:
> > On Wed, Dec 10, 2014 at 08:17:11AM +, Chris Wilson wrote:
> >> This added as a BUG_ON as it considered that no one would ever request
> >> an unaligned ob
On Tue, Jan 20, 2015 at 11:46:57AM +0200, Ville Syrjälä wrote:
> On Tue, Jan 20, 2015 at 11:33:22AM +0200, Ander Conselvan de Oliveira wrote:
> > On 01/20/2015 11:22 AM, Daniel Vetter wrote:
> > > On Mon, Jan 19, 2015 at 03:51:47PM +0200, Ander Conselvan de Oli
primary_update_size(crtc);
I think Ville raised a really good point about the fragility of this and
restoring plane state correctly. I think conceptually it makes more sense
to restore the primary plane state together with the fb in the loop at the
end of intel_modeset_init. Would th
On Thu, Jan 15, 2015 at 08:44:00PM +, Chris Wilson wrote:
> On Thu, Jan 15, 2015 at 08:36:15PM +0100, Daniel Vetter wrote:
> > On Wed, Jan 14, 2015 at 9:34 PM, Chris Wilson
> > wrote:
> > > This (partially) reverts
> > >
> > > commit 5537252b6b6
we also revert the hunk in i915_gem_free_objects? Without
the truncate vs. invalidate disdinction it seems to have lost it's
reason for existence ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send t
object_put_pages(struct drm_i915_gem_object
> *obj)
> ops->put_pages(obj);
> obj->pages = NULL;
>
> - i915_gem_object_invalidate(obj);
> + if (i915_gem_object_is_purgeable(obj))
> + i915_gem_object_truncate(obj);
>
> return 0;
> }
> --
> 2.1.4
>
>
On Tue, Jan 13, 2015 at 01:24:12PM +0200, Ville Syrjälä wrote:
> On Tue, Jan 13, 2015 at 12:34:06AM +0100, Daniel Vetter wrote:
> > On Mon, Jan 12, 2015 at 05:36:52PM +0200, Ander Conselvan de Oliveira wrote:
> > > Otherwise setting the rotation property will cause the primary
ug.cgi?id=87662
> Signed-off-by: Ander Conselvan de Oliveira
>
Reviewed-by: Daniel Vetter
I guess long term we need to consolidate all our plane state related
readout functions, atm it's splattered all over. But that's maybe
something for after all the atomic work has stablized a
On Mon, Jan 12, 2015 at 6:43 PM, Luis Henriques
wrote:
> On Mon, Jan 12, 2015 at 06:20:22PM +0100, Daniel Vetter wrote:
>> On Sun, Jan 11, 2015 at 10:49 PM, Ben Hutchings wrote:
>> > On Mon, 2014-12-15 at 14:24 +, Luis Henriques wrote:
>> >> 3.16.7-ckt3 -stabl
t;> From: Chris Wilson
>>
>> commit f96de58fc7e7d3d717c7c63975c3b896c906b5e3 upstream.
>>
>> Signed-off-by: Chris Wilson
>> Reviewed-by: Jani Nikula
>> Signed-off-by: Daniel Vetter
>> Signed-off-by: Luis Henriques
>
> Should this also be applied to any older stable
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87955
> Signed-off-by: Chris Wilson
> Cc: stable@vger.kernel.org
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/i915/i915_gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gp
at to do with this patch now. It looks like all we needed was
> your patch. Merge without the "stable" is what I'm thinking.
Makes sense if we really don't need it any more with Chris' patches in
-fixes. Can you please volunteer someone to cough up an r-b?
Thanks, Daniel
--
On Tue, Dec 16, 2014 at 09:55:23AM +, Chris Wilson wrote:
> On Tue, Dec 16, 2014 at 10:19:47AM +0100, Daniel Vetter wrote:
> > Hm right, there have been patches floating around for that one ... A short
> > mention in the commit message about this would be useful.
>
>
t; v2: Make it explicit that the PSMI LRI are an extension to the original
> workaround for the other rings.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80660
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83677
> Cc: Simon Farnsworth
> Cc: Daniel Vett
1 - 100 of 441 matches
Mail list logo
