Re: 12.2 Splay Tree ipfw potential panic source

2021-07-10 Thread Karl Denninger
At first blush the hotfix appears effective; said box has 17 minutes of uptime on it with the patch, which is more than double the best without it. On 7/10/2021 08:55, Lutz Donnerhacke wrote: On Sat, Jul 10, 2021 at 02:33:51PM +0200, Lutz Donnerhacke wrote: I'll issue a review tomorrow.

Re: 12.2 Splay Tree ipfw potential panic source

2021-07-10 Thread Lutz Donnerhacke
On Sat, Jul 10, 2021 at 02:33:51PM +0200, Lutz Donnerhacke wrote: > I'll issue a review tomorrow. Thank you @se for adding the hotfix. So we have time to find a longer term solution. https://reviews.freebsd.org/D31132

Re: [PATCH] Re: 12.2 Splay Tree ipfw potential panic source

2021-07-10 Thread Karl Denninger
On 7/10/2021 04:52, Stefan Esser wrote: Am 10.07.21 um 10:23 schrieb Stefan Esser: Am 10.07.21 um 04:41 schrieb Karl Denninger: Ok, so I have good news and bad news. I have the trap and it is definitely in libalias which appears to come about as a result of a NAT translation attempt. Fatal tr

Re: [PATCH] Re: 12.2 Splay Tree ipfw potential panic source

2021-07-10 Thread Lutz Donnerhacke
On Sat, Jul 10, 2021 at 10:52:48AM +0200, Stefan Esser wrote: > > /sys/netinet/libalias/alias_db.c:1753: > > > > if (packets % packet_limit == 0) { > > > > Seems that packet_limit can become zero, there ... > > > > At line 1780 within that function: > > > > if (now !

[PATCH] Re: 12.2 Splay Tree ipfw potential panic source

2021-07-10 Thread Stefan Esser
Am 10.07.21 um 10:23 schrieb Stefan Esser: > Am 10.07.21 um 04:41 schrieb Karl Denninger: >> Ok, so I have good news and bad news. >> >> I have the trap and it is definitely in libalias which appears to come about >> as >> a result of a NAT translation attempt. >> >> Fatal trap 18: integer divide

Re: 12.2 Splay Tree ipfw potential panic source

2021-07-10 Thread Stefan Esser
Am 10.07.21 um 04:41 schrieb Karl Denninger: > Ok, so I have good news and bad news. > > I have the trap and it is definitely in libalias which appears to come about > as > a result of a NAT translation attempt. > > Fatal trap 18: integer divide fault while in kernel mode [...] > HouseKeeping()

Re: 12.2 Splay Tree ipfw potential panic source

2021-07-09 Thread Karl Denninger
On 7/9/2021 18:06, Karl Denninger wrote: On 7/9/2021 16:17, Ryan Stone wrote: On Thu, Jul 8, 2021 at 8:54 PM Karl Denninger wrote: I will see if I can get at least a panic backtrace, although the impacted box is a pcEngines firewall that boots of an SD card. Have you checked whether netdump s

Re: 12.2 Splay Tree ipfw potential panic source

2021-07-09 Thread Karl Denninger
On 7/9/2021 16:17, Ryan Stone wrote: On Thu, Jul 8, 2021 at 8:54 PM Karl Denninger wrote: I will see if I can get at least a panic backtrace, although the impacted box is a pcEngines firewall that boots of an SD card. Have you checked whether netdump supports your NICs? You should be able to

Re: 12.2 Splay Tree ipfw potential panic source

2021-07-09 Thread Ryan Stone
On Thu, Jul 8, 2021 at 8:54 PM Karl Denninger wrote: > I will see if I can get at least a panic backtrace, although the > impacted box is a pcEngines firewall that boots of an SD card. Have you checked whether netdump supports your NICs? You should be able to get a full vmcore off if so.

Re: 12.2 Splay Tree ipfw potential panic source

2021-07-08 Thread Karl Denninger
On 7/8/2021 18:11, Lutz Donnerhacke wrote: On Thu, Jul 08, 2021 at 05:38:35PM -0400, Karl Denninger wrote: This is the only change I'm aware of in the build I just put on a firewall that uses ipfw heavily, and it is not panic'ing quite regularly. The code was delayed considerably for MFC until

Re: 12.2 Splay Tree ipfw potential panic source

2021-07-08 Thread Lutz Donnerhacke
On Thu, Jul 08, 2021 at 05:38:35PM -0400, Karl Denninger wrote: > This is the only change I'm aware of in the build I just put on a firewall > that uses ipfw heavily, and it is not panic'ing quite regularly. The code was delayed considerably for MFC until such problems are identified, tested and

12.2 Splay Tree ipfw potential panic source

2021-07-08 Thread Karl Denninger
This is the only change I'm aware of in the build I just put on a firewall that uses ipfw heavily, and it is not panic'ing quite regularly. Same build, stable/12-n233371-c3e6df3967f, works fine without ipfw in active use on a different machine. I'll see if I can get a dump from it but that ma