Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2017-01-06 Thread Daniel-Constantin Mierla
On 06/01/2017 09:15, Yasin CANER wrote: > > Hello; > > it is working but some braces are missing. > Providing more details would help to understand what you are meaning and where you think the issue is -- just a dry note is not helpful. Daniel > Thanks for support. Have a nice day. > > [ro

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2017-01-06 Thread Yasin CANER
Hello;     it is working but some braces are missing. Thanks for support. Have a nice day. [root@TestDispatcher ~]# kamcmd cr.reload_routes [root@TestDispatcher ~]# kamcmd cr.dump_routes {     routes: {   

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2017-01-05 Thread Daniel-Constantin Mierla
Hello, I think I found the issue -- an improper pointer was passed to rpc struct_add. Fetch again master and try to see if this time all goes ok. Cheers, Daniel On 05/01/2017 09:47, Yasin CANER wrote: > > Hello; > > it gives error as below. > > Cheers. > > [root@Test master]# 10(29238) ERR

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2017-01-05 Thread Yasin CANER
Hello;     it gives error as below. Cheers. [root@Test  master]# 10(29238) ERROR: ctl [binrpc_run.c:1112]: rpc_struct_add(): failed to add attribute-value (S) 10(29238) ERROR: carrierroute [cr_fifo.c:1192]: cr_rpc_dump_routes()

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2017-01-05 Thread Daniel-Constantin Mierla
Hello, thanks, got some leads with the new log messages, so I pushed another commit to see which of the fields there is causing the problem. Can you fetch again master and give it another try? Cheers, Daniel On 05/01/2017 09:09, Yasin CANER wrote: > > Hello; > > Results are here. Once i tried c

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2017-01-05 Thread Yasin CANER
Hello; Results are here. Once i tried carrierroute config with kamailio V4.1.9 and it works. here version is kamailio 5.0.0-dev10 . it is started with "kamailio -dd -E" [root@Test  master]# kamcmd cr.reload_routes [root@T

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2017-01-04 Thread Daniel-Constantin Mierla
Hello, thanks for testing... Can you use latest master version, load jsonrpcs.so module and then issue the command: kamctl rpc cr.dump_routes Note that you may need to edit kamctlrc and set ctl engine to RPCFIFO if you have an older version of kamctlrc file installed. Cheers, Daniel On 04/01

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2017-01-04 Thread Yasin CANER
Hello;     I think problem is my config. 4.4.4 version is cloned and try to run. it runs kamailio but kamctl cr reload command gives error "ERROR: This command requires a database engine - none was loaded" I am digging configuration. In additon , how can understan

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2017-01-04 Thread Yasin CANER
Hello;     lastest master branched is pulled and worked with kamailio -ddd -E . cr.reload method works fine but cr.dump_routes gives error message like "error: 500 - Internal error - carrier structure"     debug messages are here "[  ma

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2017-01-04 Thread Yasin CANER
Hello;     kamailio Version 4.1 installed and tried same configuration with carrierroute. it is working kamctl function but i had to remove  a "require_dbengine" function in kamctl. it checks that is it suport db_mysql. Anyway , configuration is working with k

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2017-01-03 Thread Daniel-Constantin Mierla
Hello, quick follow up to see if you got any chance to test with latest master. Cheers, Daniel On 23/12/2016 15:15, Daniel-Constantin Mierla wrote: > > Hello, > > can you fetch again the git master, recompile, reinstall and test > again? Send here the log messages you get in syslog, because I a

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2016-12-23 Thread Daniel-Constantin Mierla
Hello, can you fetch again the git master, recompile, reinstall and test again? Send here the log messages you get in syslog, because I added some log messages inside the function that fails now. Cheers, Daniel On 23/12/2016 12:39, Yasin CANER wrote: > > Hello; > > it is not working. it giv

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2016-12-23 Thread Yasin CANER
Hello;     it is not working. it gives error like below.i added simple  configuration. reload command working fine but dump gives error. i have a look at code but couldnt find why cannot add in structs. Thanks 13(32039) D

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2016-12-23 Thread Yasin CANER
Hello;     Thanks for your support. my main kamailio is 4.1 Version. Dump and reload functions is fine for me. I am really sorry i couldnt help you about it. I am testing  CR module now. Thanks 23.12.2016 11:46 tarihinde Daniel-

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2016-12-23 Thread Daniel-Constantin Mierla
Btw, if you use kamctl, then all should just work with the same commands like in the past if you fetch (at this time) latest git repository and load jsonrpcs module in your config. You may need to deploy latest kamctlrc, if you do an update and you did changes in the old one. Cheers, Daniel On 2

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2016-12-23 Thread Daniel-Constantin Mierla
Ok, thanks. Note that I just pushed another commit renaming the command from cr.dump to cr.dump_routes in order to match better the mi old command. Cheers, Daniel On 23/12/2016 09:35, Yasin CANER wrote: > > Hello; > > I will try it now. Thanks. > > > > 23.12.2016 11:33 tarihinde Daniel-Const

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2016-12-23 Thread Yasin CANER
Hello;     I will try it now. Thanks. 23.12.2016 11:33 tarihinde Daniel-Constantin Mierla yazdı: Hello, I just pushed a commit for cr.dump rpc command in git master, can you give it a try and report the issues? I d

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2016-12-23 Thread Daniel-Constantin Mierla
Hello, I just pushed a commit for cr.dump rpc command in git master, can you give it a try and report the issues? I don't use the module so I had no testing environment to play with it. Cheers, Daniel On 06/12/2016 08:54, ycaner wrote: > > Hello, > > you are right. some carrier route functions

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2016-12-13 Thread Daniel-Constantin Mierla
Hello, comparing the list of rpc vs mi commands, also taking in consideration the interest and expressed feedback from the community, there is no reason to keep MI code longer. Also, during the last days it was signaled that mi_xmlrpc code will need an upgrade for next versions of compilers and xm

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2016-12-06 Thread Daniel-Constantin Mierla
Hello, On 06/12/2016 08:54, ycaner wrote: > > Hello, > > you are right. some carrier route functions are missing.important of > them are dump and show methods.if i have time ,i can add them. > that will be great if you can contribute. Cheers, Daniel > Cheers. > > > 6.12.2016 10:48 tarihinde Dan

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2016-12-05 Thread ycaner
Hello, you are right. some carrier route functions are missing.important of them are dump and show methods.if i have time ,i can add them. Cheers. 6.12.2016 10:48 tarihinde Daniel-Constantin Mierla-6 [via SIP Router] yazdı:

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2016-12-05 Thread Daniel-Constantin Mierla
Hello, looking in the code I see the carrierroute module has already rpc command for reload operations. But there are some other mi commands not implemented as rpc. Cheers, Daniel On 05/12/2016 11:28, Daniel-Constantin Mierla wrote: > Hello, > > few that are missing can be probably added once w

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2016-12-05 Thread Daniel-Constantin Mierla
Hello, few that are missing can be probably added once we discover them. The best is to open an issue on bug tracker whenever you are aware of a mi command not implemented in rpc. Even better will be a pull request :-) -- migrating from mi to rpc should not be complex and rather easy to lean by lo

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2016-12-02 Thread ycaner
Hello Carrier route module doesnt have RPC command., we need to add it Cheers. -- View this message in context: http://sip-router.1086192.n5.nabble.com/VERY-IMPORTANT-deciding-when-to-remove-the-MI-code-tp153719p153773.html Sent from the Users mailing list archive at Nabble.com. _

Re: [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

2016-12-01 Thread Brandon Armstead
+1 - I'm all for cleaning up any technical debt and moving on with more normalized concept. :) Sincerely, Brandon Armstead On Thu, Dec 1, 2016 at 6:17 AM Daniel-Constantin Mierla wrote: > Hello, > > we started discussing about removing MI (so called management interface) > for very long time,