Re: [SR-Users] Keep-Alive in dialog "freeing a free fragment"

2015-06-16 Thread Dirk Teurlings - SIGNET B.V.
Hi Daniel, Just applied this patch on 4.2.5, debian wheezy stable from kamailio.org. Unfortunately it doesn't fix the problem. Looking into CNXCC master code I noticed that there are quite a few changes now. I will try and backport CNXCC from master to 4.2.5 first before coming back to this

Re: [SR-Users] Keep-Alive in dialog "freeing a free fragment"

2015-06-16 Thread Daniel-Constantin Mierla
I just pushed the patch -- commit link is: - https://github.com/kamailio/kamailio/commit/9c3ea838b31039ac067e17d519df67b64b0dada1 Testing and reporting the results will be really appreciated. Cheers, Daniel On 16/06/15 14:32, Daniel-Constantin Mierla wrote: > Hello, > > the respective patch w

Re: [SR-Users] Keep-Alive in dialog "freeing a free fragment"

2015-06-16 Thread Daniel-Constantin Mierla
Hello, the respective patch was done to fix generating CDRs on local BYE. Maybe cnxcc is locking slots as well, I am not familiar with the module at all. Perhaps the best is to change the mutexes to be re-entrant, to avoid such conflicts between dialog and upper layer modules relying on it. I wil

Re: [SR-Users] Keep-Alive in dialog "freeing a free fragment"

2015-06-16 Thread Dirk Teurlings - SIGNET B.V.
Hello, Following up on this issue, though KA seems to work fine now. We're running into another problem. We use a fork of CNXCC that terminates all calls when the user doesn't have enough credit. But with these patches that doesn't work anymore and the current thread even locks up completely.

Re: [SR-Users] Keep-Alive in dialog "freeing a free fragment"

2015-05-12 Thread Daniel-Constantin Mierla
Hello, master is still the code to be 4.3, we will make a dedicated branch sometime soon. The patch will be backported to 4.2 as well. Thanks for helping to troubleshoot and testing. Cheers, Daniel On 12/05/15 10:03, Dirk Teurlings - SIGNET B.V. wrote: > Hi Daniel, > > This fixes the problem, t

Re: [SR-Users] Keep-Alive in dialog "freeing a free fragment"

2015-05-12 Thread Dirk Teurlings - SIGNET B.V.
Hi Daniel, This fixes the problem, thanks very much, Will this fix be included in the next (4.2 and/or 4.3) stable release? Cheers, Dirk Teurlings On 11-05-15 17:25, Daniel-Constantin Mierla wrote: Following quickly up, I pushed another patch that will remove the dialog from keepalive list

Re: [SR-Users] Keep-Alive in dialog "freeing a free fragment"

2015-05-11 Thread Daniel-Constantin Mierla
Following quickly up, I pushed another patch that will remove the dialog from keepalive list as soon as 'deleted' state is discovered and also sends keepalive options only if dialog is in state 'confirmed'. Can you test the patch and see how it works? - https://github.com/kamailio/kamailio/comm

Re: [SR-Users] Keep-Alive in dialog "freeing a free fragment"

2015-05-11 Thread Daniel-Constantin Mierla
Hello, the message "freeing a free fragment ..." is from Dialog KA Timer and that process doesn't handle any SIP reply or the transmission timeout callback. I will look at the code and see if I can spot where the double free happens. But now I understand that the dialog is actually not ended, rig

Re: [SR-Users] Keep-Alive in dialog "freeing a free fragment"

2015-05-07 Thread Dirk Teurlings - SIGNET B.V.
Hi Daniel, Good to see you found an improvement, not sure yet if it'll help us. Here is the non-debug log first. Just now I noticed that the initial dialog doesn't get ended as well now, 5fa4dc3670596fb626269f083b0c9480 in the log. The setup is like this Leg 1 Kamailio -> Asterisk L

Re: [SR-Users] Keep-Alive in dialog "freeing a free fragment"

2015-05-07 Thread Daniel-Constantin Mierla
Hello, I couldn't correlate the log message for double free with the code for bye_reply_cb and dlg_ka_cb. The logs from pid 24493 shows only dialog lookups and that double free message. Do you have the instance still running? Can you send the output of: kamctl ps Also, would be helpful to see s

Re: [SR-Users] Keep-Alive in dialog "freeing a free fragment"

2015-05-07 Thread Dirk Teurlings - SIGNET B.V.
Hi again, File dlg_req_within.c function bye_reply_cb line: 166-236 functino dlg_ka_cb line: 240-275 To help you out a bit more, this is important part of the log. May 4 18:09:42 vps-host /usr/sbin/kamailio[24484]: DEBUG: dialog [dlg_hash.c:1066]: next_state_dlg(): dialog 0x7

Re: [SR-Users] Keep-Alive in dialog "freeing a free fragment"

2015-05-07 Thread Daniel-Constantin Mierla
Hello, thanks for reporting and troubleshooting. Can you refer to the code (file+lines) for step 3 and 4? It will save me some time to look into the code and fix the issue. Cheers, Daniel On 07/05/15 08:46, Dirk Teurlings - SIGNET B.V. wrote: > Hi, > > (Kamailio 4.2.3) > > Working to get dialog