Re: [SR-Users] use append_hf() and remove_hf() on the same message

2013-11-06 Thread Camille Oudot
Le Wed, 6 Nov 2013 12:48:47 +0100, Daniel-Constantin Mierla a écrit : > What defines you set for each of the cases? I see there is an else > left open inside the #!ifdef, which ends up in getting an append_hf() > if the define id is set. Hello Daniel, thanks, you figured it right: the WITH_NAT

Re: [SR-Users] use append_hf() and remove_hf() on the same message

2013-11-06 Thread Daniel-Constantin Mierla
Hello, On 11/5/13 4:49 PM, Camille Oudot wrote: Le Tue, 5 Nov 2013 14:53:34 +0100, Daniel-Constantin Mierla a écrit : Even if the header is not present, insert/append_hf() should not fail Ok I assumed wrong. The issue looks trickier: I've made tests that go OK or KO depending on a harmless l

Re: [SR-Users] use append_hf() and remove_hf() on the same message

2013-11-05 Thread Camille Oudot
Le Tue, 5 Nov 2013 14:53:34 +0100, Daniel-Constantin Mierla a écrit : > Even if the header is not present, insert/append_hf() should not fail Ok I assumed wrong. The issue looks trickier: I've made tests that go OK or KO depending on a harmless looking cfg change. In the KO situation, a Path hea

Re: [SR-Users] use append_hf() and remove_hf() on the same message

2013-11-05 Thread Daniel-Constantin Mierla
Hello, On 11/5/13 12:37 PM, Camille Oudot wrote: Hi, I'm using remove_hf() and append_hf() to manipulate the sip headers on my application. Apparently, calling insert_hf("foo") after remove_hf("bar") if bar is the last header (not including Content-Length) is a bad idea, foo doesn't get inserte

[SR-Users] use append_hf() and remove_hf() on the same message

2013-11-05 Thread Camille Oudot
Hi, I'm using remove_hf() and append_hf() to manipulate the sip headers on my application. Apparently, calling insert_hf("foo") after remove_hf("bar") if bar is the last header (not including Content-Length) is a bad idea, foo doesn't get inserted (I understand that the append_hf() command tries t