Re: [SR-Users] terminate call when dialog when remote contact disappears without BYE

2015-12-03 Thread Thibault Gueslin
I mention that you wrote the patch because it should be easier for you to understand (or remember) the meaning of the patch. For sure, I will appreciate the backport in 4.3 Thank you. Thibault 2015-12-03 12:19 GMT+01:00 Daniel-Constantin Mierla : > I wrote many patches over the time, that's w

Re: [SR-Users] terminate call when dialog when remote contact disappears without BYE

2015-12-03 Thread Daniel-Constantin Mierla
I wrote many patches over the time, that's why I asked for the specific details ... I think I considered the patch too big to just backport and there was no extensive testing for it. If proved to work good and not break other things in 4.3, then it can be backported for the next minor release. Che

Re: [SR-Users] terminate call when dialog when remote contact disappears without BYE

2015-12-02 Thread Thibault Gueslin
You need also this commit: dialog: split out storage of contact from common memory block 3820f41ab7ba33c39cd9f67e179bf203aa60ddeb First tests give good result (applied on top of 4.3.4) Regards Thibault 2015-12-03 0:14 GMT+01:00 Thibault Gueslin : > Daniel-Constantin Mierla 2015-08-25 15:37:

Re: [SR-Users] terminate call when dialog when remote contact disappears without BYE

2015-12-02 Thread Thibault Gueslin
Daniel-Constantin Mierla 2015-08-25 15:37:34 de07fe4e78e2b7df59fbdffd74ca655bd77570ba dialog: refresh value for contact uri for each re-invite You wrote the patch! Regards Thibault 2015-12-02 22:56 GMT+01:00 Daniel-Constantin Mierla : > Can you give the commit id of the patch pushed t

Re: [SR-Users] terminate call when dialog when remote contact disappears without BYE

2015-12-02 Thread Daniel-Constantin Mierla
Can you give the commit id of the patch pushed to master? Cheers, Daniel On 02/12/15 19:12, Thibault Gueslin wrote: > I have seen that the patch submitted on master branch to fix this > issue have not been merged to branch 4.3 > > I wil try it. > > 2015-12-02 15:57 GMT+01:00 Thibault Gueslin > ma

Re: [SR-Users] terminate call when dialog when remote contact disappears without BYE

2015-12-02 Thread Thibault Gueslin
I have seen that the patch submitted on master branch to fix this issue have not been merged to branch 4.3 I wil try it. 2015-12-02 15:57 GMT+01:00 Thibault Gueslin : > How can I update the contact alias within the dialog on receiving the > invite ? > (My client is being NAT in any case) > > Sho

Re: [SR-Users] terminate call when dialog when remote contact disappears without BYE

2015-12-02 Thread Thibault Gueslin
How can I update the contact alias within the dialog on receiving the invite ? (My client is being NAT in any case) Should I use the dbg_var to set the new alias ? thibault 2015-12-02 9:41 GMT+01:00 Thibault Gueslin : > Hello Daniel, > > Have you seen the issue I reported: > > However I get

Re: [SR-Users] terminate call when dialog when remote contact disappears without BYE

2015-12-02 Thread Thibault Gueslin
Hello Daniel, Have you seen the issue I reported: However I get an issue when one party is changing connectivity: it sends an INVITE to update the location but the keep alive is still sent to the previous location. The dialog info (kamctl dialog show) still indicates the previous location. (It lo

Re: [SR-Users] terminate call when dialog when remote contact disappears without BYE

2015-12-01 Thread Daniel-Constantin Mierla
The dialog is terminated when the OPTIONS request doesn't get any reply, no matter it is sent via UDP, TCP or other transport. Cheers, Daniel On 01/12/15 12:08, Thibault Gueslin wrote: > Thanks > I don't have set the dialog property. > > I will add these lines on INVITE reception. > > dlg_set_pr

Re: [SR-Users] terminate call when dialog when remote contact disappears without BYE

2015-12-01 Thread Thibault Gueslin
It works that is fine. However I get an issue when one party is changing connectivity: it sends an INVITE to update the location but the keep alive is still sent to the previous location. The dialog info (kamctl dialog show) still indicates the previous location. (It looks like https://github.com/

Re: [SR-Users] terminate call when dialog when remote contact disappears without BYE

2015-12-01 Thread Thibault Gueslin
Thanks I don't have set the dialog property. I will add these lines on INVITE reception. dlg_set_property("ka-src"); dlg_set_property("ka-dst"); dlg_set_property("timeout-noreset"); But is it the proper way to do it with TCP connection ? >From the tran regards thibault 2015-12-01 11:10 GMT+01

Re: [SR-Users] terminate call when dialog when remote contact disappears without BYE

2015-12-01 Thread Daniel-Constantin Mierla
On 30/11/15 11:37, Thibault Gueslin wrote: > I would like to terminate the dialog when one party disconnects > without sending a BYE > (no more connctivity, client shutdown) > > I am using TCP connection. > > Should I terminate the dialog from event_route[usrloc:contact-expired] ? > > I have trie

[SR-Users] terminate call when dialog when remote contact disappears without BYE

2015-11-30 Thread Thibault Gueslin
I would like to terminate the dialog when one party disconnects without sending a BYE (no more connctivity, client shutdown) I am using TCP connection. Should I terminate the dialog from event_route[usrloc:contact-expired] ? I have tried also to use SIP OPTION parameter from dialog module modpar