Re: [SR-Users] lcr module and IPv6

2011-12-26 Thread Iñaki Baz Castillo
2011/12/21 Andreas Granig : > We could argue whether to not support square brackets and just allow > plain IP format, I've no strong opinions on that. I agree. IPv6 has no brackets, that's just a notation for using in URI's. -- Iñaki Baz Castillo ___

Re: [SR-Users] lcr module and IPv6

2011-12-21 Thread Andreas Granig
On 12/21/2011 03:47 PM, Juha Heinanen wrote: >> Well, the question was not where to store the IPv6 address, rather than >> in which format. As it is now, it'll allow it both with and without >> surrounding square brackets. That's where I have no strong opinions. > > ok, then push also change to lc

Re: [SR-Users] lcr module and IPv6

2011-12-21 Thread Juha Heinanen
Andreas Granig writes: > Well, the question was not where to store the IPv6 address, rather than > in which format. As it is now, it'll allow it both with and without > surrounding square brackets. That's where I have no strong opinions. ok, then push also change to lcr_gw schema and include an u

Re: [SR-Users] lcr module and IPv6

2011-12-21 Thread Andreas Granig
On 12/21/2011 02:43 PM, Juha Heinanen wrote: >> We could argue whether to not support square brackets and just allow >> plain IP format, I've no strong opinions on that. We just wanted to make >> it as flexible as possible. > > i cannot comment on storing ipv6 address, because i don't know anythin

Re: [SR-Users] lcr module and IPv6

2011-12-21 Thread Juha Heinanen
Andreas Granig writes: > Exactly. Sorry, forgot that part. Since the patch supports optional > surrounding square brackets, the max. length of an IPv6 address is 47. > > So it's either 8*4+7+2 for normal IPv6, like > "[:::::::]", or (6*4+5)+1+(4*3+3)+2 for > tunnel

Re: [SR-Users] lcr module and IPv6

2011-12-21 Thread Andreas Granig
Hi Juha, On 12/21/2011 02:11 PM, Juha Heinanen wrote: > based on the patch i got impression that it uses current ip_addr column > of lcr_gw table to store also ipv6 address? if so, then also the schema > file would need to be changed. Exactly. Sorry, forgot that part. Since the patch supports op

Re: [SR-Users] lcr module and IPv6

2011-12-21 Thread Juha Heinanen
Andreas Granig writes: > Please find attached the patch against git master, courtesy of my > colleague Richard Fuchs . > > Please review and apply if acceptable. andreas, based on the patch i got impression that it uses current ip_addr column of lcr_gw table to store also ipv6 address? if so,

Re: [SR-Users] lcr module and IPv6

2011-12-20 Thread Andreas Granig
Hello Juha, On 12/15/2011 01:22 PM, Juha Heinanen wrote: >> Just realized that lcr module does not support IPv6 yet. Is there >> already any work going on here? Otherwise we'd take this task over. > > i don't know of such work. if you decide to do it, try to not cause any > performance hit for c

[SR-Users] lcr module and IPv6

2011-12-15 Thread Juha Heinanen
Andreas Granig writes: > Just realized that lcr module does not support IPv6 yet. Is there > already any work going on here? Otherwise we'd take this task over. i don't know of such work. if you decide to do it, try to not cause any performance hit for current ipv4 usage. -- juha _

[SR-Users] lcr module and IPv6

2011-12-15 Thread Andreas Granig
All, Just realized that lcr module does not support IPv6 yet. Is there already any work going on here? Otherwise we'd take this task over. Andreas signature.asc Description: OpenPGP digital signature ___ SIP Express Router (SER) and Kamailio (OpenSER