I merged the pull request.
The commit message was close to the recommended format -- the first line
should have been:
auth: fixed issue when ...
In the commit is the other one.
Cheers,
Daniel
On 03/09/15 10:48, Vasiliy Ganchev wrote:
> the pull request prepared, hope it is well formatted (did
the pull request prepared, hope it is well formatted (did not have such
experience before)
Daniel, thank you for spending time on this issue, and help in finding the
right way )
--
View this message in context:
http://sip-router.1086192.n5.nabble.com/during-registration-nonce-expired-after-bac
Hello,
can you make a pull request on github with the last patch you tested? It
will be easier to merge, avoiding extra tests here -- just be sure the
commit message is formatted according to:
* http://www.kamailio.org/wiki/devel/github-contributions
Cheers,
Daniel
On 03/09/15 09:53, Vasiliy
Hi!
tested with:
+ /* if current time is less than start time, reset the start
time
+ (e.g., after start, the system clock was set in the past) */
+ t=time(0);
+ if (t < up_since)
+ up_since = t;
+ if
Hello,
the rpc process doesn't have the up_since value updated, because it is
stored in a local variable per process, thus only the sip worker process
updated its value. Probably they need a fix as well in this case.
Regarding:
"""
Do not understand how (mostly even why) to use this:
/ since >=
Hi!
Tested with this part:
+ /* if current time is less than start time, reset the start
time
+ (e.g., after start, the system clock was set in the past) */
+ t=time(0);
+ if (t < up_since)
+ up_since = t;
+
Hello,
good that you revived the thread, it got out of my sight being
distracted by other stuff.
I think that check has to be kept there, because it covers some
situations that can appear after restart, so removing it completely
won't be safe.
It can be a solution to reset up_since in this case,
Hi Daniel!
Any comments/idea about my last answer?
cheers
--
View this message in context:
http://sip-router.1086192.n5.nabble.com/during-registration-nonce-expired-after-backwards-time-shift-tp140536p140945.html
Sent from the Users mailing list archive at Nabble.com.
___
Daniel-Constantin Mierla-6 wrote
> I looked at the code and the system time is used (not the the internal
> value). Therefore, after detecting and invalid nonce, if you do
> challenge again, a nonce with the right time should be generated and
> used for authentication.
>
> Look at sip trace to see
Daniel-Constantin Mierla-6 wrote
> I looked at the code and the system time is used (not the the internal
> value). Therefore, after detecting and invalid nonce, if you do
> challenge again, a nonce with the right time should be generated and
> used for authentication.
>
> Look at sip trace to see
I looked at the code and the system time is used (not the the internal
value). Therefore, after detecting and invalid nonce, if you do
challenge again, a nonce with the right time should be generated and
used for authentication.
Look at sip trace to see if nonce is regenerated and run with debug=3
Hello,
probably the module is using the time computed internally as start time
plus elapsed seconds (counted internally). We can introduce an option to
use the system time, which may add a bit of delay, but really
insignificant. I will look into it these days.
Cheers,
Daniel
On 18/08/15 22:44,
Hi list!
(sorry for sending first mail to wrong sub forum)
Have a following issue:
Server with Kamailio restart with wrong time (why - this is separate part of
my investigations), timeshift e.g. for 2 hours in feature.
After ntp daemon adjust correct time (move time backwards), Kamailio do not
a
13 matches
Mail list logo
