Re: [SR-Users] dialog module: in-early-dialog requests / race conditions

2010-07-13 Thread Iñaki Baz Castillo
2010/7/13 Timo Reimann : >> Me too. There is no a "timer for dialog" in RFC 3261 so reusing >> transaction timers is the best approach IMHO. > > I have tested and committed the proposed re-usage of the transaction > timer to sip-router, Kamailio 3.0 and 1.5. Great, already compiled and will use it

Re: [SR-Users] dialog module: in-early-dialog requests / race conditions

2010-07-13 Thread Timo Reimann
Hey, Iñaki Baz Castillo wrote: > 2010/6/23 Timo Reimann : >> AFAICS, the current implementation removes dialog entries right after >> the moment the final request/response pair was seen. In order to prolong >> a dying dialog's lifetime, I see two possibilities: Use some >> time-triggered function

Re: [SR-Users] dialog module: in-early-dialog requests / race conditions

2010-06-23 Thread Iñaki Baz Castillo
2010/6/23 Timo Reimann : > AFAICS, the current implementation removes dialog entries right after > the moment the final request/response pair was seen. In order to prolong > a dying dialog's lifetime, I see two possibilities: Use some > time-triggered function that delays dialog deletion for a shor

Re: [SR-Users] dialog module: in-early-dialog requests / race conditions

2010-06-23 Thread Ovidiu Sas
On Wed, Jun 23, 2010 at 9:25 AM, Timo Reimann wrote: > Hi, > > > Ovidiu Sas wrote: >> On Tue, Jun 22, 2010 at 12:27 PM, Timo Reimann wrote: >>> 2.) Various race conditions may generate log messages such as following >>> when DID mode is enabled: >>> >>> WARNING:dialog:dlg_onroute: unable to find

Re: [SR-Users] dialog module: in-early-dialog requests / race conditions

2010-06-23 Thread Timo Reimann
Hi, Ovidiu Sas wrote: > On Tue, Jun 22, 2010 at 12:27 PM, Timo Reimann wrote: >> 2.) Various race conditions may generate log messages such as following >> when DID mode is enabled: >> >> WARNING:dialog:dlg_onroute: unable to find dialog for >> with route param 'faf.f69e7b4' [4015:79161711] >>

Re: [SR-Users] dialog module: in-early-dialog requests / race conditions

2010-06-22 Thread Timo Reimann
Hey Iñaki, Iñaki Baz Castillo wrote: > 2010/6/22 Timo Reimann : >> 1.) The module considers requests routed in early (but not yet >> confirmed) dialogs to be bogus, as can be seen from a few lines of state >> machine code in dlg_hash.c: >> >> http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-rout

Re: [SR-Users] dialog module: in-early-dialog requests / race conditions

2010-06-22 Thread Iñaki Baz Castillo
2010/6/22 Timo Reimann : > 1.) The module considers requests routed in early (but not yet > confirmed) dialogs to be bogus, as can be seen from a few lines of state > machine code in dlg_hash.c: > > http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=blob;f=modules_k/dialog/dlg_hash.c;h=6ab

Re: [SR-Users] dialog module: in-early-dialog requests / race conditions

2010-06-22 Thread Ovidiu Sas
On Tue, Jun 22, 2010 at 12:27 PM, Timo Reimann wrote: > Hello, > > I have two issues related to dialog module state keeping/logging that > caught my attention today: > > 1.) The module considers requests routed in early (but not yet > confirmed) dialogs to be bogus, as can be seen from a few lines

[SR-Users] dialog module: in-early-dialog requests / race conditions

2010-06-22 Thread Timo Reimann
Hello, I have two issues related to dialog module state keeping/logging that caught my attention today: 1.) The module considers requests routed in early (but not yet confirmed) dialogs to be bogus, as can be seen from a few lines of state machine code in dlg_hash.c: http://git.sip-router.org/cg