Oh, sorry, it's my first time to report patch for the project, will follow the
guide in future :-)
At 2014-09-23 14:39:37, "Daniel-Constantin Mierla" wrote:
Hello,
I applied the patch copying manually the changes -- you can try the master
branch to see if all works as expected. Son it wil
Hello,
I applied the patch copying manually the changes -- you can try the
master branch to see if all works as expected. Son it will get
backported to stable branches.
For future reference, you should use:
diff -u oldfile newfile >/tmp/file.patch
Then send the file.patch as attachment. The
Hi:
Sorry for the unconvinient, I didn't use git, I use diff tool generated diff
for t_msgbuilder.c as below, is it ok for you?
1400c1400
< + ((dialog->rem_uri.s[0]!='<')?2:0);
---
> + ((dialog->rem_uri.s[dialog->rem_uri.len - 1]!='>')?2:0);
1403c1403
< if(dialog->rem_uri.s[0]!='<')
Hello,
can you send the changes as patch (diff) file?
If you got kamailio from git, then you can do:
git diff > /path/to/file.patch
It is easier to review the changes and be sure we are not overwriting a
new version of the file.
Cheers,
Daniel
On 19/09/14 12:57, dongwf wrote:
Hi Daniel:
I
Hi Daniel:
I added my fixing in attached t_msgbuilder.c, please take a review, mainly
change in build_uac_req, print_to and print_from, thanks!
At 2014-09-17 04:25:17, "Daniel-Constantin Mierla" wrote:
Hello,
your remarks seems legit -- if you send a patch, I will review and commit it.
O
Hello,
your remarks seems legit -- if you send a patch, I will review and
commit it. Otherwise, open an issue on bugh tracker and will be fixed soon.
Cheers,
Daniel
On 17/09/14 10:06, dongwf wrote:
Hi kamailio dev:
I am writing a module to implement some features, my version is 4.1.2,
I am
Hi kamailio dev:
I am writing a module to implement some features, my version is 4.1.2, I am not
sure if it is a known issue, I found:
1. When I get a INVITE request with from/to like from:"display",
then I call tm's new_dlg_uas with the sip req, now the dlg's rem_uri set as
value: "display";
2.
