Re: [SR-Users] Decode contact with user paramer

2013-01-24 Thread Gareth Rylance
Sorry had wrong branch here it is ff22a1cbc2b817d63611b3da967d8245e11cb84c. On 24 January 2013 12:55, Gareth Rylance wrote: > I cant see the patch in master. Can you? > > > On 21 January 2013 20:13, Richard Brady wrote: > >> Patch attached. >> >> Should this be cross posted to [sr-dev] if it

Re: [SR-Users] Decode contact with user paramer

2013-01-24 Thread Gareth Rylance
I cant see the patch in master. Can you? On 21 January 2013 20:13, Richard Brady wrote: > Patch attached. > > Should this be cross posted to [sr-dev] if it contains a patch? > > Richard > > > On 7 January 2013 01:10, Richard Brady wrote: > >> Agreed, doesn't make sense to me either. >> >> The

Re: [SR-Users] Decode contact with user paramer

2013-01-22 Thread Daniel-Constantin Mierla
Thanks, patch was pushed to master branch. Cheers, Daniel On 1/21/13 9:13 PM, Richard Brady wrote: Patch attached. Should this be cross posted to [sr-dev] if it contains a patch? Richard On 7 January 2013 01:10, Richard Brady > wrote: Agreed, doesn't make sens

Re: [SR-Users] Decode contact with user paramer

2013-01-21 Thread Richard Brady
Patch attached. Should this be cross posted to [sr-dev] if it contains a patch? Richard On 7 January 2013 01:10, Richard Brady wrote: > Agreed, doesn't make sense to me either. > > The code is in the decode2format function in siputils/contact_ops.c: > > if (((*pos) == '

Re: [SR-Users] Decode contact with user paramer

2013-01-06 Thread Richard Brady
Agreed, doesn't make sense to me either. The code is in the decode2format function in siputils/contact_ops.c: if (((*pos) == '>')||(*pos == ';')) { /* invalid chars inside username part */

Re: [SR-Users] Decode contact with user paramer

2013-01-03 Thread Gareth Rylance
Anyone? If no one objects I will submit a patch with it removed. On 18 December 2012 09:11, Gareth Rylance wrote: > When using the siputils function encode_contact() on a message that > contains a user parameter e.g. > > ;tag=88930 > > it encodes fine e.g. > > > > > > but decode_contact() er

[SR-Users] Decode contact with user paramer

2012-12-18 Thread Gareth Rylance
When using the siputils function encode_contact() on a message that contains a user parameter e.g. ;tag=88930 it encodes fine e.g. but decode_contact() errors due to the ";" (there is an explicit check for it in the code) I am currently working round this using $rU = $(rU{s.replace,;,:});