[sr-dev] [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-18 Thread Remco van Vugt via sr-dev
A response to the amqp query caused a segfault in libc - Refactored parts of the code to be more readable and DRY - Split up functions for 3/4/5 arguments passed - Tested in 8.5.2 Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are sp

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Remco van Vugt via sr-dev
@linuxmaniac Thanks, fixed the commit message -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4002#issuecomment-2425976247 You are receiving this because you are subscribed to this thread. Message ID: ___

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Remco van Vugt via sr-dev
@remcovanvugt pushed 1 commit. 3c8126974f03c9a297e10e5db5d9b5fcbfd797aa kazoo: fixed segfault when using kazoo_query -- View it on GitHub: https://github.com/kamailio/kamailio/pull/4002/files/38c8cc862d5cd4b441d7ab8de55fd339b41cd1c1..3c8126974f03c9a297e10e5db5d9b5fcbfd797aa You are receiving t

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Remco van Vugt via sr-dev
@remcovanvugt commented on this pull request. > @@ -846,17 +846,17 @@ void kz_amqp_channel_close(kz_amqp_conn_ptr rmq, > amqp_channel_t channel) kz_amqp_error("closing channel", amqp_channel_close(rmq->conn, channel, AMQP_REPLY_SUCCESS)); } -#if AMQP_VERSION_MA

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Remco van Vugt via sr-dev
@remcovanvugt commented on this pull request. > @@ -846,17 +846,17 @@ void kz_amqp_channel_close(kz_amqp_conn_ptr rmq, > amqp_channel_t channel) kz_amqp_error("closing channel", amqp_channel_close(rmq->conn, channel, AMQP_REPLY_SUCCESS)); } -#if AMQP_VERSION_MA

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Remco van Vugt via sr-dev
> you need to format the code with clang-format and amend Done -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4002#issuecomment-2426078366 You are receiving this because you are subscribed to this thread. Message ID: _

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Remco van Vugt via sr-dev
@remcovanvugt pushed 1 commit. f8a1d2e86b2fe59c8d02a239dc7b893a4b92ee85 kazoo: fixed segfault when using kazoo_query -- View it on GitHub: https://github.com/kamailio/kamailio/pull/4002/files/61fcd7d73a8fd2ed68435f81f18dad9c5a941928..f8a1d2e86b2fe59c8d02a239dc7b893a4b92ee85 You are receiving t

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Remco van Vugt via sr-dev
@remcovanvugt commented on this pull request. > @@ -888,8 +888,8 @@ int kz_amqp_connection_open_ssl(kz_amqp_conn_ptr rmq) amqp_ssl_socket_set_verify( rmq->socket, kz_amqps_verify_peer | kz_amqps_verify_hostname); #else - amqp_ssl_socket_set_verify_peer(rmq

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Remco van Vugt via sr-dev
@remcovanvugt pushed 1 commit. 61fcd7d73a8fd2ed68435f81f18dad9c5a941928 kazoo: fixed segfault when using kazoo_query -- View it on GitHub: https://github.com/kamailio/kamailio/pull/4002/files/940293a8e53868aca618075bfa5c32baef948fa8..61fcd7d73a8fd2ed68435f81f18dad9c5a941928 You are receiving t

[sr-dev] Re: [kamailio/kamailio] [Websocket] websocket:closed event sometimes is not fired (Issue #3950)

2024-10-30 Thread Remco van Vugt via sr-dev
I can confirm this behavior in 5.8.2 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3950#issuecomment-2447091000 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamail