[sr-dev] xhttp_prom missing from kamailio-extra-modules

2024-02-20 Thread Ovidiu Sas via sr-dev
Hello, Any particular reason for not shipping xhttp_prom in a deb package? -ovidiu ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: xhttp_prom missing from kamailio-extra-modules

2024-02-21 Thread Ovidiu Sas via sr-dev
Answering to my own question: it is packaged into the main kamailio package. On Tue, Feb 20, 2024 at 10:54 PM Ovidiu Sas wrote: > > Hello, > > Any particular reason for not shipping xhttp_prom in a deb package? > > -ovidiu -- VoIP Embedded, Inc. http://www.voipembedded.com ___

[sr-dev] [kamailio/kamailio] xhttp_prom: export pkg mem statistics (PR #3793)

2024-03-25 Thread Ovidiu Sas via sr-dev
Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [ ] PR should be backported to stable branches -

[sr-dev] Re: [kamailio/kamailio] xhttp_prom: export pkg mem statistics (PR #3793)

2024-03-25 Thread Ovidiu Sas via sr-dev
I think it's better to control the pkg mem statistics via a parameter. If the admin want's the pkg mem stats to be available but the kex module is loaded after the xhttp_prom, the pkg mem stats won't be available which will lead to confusion. Also, this will keep the existing behavior untouched.

[sr-dev] Re: [kamailio/kamailio] xhttp_prom: export pkg mem statistics (PR #3793)

2024-03-25 Thread Ovidiu Sas via sr-dev
Another reason for implementing the pkg mem via a new parameter was related to the fact the pkg mem stats are not available via the `get_statistics` mi command. The idea was to mirror the mi layout over the xhttp_prometheus control. -- Reply to this email directly or view it on GitHub: https://

[sr-dev] Re: [kamailio/kamailio] xhttp_prom: export pkg mem statistics (PR #3793)

2024-03-25 Thread Ovidiu Sas via sr-dev
@ovidiusas pushed 2 commits. 5c66426a1380fbba7181956c43b341c96701d3b7 kex: clang format 07c82c46ff0900ba5fe57fb79e79408925b340d6 xhttp_prom: clang format -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3793/files/29f47c4d48e59b9dba5af8c7dbbc1d60a2748939..07c82c46ff0900ba5fe57fb

[sr-dev] Re: [kamailio/kamailio] xhttp_prom: export pkg mem statistics (PR #3793)

2024-03-25 Thread Ovidiu Sas via sr-dev
@ovidiusas pushed 1 commit. 5d14ddd277394b4d7fad6fc5bdc284bb4bfa68bf xhttp_prom: rename module parameter to xhttp_prom_pkg_stats -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3793/files/07c82c46ff0900ba5fe57fb79e79408925b340d6..5d14ddd277394b4d7fad6fc5bdc284bb4bfa68bf You are

[sr-dev] Re: [kamailio/kamailio] xhttp_prom: export pkg mem statistics (PR #3793)

2024-03-28 Thread Ovidiu Sas via sr-dev
Are we good to go with this one? The name of the parameter has been changed to `xhttp_prom_pkg_stats`. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3793#issuecomment-2025378262 You are receiving this because you are subscribed to this thread. Me

[sr-dev] Re: [kamailio/kamailio] xhttp_prom: export pkg mem statistics (PR #3793)

2024-03-29 Thread Ovidiu Sas via sr-dev
OK!. Then please merge it ... or I can do it. Is it just pressing the `Squash and merge` button? After that I will add the documentation. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3793#issuecomment-2027551190 You are receiving this because yo

[sr-dev] git:master:a55967c0: xhttp_prom: update documentation

2024-04-04 Thread Ovidiu Sas via sr-dev
Module: kamailio Branch: master Commit: a55967c0e8cee184f1cc8cc0c5df4635041b88d1 URL: https://github.com/kamailio/kamailio/commit/a55967c0e8cee184f1cc8cc0c5df4635041b88d1 Author: Ovidiu Sas Committer: Ovidiu Sas Date: 2024-04-04T10:10:15-04:00 xhttp_prom: update documentation --- Modified: s

[sr-dev] git:master:57dd65c2: xhttp_prom: use proper prefix for pkg stats

2024-04-04 Thread Ovidiu Sas via sr-dev
Module: kamailio Branch: master Commit: 57dd65c2c6abd520c0db876aca6bd2238229e187 URL: https://github.com/kamailio/kamailio/commit/57dd65c2c6abd520c0db876aca6bd2238229e187 Author: Ovidiu Sas Committer: Ovidiu Sas Date: 2024-04-04T16:22:39Z xhttp_prom: use proper prefix for pkg stats --- Modif

[sr-dev] git:master:6af0ae46: xhttp_prom: new uptime statistic

2024-04-05 Thread Ovidiu Sas via sr-dev
Module: kamailio Branch: master Commit: 6af0ae461486554481cbace41d50b8639b2ade8a URL: https://github.com/kamailio/kamailio/commit/6af0ae461486554481cbace41d50b8639b2ade8a Author: Ovidiu Sas Committer: Ovidiu Sas Date: 2024-04-05T18:21:29Z xhttp_prom: new uptime statistic --- Modified: src/mo

[sr-dev] git:master:bae35e49: xhttp_prom: update documentation for uptime statistic

2024-04-05 Thread Ovidiu Sas via sr-dev
Module: kamailio Branch: master Commit: bae35e49fa364de6a4c003c4484358d5592677de URL: https://github.com/kamailio/kamailio/commit/bae35e49fa364de6a4c003c4484358d5592677de Author: Ovidiu Sas Committer: Ovidiu Sas Date: 2024-04-05T18:28:32Z xhttp_prom: update documentation for uptime statistic

[sr-dev] git:master:4e614ba6: pua_dialoginfo: safety check for request pointer

2023-11-15 Thread Ovidiu Sas via sr-dev
Module: kamailio Branch: master Commit: 4e614ba6b7a5663bd88f353a3ce7a0976d8e878f URL: https://github.com/kamailio/kamailio/commit/4e614ba6b7a5663bd88f353a3ce7a0976d8e878f Author: Ovidiu Sas Committer: Ovidiu Sas Date: 2023-11-15T22:47:58-05:00 pua_dialoginfo: safety check for request pointer

[sr-dev] git:5.7:c30e0a3a: pua_dialoginfo: safety check for request pointer

2023-11-16 Thread Ovidiu Sas via sr-dev
Module: kamailio Branch: 5.7 Commit: c30e0a3a6dbe9b80b591ecb9caa53574ebc2988f URL: https://github.com/kamailio/kamailio/commit/c30e0a3a6dbe9b80b591ecb9caa53574ebc2988f Author: Ovidiu Sas Committer: Ovidiu Sas Date: 2023-11-16T08:55:51-05:00 pua_dialoginfo: safety check for request pointer (ch

[sr-dev] git:master:34054fbd: core: fix compilation for older kernels

2023-11-16 Thread Ovidiu Sas via sr-dev
Module: kamailio Branch: master Commit: 34054fbd144102d414318249de217cedf8e5bd39 URL: https://github.com/kamailio/kamailio/commit/34054fbd144102d414318249de217cedf8e5bd39 Author: Ovidiu Sas Committer: Ovidiu Sas Date: 2023-11-16T09:29:00-05:00 core: fix compilation for older kernels --- Modi

[sr-dev] git:5.7:308506c3: core: fix compilation for older kernels

2023-11-16 Thread Ovidiu Sas via sr-dev
Module: kamailio Branch: 5.7 Commit: 308506c3dacf9c22c63059166f5b674d0199eb44 URL: https://github.com/kamailio/kamailio/commit/308506c3dacf9c22c63059166f5b674d0199eb44 Author: Ovidiu Sas Committer: Ovidiu Sas Date: 2023-11-16T11:26:17-05:00 core: fix compilation for older kernels (cherry pick

[sr-dev] git:master:243951bc: core: fix indentation on tcp_main.c

2023-11-16 Thread Ovidiu Sas via sr-dev
Module: kamailio Branch: master Commit: 243951bc487c5c67c81062445d4f4d7ee725684f URL: https://github.com/kamailio/kamailio/commit/243951bc487c5c67c81062445d4f4d7ee725684f Author: Ovidiu Sas Committer: Ovidiu Sas Date: 2023-11-16T11:27:21-05:00 core: fix indentation on tcp_main.c --- Modified

[sr-dev] git:5.7:3e979157: core: fix indentation on tcp_main.c

2023-11-16 Thread Ovidiu Sas via sr-dev
Module: kamailio Branch: 5.7 Commit: 3e9791570645dee833737077b3326ca6acde6aef URL: https://github.com/kamailio/kamailio/commit/3e9791570645dee833737077b3326ca6acde6aef Author: Ovidiu Sas Committer: Ovidiu Sas Date: 2023-11-16T11:29:18-05:00 core: fix indentation on tcp_main.c (cherry picked f

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Ovidiu Sas via sr-dev
How about `f_log` or `file_log` instead of `file_out`? Also, the first parameter of `file_out` function seems to be an index to the defined filenames. If the order of the `file_out` modparams is changed, then the script has to be updated. It would be more intuitive to use the actual filename ins

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Ovidiu Sas via sr-dev
If performance is crucial, we can keep the index as a first parameter for the `file_out` function and we can change the definition of the `file_out` modparam: ``` modparam("file_out", "base_filename", "0:accounting") modparam("file_out", "base_filename", "1:missed_calls") ``` Populate slot `0` wit

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Ovidiu Sas via sr-dev
How about `f_print` or `file_print`? In the end, it doesn't really matter, but `file_out` doesn't seem to be very intuitive ... or maybe that's just me :) Thanks for contributing this, it is a nice addition! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamail

[sr-dev] Re: [Kamailio-Business] Re: [SR-Users] Releasing v5.8.4

2024-11-06 Thread Ovidiu Sas via sr-dev
I'm in the process of performing a similar upgrade. Instead of doing a big upgrade I went with several incremental upgrades between major releases. It provides better control over the entire upgrade process. -ovidiu On Wed, Nov 6, 2024 at 12:52 AM Ben Kaufman via business wrote: > > While I'm d

[sr-dev] Re: [kamailio/kamailio] cmake: should we use >= 3.13, i.e., "more modern cmake" generation? (Issue #4078)

2024-12-18 Thread Ovidiu Sas via sr-dev
I just tested installing cmake 3.31.2 as a binary and compiling it from source on a system that has only cmake 2.18.12. https://cmake.org/download/ With both methods kamailio compiled successfully. Note: it takes quite a while to compile cmake from source. On Wed, Dec 18, 2024 at 10:30 AM Daniel

[sr-dev] Re: [kamailio/kamailio] cmake: should we use >= 3.13, i.e., "more modern cmake" generation? (Issue #4078)

2024-12-18 Thread Ovidiu Sas via sr-dev
> @ovidiusas: in the past, you used to do cross-compiling. Are you still doing > it? If yes, is the new cmake build system supporting/impacting it? I used to cross-compile for optware. I no longer have a toolchain to test it. -- Reply to this email directly or view it on GitHub: https://github.

[sr-dev] Unable to build json module on Amazon Linux 2023 using cmake

2025-01-22 Thread Ovidiu Sas via sr-dev
Trying to build kamailio on Amazon Linux 2023. The json-c-devel package was installed, Unlike older versions of json, the json.h is located here: /usr/include/json-c/json.h This is correctly identified by pkg-config: # pkg-config --cflags json-c -I/usr/include/json-c Kamailio source code was in

[sr-dev] Re: [kamailio/kamailio] multiple Makefiles: evaluate LIBS variable imediately in Makefile (PR #4085)

2025-01-27 Thread Ovidiu Sas via sr-dev
On Amazon Linux pkg-config is installed and it still fails: ``` # pkg-config --cflags json-c -I/usr/include/json-c ``` Using different versions of cmake doesn't help. On Rocky Linux 8.10 it build ok (same path for json-c libraries). -- Reply to this email directly or view it on GitHub: https://gi

[sr-dev] Re: [kamailio/kamailio] multiple Makefiles: evaluate LIBS variable imediately in Makefile (PR #4085)

2025-01-27 Thread Ovidiu Sas via sr-dev
The `-isystem /usr/include/json-c` is missing from the compiler flags. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4085#issuecomment-2616710436 You are receiving this because you are subscribed to this thread. Message ID: __

[sr-dev] Re: [kamailio/kamailio] multiple Makefiles: evaluate LIBS variable imediately in Makefile (PR #4085)

2025-01-27 Thread Ovidiu Sas via sr-dev
It works ok with `json-c-devel-0.13.1` and it fails with `json-c-devel-0.14-8`. Here's a diff between the files installed by the two versions. The newer version has some cmake specific files, not sure if those ones are messing up the build. ``` $ sdiff json.0.13.1 json.0.14-8 $ repoquery --install

[sr-dev] git:master:577a8786: db_oracle: fix warning: passing argument 2 of ??????db_do_close?????? from incompatible pointer type [-Wincompatible-pointer-types]

2025-01-28 Thread Ovidiu Sas via sr-dev
Module: kamailio Branch: master Commit: 577a87861a8566e00f2700dfb227dcc8b26393b4 URL: https://github.com/kamailio/kamailio/commit/577a87861a8566e00f2700dfb227dcc8b26393b4 Author: Ovidiu Sas Committer: Ovidiu Sas Date: 2025-01-29T01:40:24Z db_oracle: fix warning: passing argument 2 of ??db_

[sr-dev] [kamailio/kamailio] db_oracle: fix db_oracle cmake build for oracle 18.3.0.0.0 (PR #4128)

2025-01-28 Thread Ovidiu Sas via sr-dev
This pull request enables db_oracle to be built against oracle 18.3.0.0.0 dev libraries using cmake. It requires the following env variables to be set: ``` declare -x ORACLE_HOME="/usr/lib/oracle/18.3/client64/" declare -x ORACLE_INCLUDE_DIR="/usr/include/oracle/18.3/client64" ``` You can view,

[sr-dev] Re: Releasing v6.0.2

2025-06-24 Thread Ovidiu Sas via sr-dev
We should backport the TLS fix for setting cipher suites: https://github.com/kamailio/kamailio/commit/6faf0470d0fab1594249e43d91000f324c5e25a7 https://github.com/kamailio/kamailio/commit/84a29ac892d1097a8d08a4853fd2749ee039405c https://docs.openssl.org/master/man3/SSL_CTX_set_cipher_list/ -ovidiu

[sr-dev] git:master:84a29ac8: tls: fix setting cipher suites for tls verions prior to 1.3

2025-06-23 Thread Ovidiu Sas via sr-dev
Module: kamailio Branch: master Commit: 84a29ac892d1097a8d08a4853fd2749ee039405c URL: https://github.com/kamailio/kamailio/commit/84a29ac892d1097a8d08a4853fd2749ee039405c Author: Ovidiu Sas Committer: Ovidiu Sas Date: 2025-06-23T13:48:00-04:00 tls: fix setting cipher suites for tls verions pri