[sr-dev] git:master:fa90e39b: cmake: modules - coherent CMakeLists.txt style for modules

2024-12-23 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: fa90e39bf357599d0ee81caad25b890229650afa URL: https://github.com/kamailio/kamailio/commit/fa90e39bf357599d0ee81caad25b890229650afa Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-12-24T08:26:44+01:00 cmake: modules - coher

[sr-dev] Re: [kamailio/kamailio] Common style of CMakeLists.txt for modules (Issue #4081)

2024-12-23 Thread Daniel-Constantin Mierla via sr-dev
Closed #4081 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4081#event-15754617311 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development

[sr-dev] Re: [kamailio/kamailio] Common style of CMakeLists.txt for modules (Issue #4081)

2024-12-23 Thread Daniel-Constantin Mierla via sr-dev
Pushed changes based on above comments. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4081#issuecomment-2560771315 You are receiving this because you are subscribed to this thread. Message ID: ___ Kam

[sr-dev] Re: [kamailio/kamailio] cmake is overriding distro hardening build flags (Issue #4082)

2024-12-23 Thread Xenofon Karamanos via sr-dev
Hey @space88man, We had this discussion with @linuxmaniac as well. In https://github.com/kamailio/kamailio/issues/4053#issuecomment-2545146514, you can find a way to provide the `CFLAGS` and the `LDFLAGS`. In [Environment Variables for Languages](https://cmake.org/cmake/help/latest/manual/cmak

[sr-dev] Re: [kamailio/kamailio] htable: `$shtcn` also counts expired items (Issue #4080)

2024-12-23 Thread Daniel-Constantin Mierla via sr-dev
Thanks for testing and reporting, it will be backported. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4080#issuecomment-2559396422 You are receiving this because you are subscribed to this thread. Message ID: __

[sr-dev] Re: [kamailio/kamailio] htable: `$shtcn` also counts expired items (Issue #4080)

2024-12-23 Thread Daniel-Constantin Mierla via sr-dev
Closed #4080 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4080#event-15746568707 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development

[sr-dev] [kamailio/kamailio] cmake - make clean deletes readme files from modules source folders (Issue #4084)

2024-12-23 Thread Daniel-Constantin Mierla via sr-dev
Executing `make clean` in the `build` folder deletes the `README` files from the modules folders. This is probably because the README is an output of a `cmake-make` command. What would be the best option to skip this removing? I found: - https://stackoverflow.com/questions/6259372/cmake-pre

[sr-dev] Re: [kamailio/kamailio] cmake is overriding distro hardening build flags (Issue #4082)

2024-12-23 Thread space88man via sr-dev
@xkaraman, I definitely want to keep all the `-DHAVE_XXX` flags deduced by the build system; however the compiler options like `-O0 -mtune=generic` need to be completely overridden. I tried just defining `CFLAGS="-O2 -g …"` but that got appended/prepended (?) to the CFLAGS so RHELs `FORTIFY_SO

[sr-dev] Re: [kamailio/kamailio] cmake - make clean deletes readme files from modules source folders (Issue #4084)

2024-12-23 Thread Daniel-Constantin Mierla via sr-dev
Fine for me whatever is considered better. For the records, I saw that there could be target events, like POST_BUILD, but I am not sure if it can be useful here: - https://cmake.org/cmake/help/latest/command/add_custom_command.html#build-events The readme generation has to be standalone, it

[sr-dev] Re: [kamailio/kamailio] cmake - make clean deletes readme files from modules source folders (Issue #4084)

2024-12-23 Thread Xenofon Karamanos via sr-dev
@miconda Does this happen after you have build the `kamailio_docs` target? Doing `make all` and then `make clean` does not clean the README as far as I can see, only if `make kamailio_docs` was previously run. We still don't want that, just want to have this observation noted. Reading the doc

[sr-dev] Re: [kamailio/kamailio] cmake format options and naming styles (Issue #4075)

2024-12-23 Thread Xenofon Karamanos via sr-dev
Suggestion to also set `enable_markup = False`. If true it reflows the comments to the decided `line_width`, disrespecting any new lines that may be intended by the author. Setting to `False` leaves the comments as written without alterning the new lines, and I believe is better for clarity.

[sr-dev] Re: [kamailio/kamailio] cmake is overriding distro hardening build flags (Issue #4082)

2024-12-23 Thread Xenofon Karamanos via sr-dev
@space88man Hmm, i just read through https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html. Since, the one you define is passed first (prepended) followed by the project options (each `target_compile_options` appends to the last ones), the last `-O` wins the race. I think since the default

[sr-dev] git:master:fc6acb01: pkg/kamailio: packaged topos_htable.so and presence_dfks.so into RPM

2024-12-23 Thread Sergey Safarov via sr-dev
Module: kamailio Branch: master Commit: fc6acb0195ced2ef73dc8bc10ba54368a763358a URL: https://github.com/kamailio/kamailio/commit/fc6acb0195ced2ef73dc8bc10ba54368a763358a Author: Sergey Safarov Committer: Sergey Safarov Date: 2024-12-22T21:22:02+02:00 pkg/kamailio: packaged topos_htable.so and

[sr-dev] git:master:5d400241: cmake: remove redundant default optimization level

2024-12-23 Thread S-P Chan via sr-dev
Module: kamailio Branch: master Commit: 5d4002415fd8377c5384beee387acf5ba9e2dfd3 URL: https://github.com/kamailio/kamailio/commit/5d4002415fd8377c5384beee387acf5ba9e2dfd3 Author: S-P Chan Committer: S-P Chan Date: 2024-12-24T06:50:08+08:00 cmake: remove redundant default optimization level -

[sr-dev] Re: [kamailio/kamailio] cmake is overriding distro hardening build flags (Issue #4082)

2024-12-23 Thread space88man via sr-dev
Closed #4082 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4082#event-15752281965 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development

[sr-dev] Re: [kamailio/kamailio] cmake is overriding distro hardening build flags (Issue #4082)

2024-12-23 Thread space88man via sr-dev
Closed with 5d4002415f. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4082#issuecomment-2560415566 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Developm